* [PATCH] perf: Add /scripts to sources
@ 2019-10-24 17:52 Daniel Díaz
2019-10-24 18:24 ` akuster808
0 siblings, 1 reply; 7+ messages in thread
From: Daniel Díaz @ 2019-10-24 17:52 UTC (permalink / raw)
To: openembedded-devel
As of linux-next-20191022, we need bpf_helpers_doc.py in order to
build libbpf, which lives in /scripts. Otherwise, do_compile fails
with:
| /bin/sh: 1: /oe/build/tmp/work/machine-triplet/perf/1.0-r9/perf-1.0/scripts/bpf_helpers_doc.py: not found
| Makefile:184: recipe for target 'bpf_helper_defs.h' failed
See commit e01a75c159691 ("libbpf: Move bpf_{helpers, helper_defs,
endian, tracing}.h into libbpf") from linux-next.
Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>
---
meta/recipes-kernel/perf/perf.bb | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
index 8201c0cb60..a463eebc52 100644
--- a/meta/recipes-kernel/perf/perf.bb
+++ b/meta/recipes-kernel/perf/perf.bb
@@ -113,6 +113,7 @@ PERF_SRC ?= "Makefile \
tools/Makefile \
tools/perf \
tools/scripts \
+ scripts \
"
PERF_EXTRA_LDFLAGS = ""
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] perf: Add /scripts to sources
2019-10-24 17:52 [PATCH] perf: Add /scripts to sources Daniel Díaz
@ 2019-10-24 18:24 ` akuster808
2019-10-24 18:34 ` Daniel Díaz
0 siblings, 1 reply; 7+ messages in thread
From: akuster808 @ 2019-10-24 18:24 UTC (permalink / raw)
To: Daniel Díaz, openembedded-devel
wrong ml
I think you want openembedded-core@lists.openembedded.org
On 10/24/19 10:52 AM, Daniel Díaz wrote:
> As of linux-next-20191022, we need bpf_helpers_doc.py in order to
> build libbpf, which lives in /scripts. Otherwise, do_compile fails
> with:
> | /bin/sh: 1: /oe/build/tmp/work/machine-triplet/perf/1.0-r9/perf-1.0/scripts/bpf_helpers_doc.py: not found
> | Makefile:184: recipe for target 'bpf_helper_defs.h' failed
>
> See commit e01a75c159691 ("libbpf: Move bpf_{helpers, helper_defs,
> endian, tracing}.h into libbpf") from linux-next.
>
> Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>
> ---
> meta/recipes-kernel/perf/perf.bb | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
> index 8201c0cb60..a463eebc52 100644
> --- a/meta/recipes-kernel/perf/perf.bb
> +++ b/meta/recipes-kernel/perf/perf.bb
> @@ -113,6 +113,7 @@ PERF_SRC ?= "Makefile \
> tools/Makefile \
> tools/perf \
> tools/scripts \
> + scripts \
> "
>
> PERF_EXTRA_LDFLAGS = ""
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] perf: Add /scripts to sources
2019-10-24 18:24 ` akuster808
@ 2019-10-24 18:34 ` Daniel Díaz
0 siblings, 0 replies; 7+ messages in thread
From: Daniel Díaz @ 2019-10-24 18:34 UTC (permalink / raw)
To: akuster808; +Cc: openembedded-devel
Hello!
On Thu, 24 Oct 2019 at 13:24, akuster808 <akuster808@gmail.com> wrote:
> wrong ml
> I think you want openembedded-core@lists.openembedded.org
Indeed. Thanks for the heads-up!
Greetings!
Daniel Díaz
daniel.diaz@linaro.org
> On 10/24/19 10:52 AM, Daniel Díaz wrote:
> > As of linux-next-20191022, we need bpf_helpers_doc.py in order to
> > build libbpf, which lives in /scripts. Otherwise, do_compile fails
> > with:
> > | /bin/sh: 1: /oe/build/tmp/work/machine-triplet/perf/1.0-r9/perf-1.0/scripts/bpf_helpers_doc.py: not found
> > | Makefile:184: recipe for target 'bpf_helper_defs.h' failed
> >
> > See commit e01a75c159691 ("libbpf: Move bpf_{helpers, helper_defs,
> > endian, tracing}.h into libbpf") from linux-next.
> >
> > Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>
> > ---
> > meta/recipes-kernel/perf/perf.bb | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
> > index 8201c0cb60..a463eebc52 100644
> > --- a/meta/recipes-kernel/perf/perf.bb
> > +++ b/meta/recipes-kernel/perf/perf.bb
> > @@ -113,6 +113,7 @@ PERF_SRC ?= "Makefile \
> > tools/Makefile \
> > tools/perf \
> > tools/scripts \
> > + scripts \
> > "
> >
> > PERF_EXTRA_LDFLAGS = ""
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] perf: Add /scripts to sources
2019-11-04 23:42 ` Bruce Ashfield
@ 2019-11-15 0:34 ` Daniel Díaz
0 siblings, 0 replies; 7+ messages in thread
From: Daniel Díaz @ 2019-11-15 0:34 UTC (permalink / raw)
To: Bruce Ashfield; +Cc: Patches and discussions about the oe-core layer
Hello!
On Mon, 4 Nov 2019 at 17:42, Bruce Ashfield <bruce.ashfield@gmail.com> wrote:
> On Mon, Nov 4, 2019 at 5:56 PM Daniel Díaz <daniel.diaz@linaro.org> wrote:
> > On Thu, 24 Oct 2019 at 13:34, Daniel Díaz <daniel.diaz@linaro.org> wrote:
> > > As of linux-next-20191022, we need bpf_helpers_doc.py in order to
> > > build libbpf, which lives in /scripts. Otherwise, do_compile fails
> > > with:
> > > | /bin/sh: 1: /oe/build/tmp/work/machine-triplet/perf/1.0-r9/perf-1.0/scripts/bpf_helpers_doc.py: not found
> > > | Makefile:184: recipe for target 'bpf_helper_defs.h' failed
> > >
> > > See commit e01a75c159691 ("libbpf: Move bpf_{helpers, helper_defs,
> > > endian, tracing}.h into libbpf") from linux-next.
> > >
> > > Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>
> > > ---
> > > meta/recipes-kernel/perf/perf.bb | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
> > > index 8201c0cb60..a463eebc52 100644
> > > --- a/meta/recipes-kernel/perf/perf.bb
> > > +++ b/meta/recipes-kernel/perf/perf.bb
> > > @@ -113,6 +113,7 @@ PERF_SRC ?= "Makefile \
> > > tools/Makefile \
> > > tools/perf \
> > > tools/scripts \
> > > + scripts \
> > > "
> > >
> > > PERF_EXTRA_LDFLAGS = ""
> > > --
> > > 2.20.1
> >
> > Ping.
>
> I just went through trying to reduce the amount of source that we copy
> for perf, since it has often ended up causing us maintenance pain.
>
> Can we just copy the one script we need, versus a complete copy of the
> directory ?
>
> My patch from a few weeks ago, makes it safe to copy a single file, so
> it should be doable.
I am unable to test that as I'm still stuck on Sumo. I can confirm
that "scripts/bpf_helpers_doc.py" doesn't work in such an old version,
whereas "scripts" does.
Thanks and greetings!
Daniel Díaz
daniel.diaz@linaro.org
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] perf: Add /scripts to sources
2019-11-04 22:56 ` Daniel Díaz
@ 2019-11-04 23:42 ` Bruce Ashfield
2019-11-15 0:34 ` Daniel Díaz
0 siblings, 1 reply; 7+ messages in thread
From: Bruce Ashfield @ 2019-11-04 23:42 UTC (permalink / raw)
To: Daniel Díaz; +Cc: Patches and discussions about the oe-core layer
On Mon, Nov 4, 2019 at 5:56 PM Daniel Díaz <daniel.diaz@linaro.org> wrote:
>
> Hello!
>
> On Thu, 24 Oct 2019 at 13:34, Daniel Díaz <daniel.diaz@linaro.org> wrote:
> > As of linux-next-20191022, we need bpf_helpers_doc.py in order to
> > build libbpf, which lives in /scripts. Otherwise, do_compile fails
> > with:
> > | /bin/sh: 1: /oe/build/tmp/work/machine-triplet/perf/1.0-r9/perf-1.0/scripts/bpf_helpers_doc.py: not found
> > | Makefile:184: recipe for target 'bpf_helper_defs.h' failed
> >
> > See commit e01a75c159691 ("libbpf: Move bpf_{helpers, helper_defs,
> > endian, tracing}.h into libbpf") from linux-next.
> >
> > Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>
> > ---
> > meta/recipes-kernel/perf/perf.bb | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
> > index 8201c0cb60..a463eebc52 100644
> > --- a/meta/recipes-kernel/perf/perf.bb
> > +++ b/meta/recipes-kernel/perf/perf.bb
> > @@ -113,6 +113,7 @@ PERF_SRC ?= "Makefile \
> > tools/Makefile \
> > tools/perf \
> > tools/scripts \
> > + scripts \
> > "
> >
> > PERF_EXTRA_LDFLAGS = ""
> > --
> > 2.20.1
>
> Ping.
I just went through trying to reduce the amount of source that we copy
for perf, since it has often ended up causing us maintenance pain.
Can we just copy the one script we need, versus a complete copy of the
directory ?
My patch from a few weeks ago, makes it safe to copy a single file, so
it should be doable.
Cheers,
Bruce
>
> Daniel Díaz
> daniel.diaz@linaro.org
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] perf: Add /scripts to sources
2019-10-24 18:34 Daniel Díaz
@ 2019-11-04 22:56 ` Daniel Díaz
2019-11-04 23:42 ` Bruce Ashfield
0 siblings, 1 reply; 7+ messages in thread
From: Daniel Díaz @ 2019-11-04 22:56 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
Hello!
On Thu, 24 Oct 2019 at 13:34, Daniel Díaz <daniel.diaz@linaro.org> wrote:
> As of linux-next-20191022, we need bpf_helpers_doc.py in order to
> build libbpf, which lives in /scripts. Otherwise, do_compile fails
> with:
> | /bin/sh: 1: /oe/build/tmp/work/machine-triplet/perf/1.0-r9/perf-1.0/scripts/bpf_helpers_doc.py: not found
> | Makefile:184: recipe for target 'bpf_helper_defs.h' failed
>
> See commit e01a75c159691 ("libbpf: Move bpf_{helpers, helper_defs,
> endian, tracing}.h into libbpf") from linux-next.
>
> Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>
> ---
> meta/recipes-kernel/perf/perf.bb | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
> index 8201c0cb60..a463eebc52 100644
> --- a/meta/recipes-kernel/perf/perf.bb
> +++ b/meta/recipes-kernel/perf/perf.bb
> @@ -113,6 +113,7 @@ PERF_SRC ?= "Makefile \
> tools/Makefile \
> tools/perf \
> tools/scripts \
> + scripts \
> "
>
> PERF_EXTRA_LDFLAGS = ""
> --
> 2.20.1
Ping.
Daniel Díaz
daniel.diaz@linaro.org
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] perf: Add /scripts to sources
@ 2019-10-24 18:34 Daniel Díaz
2019-11-04 22:56 ` Daniel Díaz
0 siblings, 1 reply; 7+ messages in thread
From: Daniel Díaz @ 2019-10-24 18:34 UTC (permalink / raw)
To: openembedded-core
As of linux-next-20191022, we need bpf_helpers_doc.py in order to
build libbpf, which lives in /scripts. Otherwise, do_compile fails
with:
| /bin/sh: 1: /oe/build/tmp/work/machine-triplet/perf/1.0-r9/perf-1.0/scripts/bpf_helpers_doc.py: not found
| Makefile:184: recipe for target 'bpf_helper_defs.h' failed
See commit e01a75c159691 ("libbpf: Move bpf_{helpers, helper_defs,
endian, tracing}.h into libbpf") from linux-next.
Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>
---
meta/recipes-kernel/perf/perf.bb | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
index 8201c0cb60..a463eebc52 100644
--- a/meta/recipes-kernel/perf/perf.bb
+++ b/meta/recipes-kernel/perf/perf.bb
@@ -113,6 +113,7 @@ PERF_SRC ?= "Makefile \
tools/Makefile \
tools/perf \
tools/scripts \
+ scripts \
"
PERF_EXTRA_LDFLAGS = ""
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-11-15 0:34 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-24 17:52 [PATCH] perf: Add /scripts to sources Daniel Díaz
2019-10-24 18:24 ` akuster808
2019-10-24 18:34 ` Daniel Díaz
2019-10-24 18:34 Daniel Díaz
2019-11-04 22:56 ` Daniel Díaz
2019-11-04 23:42 ` Bruce Ashfield
2019-11-15 0:34 ` Daniel Díaz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.