All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Alim Akhtar <alim.akhtar@samsung.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-phy@lists.infradead.org
Cc: devicetree@vger.kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, vkoul@kernel.org,
	avri.altman@wdc.com, martin.petersen@oracle.com,
	chanho61.park@samsung.com, pankaj.dubey@samsung.com,
	linux-fsd@tesla.com, Bharat Uppal <bharat.uppal@samsung.com>
Subject: Re: [PATCH 3/6] phy: samsung-ufs: add support for FSD ufs phy driver
Date: Mon, 30 May 2022 20:47:36 -0700	[thread overview]
Message-ID: <f4e1d900-5755-c57f-029a-eade78a17476@acm.org> (raw)
In-Reply-To: <20220531012220.80563-4-alim.akhtar@samsung.com>

On 5/30/22 18:22, Alim Akhtar wrote:
> diff --git a/drivers/phy/samsung/phy-fsd-ufs.c b/drivers/phy/samsung/phy-fsd-ufs.c
> new file mode 100644
> index 000000000000..a03656006093
> --- /dev/null
> +++ b/drivers/phy/samsung/phy-fsd-ufs.c
> @@ -0,0 +1,63 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * UFS PHY driver data for FSD SoC
> + *
> + * Copyright (C) 2022 Samsung Electronics Co., Ltd.
> + *
> + */
> +#ifndef _PHY_FSD_UFS_H_
> +#define _PHY_FSD_UFS_H_

Please do not use header file guards in a .c file.

Thanks,

Bart.

WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <bvanassche@acm.org>
To: Alim Akhtar <alim.akhtar@samsung.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-phy@lists.infradead.org
Cc: devicetree@vger.kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, vkoul@kernel.org,
	avri.altman@wdc.com, martin.petersen@oracle.com,
	chanho61.park@samsung.com, pankaj.dubey@samsung.com,
	linux-fsd@tesla.com, Bharat Uppal <bharat.uppal@samsung.com>
Subject: Re: [PATCH 3/6] phy: samsung-ufs: add support for FSD ufs phy driver
Date: Mon, 30 May 2022 20:47:36 -0700	[thread overview]
Message-ID: <f4e1d900-5755-c57f-029a-eade78a17476@acm.org> (raw)
In-Reply-To: <20220531012220.80563-4-alim.akhtar@samsung.com>

On 5/30/22 18:22, Alim Akhtar wrote:
> diff --git a/drivers/phy/samsung/phy-fsd-ufs.c b/drivers/phy/samsung/phy-fsd-ufs.c
> new file mode 100644
> index 000000000000..a03656006093
> --- /dev/null
> +++ b/drivers/phy/samsung/phy-fsd-ufs.c
> @@ -0,0 +1,63 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * UFS PHY driver data for FSD SoC
> + *
> + * Copyright (C) 2022 Samsung Electronics Co., Ltd.
> + *
> + */
> +#ifndef _PHY_FSD_UFS_H_
> +#define _PHY_FSD_UFS_H_

Please do not use header file guards in a .c file.

Thanks,

Bart.

-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <bvanassche@acm.org>
To: Alim Akhtar <alim.akhtar@samsung.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-phy@lists.infradead.org
Cc: devicetree@vger.kernel.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, vkoul@kernel.org,
	avri.altman@wdc.com, martin.petersen@oracle.com,
	chanho61.park@samsung.com, pankaj.dubey@samsung.com,
	linux-fsd@tesla.com, Bharat Uppal <bharat.uppal@samsung.com>
Subject: Re: [PATCH 3/6] phy: samsung-ufs: add support for FSD ufs phy driver
Date: Mon, 30 May 2022 20:47:36 -0700	[thread overview]
Message-ID: <f4e1d900-5755-c57f-029a-eade78a17476@acm.org> (raw)
In-Reply-To: <20220531012220.80563-4-alim.akhtar@samsung.com>

On 5/30/22 18:22, Alim Akhtar wrote:
> diff --git a/drivers/phy/samsung/phy-fsd-ufs.c b/drivers/phy/samsung/phy-fsd-ufs.c
> new file mode 100644
> index 000000000000..a03656006093
> --- /dev/null
> +++ b/drivers/phy/samsung/phy-fsd-ufs.c
> @@ -0,0 +1,63 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * UFS PHY driver data for FSD SoC
> + *
> + * Copyright (C) 2022 Samsung Electronics Co., Ltd.
> + *
> + */
> +#ifndef _PHY_FSD_UFS_H_
> +#define _PHY_FSD_UFS_H_

Please do not use header file guards in a .c file.

Thanks,

Bart.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-05-31  3:47 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220531012331epcas5p23a835b3635e187ef04d4f28f0933f7c1@epcas5p2.samsung.com>
2022-05-31  1:22 ` [PATCH 0/6] Add support for UFS controller found in FSD SoC Alim Akhtar
2022-05-31  1:22   ` Alim Akhtar
2022-05-31  1:22   ` Alim Akhtar
     [not found]   ` <CGME20220531012336epcas5p2fcafe14c90ad3e3a0901fccd62d15437@epcas5p2.samsung.com>
2022-05-31  1:22     ` [PATCH 1/6] dt-bindings: phy: Add FSD UFS PHY bindings Alim Akhtar
2022-05-31  1:22       ` Alim Akhtar
2022-05-31  1:22       ` Alim Akhtar
2022-05-31  3:44       ` Bart Van Assche
2022-05-31  3:44         ` Bart Van Assche
2022-05-31  3:44         ` Bart Van Assche
2022-06-03  1:20         ` Alim Akhtar
2022-06-03  1:20           ` Alim Akhtar
2022-06-03  1:20           ` Alim Akhtar
2022-05-31  9:17       ` Krzysztof Kozlowski
2022-05-31  9:17         ` Krzysztof Kozlowski
2022-05-31  9:17         ` Krzysztof Kozlowski
2022-06-03  1:30         ` Alim Akhtar
2022-06-03  1:30           ` Alim Akhtar
2022-06-03  1:30           ` Alim Akhtar
     [not found]   ` <CGME20220531012341epcas5p19b15b4916b210687ab6b46d6da0b2273@epcas5p1.samsung.com>
2022-05-31  1:22     ` [PATCH 2/6] phy: samsung-ufs: move cdr offset to drvdata Alim Akhtar
2022-05-31  1:22       ` Alim Akhtar
2022-05-31  1:22       ` Alim Akhtar
2022-05-31  9:56       ` Krzysztof Kozlowski
2022-05-31  9:56         ` Krzysztof Kozlowski
2022-05-31  9:56         ` Krzysztof Kozlowski
2022-06-03  1:31         ` Alim Akhtar
2022-06-03  1:31           ` Alim Akhtar
2022-06-03  1:31           ` Alim Akhtar
2022-05-31 10:09       ` Krzysztof Kozlowski
2022-05-31 10:09         ` Krzysztof Kozlowski
2022-05-31 10:09         ` Krzysztof Kozlowski
     [not found]   ` <CGME20220531012347epcas5p48262cae18c75bb6ed029f7cd920800b4@epcas5p4.samsung.com>
2022-05-31  1:22     ` [PATCH 3/6] phy: samsung-ufs: add support for FSD ufs phy driver Alim Akhtar
2022-05-31  1:22       ` Alim Akhtar
2022-05-31  1:22       ` Alim Akhtar
2022-05-31  3:47       ` Bart Van Assche [this message]
2022-05-31  3:47         ` Bart Van Assche
2022-05-31  3:47         ` Bart Van Assche
2022-06-03  1:21         ` Alim Akhtar
2022-06-03  1:21           ` Alim Akhtar
2022-06-03  1:21           ` Alim Akhtar
     [not found]   ` <CGME20220531012351epcas5p389e28e28a48f9bb14a52fc81c417296d@epcas5p3.samsung.com>
2022-05-31  1:22     ` [PATCH 4/6] dt-bindings: ufs: exynos-ufs: add fsd compatible Alim Akhtar
2022-05-31  1:22       ` Alim Akhtar
2022-05-31  1:22       ` Alim Akhtar
2022-05-31  9:58       ` Krzysztof Kozlowski
2022-05-31  9:58         ` Krzysztof Kozlowski
2022-05-31  9:58         ` Krzysztof Kozlowski
     [not found]   ` <CGME20220531012356epcas5p3cd6638d4d3eccb28a28d064c9f585a4f@epcas5p3.samsung.com>
2022-05-31  1:22     ` [PATCH 5/6] ufs: host: ufs-exynos: add support for fsd ufs hci Alim Akhtar
2022-05-31  1:22       ` Alim Akhtar
2022-05-31  1:22       ` Alim Akhtar
2022-05-31  7:37       ` Chanho Park
2022-05-31  7:37         ` Chanho Park
2022-05-31  7:37         ` Chanho Park
2022-06-03  1:42         ` Alim Akhtar
2022-06-03  1:42           ` Alim Akhtar
2022-06-03  1:42           ` Alim Akhtar
2022-05-31 10:01       ` Krzysztof Kozlowski
2022-05-31 10:01         ` Krzysztof Kozlowski
2022-05-31 10:01         ` Krzysztof Kozlowski
     [not found]   ` <CGME20220531012400epcas5p1c30b75a928097bd19855dcd0d929ff10@epcas5p1.samsung.com>
2022-05-31  1:22     ` [PATCH 6/6] arm64: dts: fsd: add ufs device node Alim Akhtar
2022-05-31  1:22       ` Alim Akhtar
2022-05-31  1:22       ` Alim Akhtar
2022-05-31 10:09       ` Krzysztof Kozlowski
2022-05-31 10:09         ` Krzysztof Kozlowski
2022-05-31 10:09         ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f4e1d900-5755-c57f-029a-eade78a17476@acm.org \
    --to=bvanassche@acm.org \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=bharat.uppal@samsung.com \
    --cc=chanho61.park@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fsd@tesla.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=pankaj.dubey@samsung.com \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.