From: Randy Dunlap <rdunlap@infradead.org> To: Michal Suchanek <msuchanek@suse.de>, alsa-devel@alsa-project.org Cc: Vinod Koul <vkoul@kernel.org>, Sanyog Kale <sanyog.r.kale@intel.com>, Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soundwire: slave: Fix unused function warning on !ACPI Date: Fri, 30 Aug 2019 11:56:21 -0700 [thread overview] Message-ID: <f8c58d45-e641-5071-33bf-2927a61cb419@infradead.org> (raw) In-Reply-To: <20190830185212.25144-1-msuchanek@suse.de> On 8/30/19 11:52 AM, Michal Suchanek wrote: > Fixes the following warning on !ACPI systems: > > drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but > not used [-Wunused-function] > static int sdw_slave_add(struct sdw_bus *bus, > ^~~~~~~~~~~~~ > > Signed-off-by: Michal Suchanek <msuchanek@suse.de> Acked-by: Randy Dunlap <rdunlap@infradead.org> I was about to send the same patch. Thanks. > --- > drivers/soundwire/slave.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soundwire/slave.c b/drivers/soundwire/slave.c > index f39a5815e25d..34c7e65831d1 100644 > --- a/drivers/soundwire/slave.c > +++ b/drivers/soundwire/slave.c > @@ -6,6 +6,7 @@ > #include <linux/soundwire/sdw_type.h> > #include "bus.h" > > +#if IS_ENABLED(CONFIG_ACPI) > static void sdw_slave_release(struct device *dev) > { > struct sdw_slave *slave = dev_to_sdw_dev(dev); > @@ -60,7 +61,6 @@ static int sdw_slave_add(struct sdw_bus *bus, > return ret; > } > > -#if IS_ENABLED(CONFIG_ACPI) > /* > * sdw_acpi_find_slaves() - Find Slave devices in Master ACPI node > * @bus: SDW bus instance > -- ~Randy
WARNING: multiple messages have this Message-ID (diff)
From: Randy Dunlap <rdunlap@infradead.org> To: Michal Suchanek <msuchanek@suse.de>, alsa-devel@alsa-project.org Cc: linux-kernel@vger.kernel.org, Vinod Koul <vkoul@kernel.org>, Sanyog Kale <sanyog.r.kale@intel.com>, Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Subject: Re: [alsa-devel] [PATCH] soundwire: slave: Fix unused function warning on !ACPI Date: Fri, 30 Aug 2019 11:56:21 -0700 [thread overview] Message-ID: <f8c58d45-e641-5071-33bf-2927a61cb419@infradead.org> (raw) Message-ID: <20190830185621.5jkL7RaAjB3BoavutLv_9xnWr8wmIySuWbakJcAbVtg@z> (raw) In-Reply-To: <20190830185212.25144-1-msuchanek@suse.de> On 8/30/19 11:52 AM, Michal Suchanek wrote: > Fixes the following warning on !ACPI systems: > > drivers/soundwire/slave.c:16:12: warning: ‘sdw_slave_add’ defined but > not used [-Wunused-function] > static int sdw_slave_add(struct sdw_bus *bus, > ^~~~~~~~~~~~~ > > Signed-off-by: Michal Suchanek <msuchanek@suse.de> Acked-by: Randy Dunlap <rdunlap@infradead.org> I was about to send the same patch. Thanks. > --- > drivers/soundwire/slave.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/soundwire/slave.c b/drivers/soundwire/slave.c > index f39a5815e25d..34c7e65831d1 100644 > --- a/drivers/soundwire/slave.c > +++ b/drivers/soundwire/slave.c > @@ -6,6 +6,7 @@ > #include <linux/soundwire/sdw_type.h> > #include "bus.h" > > +#if IS_ENABLED(CONFIG_ACPI) > static void sdw_slave_release(struct device *dev) > { > struct sdw_slave *slave = dev_to_sdw_dev(dev); > @@ -60,7 +61,6 @@ static int sdw_slave_add(struct sdw_bus *bus, > return ret; > } > > -#if IS_ENABLED(CONFIG_ACPI) > /* > * sdw_acpi_find_slaves() - Find Slave devices in Master ACPI node > * @bus: SDW bus instance > -- ~Randy _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-08-30 18:56 UTC|newest] Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-30 18:52 [PATCH] soundwire: slave: Fix unused function warning on !ACPI Michal Suchanek 2019-08-30 18:52 ` [alsa-devel] " Michal Suchanek 2019-08-30 18:56 ` Randy Dunlap [this message] 2019-08-30 18:56 ` Randy Dunlap 2019-09-04 9:30 ` Vinod Koul 2019-09-04 9:30 ` [alsa-devel] " Vinod Koul 2019-09-04 10:48 ` Michal Suchánek 2019-09-04 10:48 ` [alsa-devel] " Michal Suchánek 2019-09-04 11:40 ` Vinod Koul 2019-09-04 11:40 ` [alsa-devel] " Vinod Koul 2019-10-02 8:20 ` Michal Suchánek 2019-10-02 8:20 ` [alsa-devel] " Michal Suchánek 2019-10-02 8:33 ` [PATCH 1/2] soundwire: depend on ACPI Michal Suchanek 2019-10-02 8:33 ` [alsa-devel] " Michal Suchanek 2019-10-02 8:36 ` Greg KH 2019-10-02 8:36 ` [alsa-devel] " Greg KH 2019-10-02 8:33 ` [PATCH 2/2] soundwire: depend on ACPI || OF Michal Suchanek 2019-10-02 8:33 ` [alsa-devel] " Michal Suchanek 2019-10-02 8:36 ` Greg KH 2019-10-02 8:36 ` [alsa-devel] " Greg KH 2019-10-02 16:06 ` Pierre-Louis Bossart 2019-10-02 16:06 ` Pierre-Louis Bossart 2019-10-03 10:15 ` Michal Suchánek 2019-10-03 10:15 ` Michal Suchánek 2019-10-03 10:13 ` [PATCH v2 1/2] soundwire: depend on ACPI Michal Suchanek 2019-10-03 10:13 ` [alsa-devel] " Michal Suchanek 2019-10-06 12:07 ` Sasha Levin 2019-10-15 10:45 ` Vinod Koul 2019-10-15 10:45 ` [alsa-devel] " Vinod Koul 2019-10-03 10:13 ` [PATCH v2 2/2] soundwire: depend on ACPI || OF Michal Suchanek 2019-10-03 10:13 ` [alsa-devel] " Michal Suchanek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f8c58d45-e641-5071-33bf-2927a61cb419@infradead.org \ --to=rdunlap@infradead.org \ --cc=alsa-devel@alsa-project.org \ --cc=linux-kernel@vger.kernel.org \ --cc=msuchanek@suse.de \ --cc=pierre-louis.bossart@linux.intel.com \ --cc=sanyog.r.kale@intel.com \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.