From: Chanwoo Choi <cw00.choi@samsung.com>
To: Dmitry Osipenko <digetx@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Georgi Djakov <georgi.djakov@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Mikko Perttunen <cyndis@kapsi.fi>,
Viresh Kumar <vireshk@kernel.org>,
Peter Geis <pgwipeout@gmail.com>,
Nicolas Chauvet <kwizart@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v10 09/19] PM / devfreq: tegra30: Support interconnect and OPPs from device-tree
Date: Mon, 23 Nov 2020 16:02:17 +0900 [thread overview]
Message-ID: <f8f0b254-b5d6-7951-7576-846d8f58cb13@samsung.com> (raw)
In-Reply-To: <20201123002723.28463-10-digetx@gmail.com>
Hi Dmitry,
On 11/23/20 9:27 AM, Dmitry Osipenko wrote:
> This patch moves ACTMON driver away from generating OPP table by itself,
> transitioning it to use the table which comes from device-tree. This
> change breaks compatibility with older device-trees and brings support
> for the interconnect framework to the driver. This is a mandatory change
> which needs to be done in order to implement interconnect-based memory
> DVFS, i.e. device-trees need to be updated. Now ACTMON issues a memory
> bandwidth requests using dev_pm_opp_set_bw() instead of driving EMC clock
> rate directly.
>
> Tested-by: Peter Geis <pgwipeout@gmail.com>
> Tested-by: Nicolas Chauvet <kwizart@gmail.com>
> Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> drivers/devfreq/tegra30-devfreq.c | 79 +++++++++++++++----------------
> 1 file changed, 37 insertions(+), 42 deletions(-)
>
(snip)
When the patches related to icc are merged, I'll merge patch9/10.
Thanks for your work.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
WARNING: multiple messages have this Message-ID (diff)
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Dmitry Osipenko <digetx@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Georgi Djakov <georgi.djakov@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Peter De Schrijver <pdeschrijver@nvidia.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Mikko Perttunen <cyndis@kapsi.fi>,
Viresh Kumar <vireshk@kernel.org>,
Peter Geis <pgwipeout@gmail.com>,
Nicolas Chauvet <kwizart@gmail.com>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v10 09/19] PM / devfreq: tegra30: Support interconnect and OPPs from device-tree
Date: Mon, 23 Nov 2020 16:02:17 +0900 [thread overview]
Message-ID: <f8f0b254-b5d6-7951-7576-846d8f58cb13@samsung.com> (raw)
In-Reply-To: <20201123002723.28463-10-digetx@gmail.com>
Hi Dmitry,
On 11/23/20 9:27 AM, Dmitry Osipenko wrote:
> This patch moves ACTMON driver away from generating OPP table by itself,
> transitioning it to use the table which comes from device-tree. This
> change breaks compatibility with older device-trees and brings support
> for the interconnect framework to the driver. This is a mandatory change
> which needs to be done in order to implement interconnect-based memory
> DVFS, i.e. device-trees need to be updated. Now ACTMON issues a memory
> bandwidth requests using dev_pm_opp_set_bw() instead of driving EMC clock
> rate directly.
>
> Tested-by: Peter Geis <pgwipeout@gmail.com>
> Tested-by: Nicolas Chauvet <kwizart@gmail.com>
> Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
> drivers/devfreq/tegra30-devfreq.c | 79 +++++++++++++++----------------
> 1 file changed, 37 insertions(+), 42 deletions(-)
>
(snip)
When the patches related to icc are merged, I'll merge patch9/10.
Thanks for your work.
--
Best Regards,
Chanwoo Choi
Samsung Electronics
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-11-23 6:48 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201123003254epcas1p1763e1ce693d7cb8e2f20d521e701ad5f@epcas1p1.samsung.com>
2020-11-23 0:27 ` [PATCH v10 00/19] Introduce memory interconnect for NVIDIA Tegra SoCs Dmitry Osipenko
2020-11-23 0:27 ` Dmitry Osipenko
2020-11-23 0:27 ` [PATCH v10 01/19] dt-bindings: memory: tegra20: emc: Document opp-supported-hw property Dmitry Osipenko
2020-11-23 0:27 ` Dmitry Osipenko
2020-11-30 9:48 ` Georgi Djakov
2020-11-30 9:48 ` Georgi Djakov
2020-11-30 18:23 ` Krzysztof Kozlowski
2020-11-30 18:23 ` Krzysztof Kozlowski
2020-11-30 20:03 ` Dmitry Osipenko
2020-11-30 20:03 ` Dmitry Osipenko
2020-11-23 0:27 ` [PATCH v10 02/19] memory: tegra20: Support hardware versioning and clean up OPP table initialization Dmitry Osipenko
2020-11-23 0:27 ` Dmitry Osipenko
2020-11-23 0:27 ` [PATCH v10 03/19] memory: tegra30: Support interconnect framework Dmitry Osipenko
2020-11-23 0:27 ` Dmitry Osipenko
2020-11-23 6:32 ` Georgi Djakov
2020-11-23 6:32 ` Georgi Djakov
2020-11-23 12:14 ` Dmitry Osipenko
2020-11-23 12:14 ` Dmitry Osipenko
2020-11-23 0:27 ` [PATCH v10 04/19] memory: tegra124-emc: Make driver modular Dmitry Osipenko
2020-11-23 0:27 ` Dmitry Osipenko
2020-11-23 0:27 ` [PATCH v10 05/19] memory: tegra124-emc: Continue probing if timings are missing in device-tree Dmitry Osipenko
2020-11-23 0:27 ` Dmitry Osipenko
2020-11-23 0:27 ` [PATCH v10 06/19] memory: tegra124: Support interconnect framework Dmitry Osipenko
2020-11-23 0:27 ` Dmitry Osipenko
2020-11-23 6:33 ` Georgi Djakov
2020-11-23 6:33 ` Georgi Djakov
2020-11-23 0:27 ` [PATCH v10 07/19] drm/tegra: dc: Support memory bandwidth management Dmitry Osipenko
2020-11-23 0:27 ` Dmitry Osipenko
2020-11-23 0:27 ` [PATCH v10 08/19] drm/tegra: dc: Extend debug stats with total number of events Dmitry Osipenko
2020-11-23 0:27 ` Dmitry Osipenko
2020-11-23 0:27 ` [PATCH v10 09/19] PM / devfreq: tegra30: Support interconnect and OPPs from device-tree Dmitry Osipenko
2020-11-23 0:27 ` Dmitry Osipenko
2020-11-23 7:02 ` Chanwoo Choi [this message]
2020-11-23 7:02 ` Chanwoo Choi
2020-11-23 12:14 ` Dmitry Osipenko
2020-11-23 12:14 ` Dmitry Osipenko
2020-11-23 0:27 ` [PATCH v10 10/19] PM / devfreq: tegra30: Separate configurations per-SoC generation Dmitry Osipenko
2020-11-23 0:27 ` Dmitry Osipenko
2020-11-23 0:27 ` [PATCH v10 11/19] PM / devfreq: tegra20: Deprecate in a favor of emc-stat based driver Dmitry Osipenko
2020-11-23 0:27 ` Dmitry Osipenko
2020-11-23 7:02 ` Chanwoo Choi
2020-11-23 7:02 ` Chanwoo Choi
2020-11-23 0:27 ` [PATCH v10 12/19] ARM: tegra: Correct EMC registers size in Tegra20 device-tree Dmitry Osipenko
2020-11-23 0:27 ` Dmitry Osipenko
2020-11-23 0:27 ` [PATCH v10 13/19] ARM: tegra: Add interconnect properties to " Dmitry Osipenko
2020-11-23 0:27 ` Dmitry Osipenko
2020-11-23 0:27 ` [PATCH v10 14/19] ARM: tegra: Add interconnect properties to Tegra30 device-tree Dmitry Osipenko
2020-11-23 0:27 ` Dmitry Osipenko
2020-11-23 0:27 ` [PATCH v10 15/19] ARM: tegra: Add interconnect properties to Tegra124 device-tree Dmitry Osipenko
2020-11-23 0:27 ` Dmitry Osipenko
2020-11-23 0:27 ` [PATCH v10 16/19] ARM: tegra: Add nvidia,memory-controller phandle to Tegra20 EMC device-tree Dmitry Osipenko
2020-11-23 0:27 ` [PATCH v10 16/19] ARM: tegra: Add nvidia, memory-controller " Dmitry Osipenko
2020-11-23 0:27 ` [PATCH v10 17/19] ARM: tegra: Add EMC OPP properties to Tegra20 device-trees Dmitry Osipenko
2020-11-23 0:27 ` Dmitry Osipenko
2020-11-30 21:17 ` Jon Hunter
2020-11-30 21:17 ` Jon Hunter
2020-11-30 22:57 ` Dmitry Osipenko
2020-11-30 22:57 ` Dmitry Osipenko
2020-12-01 20:42 ` Jon Hunter
2020-12-01 20:42 ` Jon Hunter
2020-12-04 15:54 ` Thierry Reding
2020-12-04 15:54 ` Thierry Reding
2020-12-05 13:52 ` Krzysztof Kozlowski
2020-12-05 13:52 ` Krzysztof Kozlowski
2020-11-23 0:27 ` [PATCH v10 18/19] ARM: tegra: Add EMC OPP and ICC properties to Tegra30 EMC and ACTMON device-tree nodes Dmitry Osipenko
2020-11-23 0:27 ` Dmitry Osipenko
2020-11-23 0:27 ` [PATCH v10 19/19] ARM: tegra: Add EMC OPP and ICC properties to Tegra124 " Dmitry Osipenko
2020-11-23 0:27 ` Dmitry Osipenko
2020-11-23 6:17 ` [PATCH v10 00/19] Introduce memory interconnect for NVIDIA Tegra SoCs Viresh Kumar
2020-11-23 6:17 ` Viresh Kumar
2020-11-23 12:13 ` Dmitry Osipenko
2020-11-23 12:13 ` Dmitry Osipenko
2020-11-30 8:44 ` Chanwoo Choi
2020-11-30 8:44 ` Chanwoo Choi
2020-11-30 8:36 ` Krzysztof Kozlowski
2020-11-30 8:36 ` Krzysztof Kozlowski
2020-11-30 8:59 ` Chanwoo Choi
2020-11-30 8:59 ` Chanwoo Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f8f0b254-b5d6-7951-7576-846d8f58cb13@samsung.com \
--to=cw00.choi@samsung.com \
--cc=cyndis@kapsi.fi \
--cc=digetx@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=georgi.djakov@linaro.org \
--cc=jonathanh@nvidia.com \
--cc=krzk@kernel.org \
--cc=kwizart@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=myungjoo.ham@samsung.com \
--cc=pdeschrijver@nvidia.com \
--cc=pgwipeout@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.