Re: [PATCH 4/4] soc: qcom: pdr: Make QMI message rules const

From: Sibi Sankar <quic_sibis@quicinc.com>
To: Jeff Johnson <quic_jjohnson@quicinc.com>,
	Alex Elder <elder@kernel.org>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	"Mathieu Poirier" <mathieu.poirier@linaro.org>,
	Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
	Kalle Valo <kvalo@kernel.org>, Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	"Konrad Dybcio" <konrad.dybcio@somainline.org>
Cc: <linux-arm-msm@vger.kernel.org>, <netdev@vger.kernel.org>,
	<linux-remoteproc@vger.kernel.org>, <alsa-devel@alsa-project.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 4/4] soc: qcom: pdr: Make QMI message rules const
Date: Wed, 14 Sep 2022 15:48:43 +0530	[thread overview]
Message-ID: <f8f43b22-bb13-71ff-15fc-a323d0b56ead@quicinc.com> (raw)
In-Reply-To: <20220912232526.27427-5-quic_jjohnson@quicinc.com>


On 9/13/22 4:55 AM, Jeff Johnson wrote:
> Commit ff6d365898d ("soc: qcom: qmi: use const for struct
> qmi_elem_info") allows QMI message encoding/decoding rules to be
> const, so do that for QCOM PDR.
> 
> Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com>

Reviewed-by: Sibi Sankar <quic_sibis@quicinc.com>

> ---
>   drivers/soc/qcom/pdr_internal.h | 20 ++++++++++----------
>   1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/drivers/soc/qcom/pdr_internal.h b/drivers/soc/qcom/pdr_internal.h
> index a30422214943..03c282b7f17e 100644
> --- a/drivers/soc/qcom/pdr_internal.h
> +++ b/drivers/soc/qcom/pdr_internal.h
> @@ -28,7 +28,7 @@ struct servreg_location_entry {
>   	u32 instance;
>   };
>   
> -static struct qmi_elem_info servreg_location_entry_ei[] = {
> +static const struct qmi_elem_info servreg_location_entry_ei[] = {
>   	{
>   		.data_type      = QMI_STRING,
>   		.elem_len       = SERVREG_NAME_LENGTH + 1,
> @@ -74,7 +74,7 @@ struct servreg_get_domain_list_req {
>   	u32 domain_offset;
>   };
>   
> -static struct qmi_elem_info servreg_get_domain_list_req_ei[] = {
> +static const struct qmi_elem_info servreg_get_domain_list_req_ei[] = {
>   	{
>   		.data_type      = QMI_STRING,
>   		.elem_len       = SERVREG_NAME_LENGTH + 1,
> @@ -116,7 +116,7 @@ struct servreg_get_domain_list_resp {
>   	struct servreg_location_entry domain_list[SERVREG_DOMAIN_LIST_LENGTH];
>   };
>   
> -static struct qmi_elem_info servreg_get_domain_list_resp_ei[] = {
> +static const struct qmi_elem_info servreg_get_domain_list_resp_ei[] = {
>   	{
>   		.data_type      = QMI_STRUCT,
>   		.elem_len       = 1,
> @@ -199,7 +199,7 @@ struct servreg_register_listener_req {
>   	char service_path[SERVREG_NAME_LENGTH + 1];
>   };
>   
> -static struct qmi_elem_info servreg_register_listener_req_ei[] = {
> +static const struct qmi_elem_info servreg_register_listener_req_ei[] = {
>   	{
>   		.data_type      = QMI_UNSIGNED_1_BYTE,
>   		.elem_len       = 1,
> @@ -227,7 +227,7 @@ struct servreg_register_listener_resp {
>   	enum servreg_service_state curr_state;
>   };
>   
> -static struct qmi_elem_info servreg_register_listener_resp_ei[] = {
> +static const struct qmi_elem_info servreg_register_listener_resp_ei[] = {
>   	{
>   		.data_type      = QMI_STRUCT,
>   		.elem_len       = 1,
> @@ -263,7 +263,7 @@ struct servreg_restart_pd_req {
>   	char service_path[SERVREG_NAME_LENGTH + 1];
>   };
>   
> -static struct qmi_elem_info servreg_restart_pd_req_ei[] = {
> +static const struct qmi_elem_info servreg_restart_pd_req_ei[] = {
>   	{
>   		.data_type      = QMI_STRING,
>   		.elem_len       = SERVREG_NAME_LENGTH + 1,
> @@ -280,7 +280,7 @@ struct servreg_restart_pd_resp {
>   	struct qmi_response_type_v01 resp;
>   };
>   
> -static struct qmi_elem_info servreg_restart_pd_resp_ei[] = {
> +static const struct qmi_elem_info servreg_restart_pd_resp_ei[] = {
>   	{
>   		.data_type      = QMI_STRUCT,
>   		.elem_len       = 1,
> @@ -300,7 +300,7 @@ struct servreg_state_updated_ind {
>   	u16 transaction_id;
>   };
>   
> -static struct qmi_elem_info servreg_state_updated_ind_ei[] = {
> +static const struct qmi_elem_info servreg_state_updated_ind_ei[] = {
>   	{
>   		.data_type      = QMI_SIGNED_4_BYTE_ENUM,
>   		.elem_len       = 1,
> @@ -336,7 +336,7 @@ struct servreg_set_ack_req {
>   	u16 transaction_id;
>   };
>   
> -static struct qmi_elem_info servreg_set_ack_req_ei[] = {
> +static const struct qmi_elem_info servreg_set_ack_req_ei[] = {
>   	{
>   		.data_type      = QMI_STRING,
>   		.elem_len       = SERVREG_NAME_LENGTH + 1,
> @@ -362,7 +362,7 @@ struct servreg_set_ack_resp {
>   	struct qmi_response_type_v01 resp;
>   };
>   
> -static struct qmi_elem_info servreg_set_ack_resp_ei[] = {
> +static const struct qmi_elem_info servreg_set_ack_resp_ei[] = {
>   	{
>   		.data_type      = QMI_STRUCT,
>   		.elem_len       = 1,
>