From: Johannes Berg <johannes@sipsolutions.net> To: Rajkumar Manoharan <rmanohar@codeaurora.org>, kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org Subject: Re: [PATCH v3 06/11] mac80211: handle HE 6 GHz Capability in HE STA processing Date: Thu, 28 May 2020 10:55:09 +0200 [thread overview] Message-ID: <f9a764eaf9f0898c257b6c98346536c2c0f5d6f8.camel@sipsolutions.net> (raw) In-Reply-To: <1589399105-25472-6-git-send-email-rmanohar@codeaurora.org> > +++ b/include/net/cfg80211.h > @@ -332,15 +332,25 @@ struct ieee80211_sta_vht_cap { > * to describe 802.11ax HE capabilities for a STA. > * > * @has_he: true iff HE data is valid. > + * @has_he_6ghz: true iff HE 6 GHz data is valid. > * @he_cap_elem: Fixed portion of the HE capabilities element. > * @he_mcs_nss_supp: The supported NSS/MCS combinations. > * @ppe_thres: Holds the PPE Thresholds data. > + * @ampdu_factor: Maximum A-MPDU length factor used in 6 GHz. > + * @ampdu_density: Minimum A-MPDU spacing used in 6 GHz. > + * @cap: HE 6 GHz Band capability. > */ > struct ieee80211_sta_he_cap { > bool has_he; > + bool has_he_6ghz; > struct ieee80211_he_cap_elem he_cap_elem; > struct ieee80211_he_mcs_nss_supp he_mcs_nss_supp; > u8 ppe_thres[IEEE80211_HE_PPE_THRES_MAX_LEN]; > + struct { > + u8 ampdu_factor; > + u8 ampdu_density; > + u16 cap; > + } he_6ghz; > }; So ... I'm a bit unsure about this now. What I had done was this (well, I adjusted it slightly now): https://p.sipsolutions.net/2d0eb7c7e23a1b92.txt But it's only half related? Maybe you're also using that for the associated stations, not just for "self"? But then again, you *already* added @@ -1270,6 +1271,7 @@ struct station_parameters { u8 he_capa_len; u16 airtime_weight; struct sta_txpwr txpwr; + const struct ieee80211_he_6ghz_capa *he_6ghz_capa; }; right? But no ... that's different. We still have a need to store the station's capabilities. But even then, > + struct { > + u8 ampdu_factor; > + u8 ampdu_density; > + u16 cap; > + } he_6ghz; doesn't really make sense, does it? "cap' already includes the ampdu_factor and ampdu_density flags, so that's doubled... I think I would prefer to have this separate. We need it as I put into my patch that I linked to above, and we also need it in the station in mac80211 for AP, but we don't really need it for cfg80211 as you put it here. I'll continue with my other patches, and then maybe see how this fits in later. johannes
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net> To: Rajkumar Manoharan <rmanohar@codeaurora.org>, kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org, ath11k@lists.infradead.org Subject: Re: [PATCH v3 06/11] mac80211: handle HE 6 GHz Capability in HE STA processing Date: Thu, 28 May 2020 10:55:09 +0200 [thread overview] Message-ID: <f9a764eaf9f0898c257b6c98346536c2c0f5d6f8.camel@sipsolutions.net> (raw) In-Reply-To: <1589399105-25472-6-git-send-email-rmanohar@codeaurora.org> > +++ b/include/net/cfg80211.h > @@ -332,15 +332,25 @@ struct ieee80211_sta_vht_cap { > * to describe 802.11ax HE capabilities for a STA. > * > * @has_he: true iff HE data is valid. > + * @has_he_6ghz: true iff HE 6 GHz data is valid. > * @he_cap_elem: Fixed portion of the HE capabilities element. > * @he_mcs_nss_supp: The supported NSS/MCS combinations. > * @ppe_thres: Holds the PPE Thresholds data. > + * @ampdu_factor: Maximum A-MPDU length factor used in 6 GHz. > + * @ampdu_density: Minimum A-MPDU spacing used in 6 GHz. > + * @cap: HE 6 GHz Band capability. > */ > struct ieee80211_sta_he_cap { > bool has_he; > + bool has_he_6ghz; > struct ieee80211_he_cap_elem he_cap_elem; > struct ieee80211_he_mcs_nss_supp he_mcs_nss_supp; > u8 ppe_thres[IEEE80211_HE_PPE_THRES_MAX_LEN]; > + struct { > + u8 ampdu_factor; > + u8 ampdu_density; > + u16 cap; > + } he_6ghz; > }; So ... I'm a bit unsure about this now. What I had done was this (well, I adjusted it slightly now): https://p.sipsolutions.net/2d0eb7c7e23a1b92.txt But it's only half related? Maybe you're also using that for the associated stations, not just for "self"? But then again, you *already* added @@ -1270,6 +1271,7 @@ struct station_parameters { u8 he_capa_len; u16 airtime_weight; struct sta_txpwr txpwr; + const struct ieee80211_he_6ghz_capa *he_6ghz_capa; }; right? But no ... that's different. We still have a need to store the station's capabilities. But even then, > + struct { > + u8 ampdu_factor; > + u8 ampdu_density; > + u16 cap; > + } he_6ghz; doesn't really make sense, does it? "cap' already includes the ampdu_factor and ampdu_density flags, so that's doubled... I think I would prefer to have this separate. We need it as I put into my patch that I linked to above, and we also need it in the station in mac80211 for AP, but we don't really need it for cfg80211 as you put it here. I'll continue with my other patches, and then maybe see how this fits in later. johannes _______________________________________________ ath11k mailing list ath11k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath11k
next prev parent reply other threads:[~2020-05-28 8:55 UTC|newest] Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-13 19:44 [PATCH v3 01/11] cfg80211: use only HE capability to set prohibited flags in 6 GHz Rajkumar Manoharan 2020-05-13 19:44 ` Rajkumar Manoharan 2020-05-13 19:44 ` [PATCH v3 02/11] cfg80211: handle 6 GHz capability of new station Rajkumar Manoharan 2020-05-13 19:44 ` Rajkumar Manoharan 2020-05-27 14:00 ` Johannes Berg 2020-05-27 14:00 ` Johannes Berg 2020-05-27 23:24 ` Rajkumar Manoharan 2020-05-27 23:24 ` Rajkumar Manoharan 2020-05-28 7:40 ` Johannes Berg 2020-05-28 7:40 ` Johannes Berg 2020-05-13 19:44 ` [PATCH v3 03/11] nl80211: add HE 6 GHz Band Capability support Rajkumar Manoharan 2020-05-13 19:44 ` Rajkumar Manoharan 2020-05-27 14:27 ` Johannes Berg 2020-05-27 14:27 ` Johannes Berg 2020-05-27 17:39 ` Rajkumar Manoharan 2020-05-27 17:39 ` Rajkumar Manoharan 2020-05-13 19:44 ` [PATCH v3 04/11] mac80211: add HE 6 GHz Band Capabilities into parse extension Rajkumar Manoharan 2020-05-13 19:44 ` Rajkumar Manoharan 2020-05-27 14:28 ` Johannes Berg 2020-05-27 14:28 ` Johannes Berg 2020-05-13 19:44 ` [PATCH v3 05/11] mac80211: fix memory overlap due to variable length param Rajkumar Manoharan 2020-05-13 19:44 ` Rajkumar Manoharan 2020-05-27 14:28 ` Johannes Berg 2020-05-27 14:28 ` Johannes Berg 2020-05-13 19:45 ` [PATCH v3 06/11] mac80211: handle HE 6 GHz Capability in HE STA processing Rajkumar Manoharan 2020-05-13 19:45 ` Rajkumar Manoharan 2020-05-27 14:43 ` Johannes Berg 2020-05-27 14:43 ` Johannes Berg 2020-05-28 8:55 ` Johannes Berg [this message] 2020-05-28 8:55 ` Johannes Berg 2020-05-28 9:43 ` Johannes Berg 2020-05-28 9:43 ` Johannes Berg 2020-05-28 13:15 ` Johannes Berg 2020-05-28 13:15 ` Johannes Berg 2020-05-13 19:45 ` [PATCH v3 07/11] mac80211: add HE 6 GHz Band Capability IE in Assoc. Request Rajkumar Manoharan 2020-05-13 19:45 ` Rajkumar Manoharan 2020-05-27 14:37 ` Johannes Berg 2020-05-27 14:37 ` Johannes Berg 2020-05-28 12:20 ` Johannes Berg 2020-05-28 12:20 ` Johannes Berg 2020-05-13 19:45 ` [PATCH v3 08/11] mac80211: build HE operation with 6 GHz oper information Rajkumar Manoharan 2020-05-13 19:45 ` Rajkumar Manoharan 2020-05-27 14:30 ` Johannes Berg 2020-05-27 14:30 ` Johannes Berg 2020-05-13 19:45 ` [PATCH v3 09/11] mac80211: do not allow HT/VHT IEs in 6 GHz mesh mode Rajkumar Manoharan 2020-05-13 19:45 ` Rajkumar Manoharan 2020-05-13 19:45 ` [PATCH v3 10/11] mac80211: determine chantype from HE operation in 6 GHz Rajkumar Manoharan 2020-05-13 19:45 ` Rajkumar Manoharan 2020-05-27 14:41 ` Johannes Berg 2020-05-27 14:41 ` Johannes Berg 2020-05-27 14:44 ` Johannes Berg 2020-05-27 14:44 ` Johannes Berg 2020-05-27 18:34 ` Rajkumar Manoharan 2020-05-27 18:34 ` Rajkumar Manoharan 2020-05-27 18:41 ` Johannes Berg 2020-05-27 18:41 ` Johannes Berg 2020-05-28 9:41 ` Johannes Berg 2020-05-28 9:41 ` Johannes Berg 2020-05-28 11:46 ` Johannes Berg 2020-05-28 11:46 ` Johannes Berg 2020-05-13 19:45 ` [PATCH v3 11/11] ath11k: build HE 6 GHz capability Rajkumar Manoharan 2020-05-13 19:45 ` Rajkumar Manoharan 2020-06-01 22:42 ` Rajkumar Manoharan 2020-06-01 22:42 ` Rajkumar Manoharan 2020-05-27 13:43 ` [PATCH v3 01/11] cfg80211: use only HE capability to set prohibited flags in 6 GHz Johannes Berg 2020-05-27 13:43 ` Johannes Berg 2020-05-27 23:32 ` Rajkumar Manoharan 2020-05-27 23:32 ` Rajkumar Manoharan 2020-05-28 7:41 ` Johannes Berg 2020-05-28 7:41 ` Johannes Berg 2020-05-28 7:42 ` Johannes Berg 2020-05-28 7:42 ` Johannes Berg -- strict thread matches above, loose matches on Subject: below -- 2020-05-09 0:12 Rajkumar Manoharan 2020-05-09 0:13 ` [PATCH v3 06/11] mac80211: handle HE 6 GHz Capability in HE STA processing Rajkumar Manoharan 2020-05-09 0:13 ` Rajkumar Manoharan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f9a764eaf9f0898c257b6c98346536c2c0f5d6f8.camel@sipsolutions.net \ --to=johannes@sipsolutions.net \ --cc=ath11k@lists.infradead.org \ --cc=kvalo@codeaurora.org \ --cc=linux-wireless@vger.kernel.org \ --cc=rmanohar@codeaurora.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.