From: Paolo Bonzini <pbonzini@redhat.com>
To: Alexey Kardashevskiy <aik@ozlabs.ru>,
Yongji Xie <xyjxie@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org, alex.williamson@redhat.com,
zhong@linux.vnet.ibm.com,
Peter Maydell <peter.maydell@linaro.org>,
David Gibson <david@gibson.dropbear.id.au>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [Qemu-devel] [PATCH] memory: make ram device read/write endian sensitive
Date: Thu, 23 Feb 2017 09:35:59 +0100 [thread overview]
Message-ID: <fdcb2b07-aae8-69bf-ee94-a43777009c3a@redhat.com> (raw)
In-Reply-To: <5edff645-12e8-d3e0-1849-302b6986c232@ozlabs.ru>
On 23/02/2017 05:20, Alexey Kardashevskiy wrote:
> First, Paolo is right and ram_device_mem_ops::endianness should be
> host-endian which happens to be little in our test case (ppc64le)
So you tested a ppc64 BE guest and it works?
> Keep things where they are in the VFIO department and just fix
> ram_device_mem_ops::endianness?
I would fix the ram_device_mem_ops. Either by introducing
DEVICE_HOST_ENDIAN(*) or with Yongji's patch.
(*) DEVICE_NATIVE_ENDIAN is special cased all over the place
because the same device (in a file that's compiled just once)
can be either little- or big-endian. DEVICE_HOST_ENDIAN can
be a simple #define to either DEVICE_LITTLE_ENDIAN or
DEVICE_BIG_ENDIAN, because host endianness is the same for
all QEMU binaries. It's literally half a dozen lines of code.
Paolo
next prev parent reply other threads:[~2017-02-23 8:36 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 6:46 [Qemu-devel] [PATCH] memory: make ram device read/write endian sensitive Yongji Xie
2017-02-21 16:21 ` Alex Williamson
2017-02-21 16:34 ` Paolo Bonzini
2017-02-21 18:09 ` Peter Maydell
2017-02-21 18:44 ` Alex Williamson
2017-02-22 7:54 ` Yongji Xie
2017-02-22 10:53 ` Paolo Bonzini
2017-02-21 18:53 ` Paolo Bonzini
2017-02-21 19:40 ` Peter Maydell
2017-02-23 4:20 ` Alexey Kardashevskiy
2017-02-23 8:35 ` Paolo Bonzini [this message]
2017-02-23 10:02 ` Peter Maydell
2017-02-23 10:10 ` Paolo Bonzini
2017-02-23 10:23 ` Peter Maydell
2017-02-23 10:33 ` Paolo Bonzini
2017-02-23 11:34 ` Peter Maydell
2017-02-23 11:43 ` Paolo Bonzini
2017-02-23 12:26 ` Peter Maydell
2017-02-23 12:53 ` Paolo Bonzini
2017-02-23 14:35 ` Peter Maydell
2017-02-23 15:21 ` Paolo Bonzini
2017-02-23 15:29 ` Peter Maydell
2017-02-23 15:58 ` Paolo Bonzini
2017-02-23 16:08 ` Peter Maydell
2017-02-23 16:15 ` Paolo Bonzini
2017-02-23 17:14 ` Yongji Xie
2017-02-24 3:28 ` David Gibson
2017-02-23 23:36 ` Paul Mackerras
2017-02-23 15:39 ` Alex Williamson
2017-02-23 15:47 ` Paolo Bonzini
2017-02-23 16:08 ` Alex Williamson
2017-02-24 3:26 ` David Gibson
2017-02-23 11:04 ` Alexey Kardashevskiy
2017-02-27 2:25 ` Michael Roth
2017-02-27 3:25 ` Alexey Kardashevskiy
2017-02-27 4:28 ` Yongji Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fdcb2b07-aae8-69bf-ee94-a43777009c3a@redhat.com \
--to=pbonzini@redhat.com \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=paulus@samba.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=xyjxie@linux.vnet.ibm.com \
--cc=zhong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.