* [PATCH] mt76x0: phy: fix restore phase in mt76x0_phy_recalibrate_after_assoc
[not found] <cover.1539001391.git.lorenzo.bianconi@redhat.com>
@ 2018-10-08 12:40 ` Lorenzo Bianconi
2018-10-08 18:11 ` Felix Fietkau
0 siblings, 1 reply; 6+ messages in thread
From: Lorenzo Bianconi @ 2018-10-08 12:40 UTC (permalink / raw)
To: nbd; +Cc: sgruszka, linux-wireless
Fix restore value configured in 0x2124 register in
mt76x0_phy_recalibrate_after_assoc routine.
Fixes: 10de7a8b4ab9 ("mt76x0: phy files")
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
---
drivers/net/wireless/mediatek/mt76/mt76x0/phy.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
index 99e0a91a2f99..d18942e54048 100644
--- a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
+++ b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
@@ -734,8 +734,7 @@ void mt76x0_phy_recalibrate_after_assoc(struct mt76x02_dev *dev)
usleep_range(500, 700);
reg_val = mt76_rr(dev, 0x2124);
- reg_val &= 0xffffff7e;
- mt76_wr(dev, 0x2124, reg_val);
+ mt76_wr(dev, 0x2124, 0xffffff7e);
mt76x02_mcu_calibrate(dev, MCU_CAL_RXDCOC, 0, false);
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mt76x0: phy: fix restore phase in mt76x0_phy_recalibrate_after_assoc
2018-10-08 12:40 ` [PATCH] mt76x0: phy: fix restore phase in mt76x0_phy_recalibrate_after_assoc Lorenzo Bianconi
@ 2018-10-08 18:11 ` Felix Fietkau
2018-10-08 19:55 ` Lorenzo Bianconi
2018-10-09 7:35 ` Stanislaw Gruszka
0 siblings, 2 replies; 6+ messages in thread
From: Felix Fietkau @ 2018-10-08 18:11 UTC (permalink / raw)
To: Lorenzo Bianconi; +Cc: sgruszka, linux-wireless
On 2018-10-08 14:40, Lorenzo Bianconi wrote:
> Fix restore value configured in 0x2124 register in
> mt76x0_phy_recalibrate_after_assoc routine.
>
> Fixes: 10de7a8b4ab9 ("mt76x0: phy files")
> Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> ---
> drivers/net/wireless/mediatek/mt76/mt76x0/phy.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
> index 99e0a91a2f99..d18942e54048 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
> @@ -734,8 +734,7 @@ void mt76x0_phy_recalibrate_after_assoc(struct mt76x02_dev *dev)
> usleep_range(500, 700);
>
> reg_val = mt76_rr(dev, 0x2124);
> - reg_val &= 0xffffff7e;
> - mt76_wr(dev, 0x2124, reg_val);
> + mt76_wr(dev, 0x2124, 0xffffff7e);
I'm pretty sure you can drop the mt76_rr as well. Also, you can refer to
0x2124 as MT_BBP(IBI, 9).
- Felix
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mt76x0: phy: fix restore phase in mt76x0_phy_recalibrate_after_assoc
2018-10-08 18:11 ` Felix Fietkau
@ 2018-10-08 19:55 ` Lorenzo Bianconi
2018-10-09 7:35 ` Stanislaw Gruszka
1 sibling, 0 replies; 6+ messages in thread
From: Lorenzo Bianconi @ 2018-10-08 19:55 UTC (permalink / raw)
To: Felix Fietkau; +Cc: Stanislaw Gruszka, linux-wireless
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
> > index 99e0a91a2f99..d18942e54048 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
> > +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
> > @@ -734,8 +734,7 @@ void mt76x0_phy_recalibrate_after_assoc(struct mt76x02_dev *dev)
> > usleep_range(500, 700);
> >
> > reg_val = mt76_rr(dev, 0x2124);
> > - reg_val &= 0xffffff7e;
> > - mt76_wr(dev, 0x2124, reg_val);
> > + mt76_wr(dev, 0x2124, 0xffffff7e);
> I'm pretty sure you can drop the mt76_rr as well. Also, you can refer to
> 0x2124 as MT_BBP(IBI, 9).
>
Do you mean we do not need to reset the original value in MT_BBP(IBI, 9)?
Regards,
Lorenzo
> - Felix
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mt76x0: phy: fix restore phase in mt76x0_phy_recalibrate_after_assoc
2018-10-08 18:11 ` Felix Fietkau
2018-10-08 19:55 ` Lorenzo Bianconi
@ 2018-10-09 7:35 ` Stanislaw Gruszka
2018-10-09 8:35 ` Felix Fietkau
1 sibling, 1 reply; 6+ messages in thread
From: Stanislaw Gruszka @ 2018-10-09 7:35 UTC (permalink / raw)
To: Felix Fietkau; +Cc: Lorenzo Bianconi, linux-wireless
On Mon, Oct 08, 2018 at 08:11:45PM +0200, Felix Fietkau wrote:
> On 2018-10-08 14:40, Lorenzo Bianconi wrote:
> > Fix restore value configured in 0x2124 register in
> > mt76x0_phy_recalibrate_after_assoc routine.
> >
> > Fixes: 10de7a8b4ab9 ("mt76x0: phy files")
> > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
> > ---
> > drivers/net/wireless/mediatek/mt76/mt76x0/phy.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
> > index 99e0a91a2f99..d18942e54048 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
> > +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
> > @@ -734,8 +734,7 @@ void mt76x0_phy_recalibrate_after_assoc(struct mt76x02_dev *dev)
> > usleep_range(500, 700);
> >
> > reg_val = mt76_rr(dev, 0x2124);
> > - reg_val &= 0xffffff7e;
> > - mt76_wr(dev, 0x2124, reg_val);
> > + mt76_wr(dev, 0x2124, 0xffffff7e);
> I'm pretty sure you can drop the mt76_rr as well. Also, you can refer to
> 0x2124 as MT_BBP(IBI, 9).
I think is needed we do:
reg_val = mt76_rr(dev, 0x2124);
mt76_wr(dev, 0x2124, 0xffffff7e);
CALIBRATE
mt76_wr(dev, 0x2124, reg_val);
so seems we have to restore orginal value after calibration.
Referencing as MT_BBP(IBI, 9) is obviously fine.
Thanks
Stanislaw
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mt76x0: phy: fix restore phase in mt76x0_phy_recalibrate_after_assoc
2018-10-09 7:35 ` Stanislaw Gruszka
@ 2018-10-09 8:35 ` Felix Fietkau
2018-10-09 8:48 ` Lorenzo Bianconi
0 siblings, 1 reply; 6+ messages in thread
From: Felix Fietkau @ 2018-10-09 8:35 UTC (permalink / raw)
To: Stanislaw Gruszka; +Cc: Lorenzo Bianconi, linux-wireless
On 2018-10-09 09:35, Stanislaw Gruszka wrote:
> On Mon, Oct 08, 2018 at 08:11:45PM +0200, Felix Fietkau wrote:
>> On 2018-10-08 14:40, Lorenzo Bianconi wrote:
>> > Fix restore value configured in 0x2124 register in
>> > mt76x0_phy_recalibrate_after_assoc routine.
>> >
>> > Fixes: 10de7a8b4ab9 ("mt76x0: phy files")
>> > Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
>> > ---
>> > drivers/net/wireless/mediatek/mt76/mt76x0/phy.c | 3 +--
>> > 1 file changed, 1 insertion(+), 2 deletions(-)
>> >
>> > diff --git a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
>> > index 99e0a91a2f99..d18942e54048 100644
>> > --- a/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
>> > +++ b/drivers/net/wireless/mediatek/mt76/mt76x0/phy.c
>> > @@ -734,8 +734,7 @@ void mt76x0_phy_recalibrate_after_assoc(struct mt76x02_dev *dev)
>> > usleep_range(500, 700);
>> >
>> > reg_val = mt76_rr(dev, 0x2124);
>> > - reg_val &= 0xffffff7e;
>> > - mt76_wr(dev, 0x2124, reg_val);
>> > + mt76_wr(dev, 0x2124, 0xffffff7e);
>> I'm pretty sure you can drop the mt76_rr as well. Also, you can refer to
>> 0x2124 as MT_BBP(IBI, 9).
>
> I think is needed we do:
>
> reg_val = mt76_rr(dev, 0x2124);
> mt76_wr(dev, 0x2124, 0xffffff7e);
>
> CALIBRATE
>
> mt76_wr(dev, 0x2124, reg_val);
>
> so seems we have to restore orginal value after calibration.
>
> Referencing as MT_BBP(IBI, 9) is obviously fine.
Yes, that makes more sense.
- Felix
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mt76x0: phy: fix restore phase in mt76x0_phy_recalibrate_after_assoc
2018-10-09 8:35 ` Felix Fietkau
@ 2018-10-09 8:48 ` Lorenzo Bianconi
0 siblings, 0 replies; 6+ messages in thread
From: Lorenzo Bianconi @ 2018-10-09 8:48 UTC (permalink / raw)
To: Felix Fietkau; +Cc: Stanislaw Gruszka, linux-wireless
> > I think is needed we do:
> >
> > reg_val = mt76_rr(dev, 0x2124);
> > mt76_wr(dev, 0x2124, 0xffffff7e);
> >
> > CALIBRATE
> >
> > mt76_wr(dev, 0x2124, reg_val);
> >
> > so seems we have to restore orginal value after calibration.
> >
> > Referencing as MT_BBP(IBI, 9) is obviously fine.
> Yes, that makes more sense.
>
> - Felix
Ack, I will send v2 with proper register name.
Regards,
Lorenzo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-10-09 8:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <cover.1539001391.git.lorenzo.bianconi@redhat.com>
2018-10-08 12:40 ` [PATCH] mt76x0: phy: fix restore phase in mt76x0_phy_recalibrate_after_assoc Lorenzo Bianconi
2018-10-08 18:11 ` Felix Fietkau
2018-10-08 19:55 ` Lorenzo Bianconi
2018-10-09 7:35 ` Stanislaw Gruszka
2018-10-09 8:35 ` Felix Fietkau
2018-10-09 8:48 ` Lorenzo Bianconi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.