All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@arm.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Stephen Boyd <swboyd@chromium.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Avaneesh Kumar Dwivedi <akdwived@codeaurora.org>
Subject: Re: [OSSTEST PATCH] ts-kernel-build: Disable CONFIG_ARCH_QCOM in Xen Project CI
Date: Fri, 31 May 2019 16:52:32 +0100	[thread overview]
Message-ID: <ffd5f689-085a-34f4-d150-5221783c0083@arm.com> (raw)
In-Reply-To: <20190530165123.22593-1-ian.jackson@eu.citrix.com>

Hi Ian,

On 30/05/2019 17:51, Ian Jackson wrote:
>    drivers/firmware/qcom_scm.c:469:47: error: passing argument 3 of `dma_alloc_coherent' from incompatible pointer type [-Werror=incompatible-pointer-types]
> 
> This is fixed by
> 
>    firmware: qcom_scm: Use proper types for dma mappings
> 
> but this is not present in all relevant stable branches.
> 
> We currently have no Qualcomm hardware in the Xen Project test lab so
> we do not need this enabled.
> 
> CC: Julien Grall <julien.grall@arm.com
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: linux-arm-msm@vger.kernel.org
> CC: linux-kernel@vger.kernel.org
> CC: Stephen Boyd <swboyd@chromium.org>
> CC: Andy Gross <agross@kernel.org>
> CC: Bjorn Andersson <bjorn.andersson@linaro.org>
> CC: Avaneesh Kumar Dwivedi <akdwived@codeaurora.org>
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

FWIW:

Acked-by: Julien Grall <julien.grall@arm.com>

> ---
>   ts-kernel-build | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/ts-kernel-build b/ts-kernel-build
> index f7d059b0..5536586f 100755
> --- a/ts-kernel-build
> +++ b/ts-kernel-build
> @@ -274,6 +274,10 @@ setopt CONFIG_MDIO_THUNDER=m
>   setopt CONFIG_I2C_THUNDERX=m
>   setopt CONFIG_SPI_THUNDERX=m
>   
> +# Some Linux branches we care about, including 4.19, still lack
> +# firmware: qcom_scm: Use proper types for dma mappings
> +CONFIG_ARCH_QCOM=n
> +
>   ####
>   
>   END
> 

-- 
Julien Grall

WARNING: multiple messages have this Message-ID (diff)
From: Julien Grall <julien.grall@arm.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xenproject.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Andy Gross <agross@kernel.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Avaneesh Kumar Dwivedi <akdwived@codeaurora.org>
Subject: Re: [Xen-devel] [OSSTEST PATCH] ts-kernel-build: Disable CONFIG_ARCH_QCOM in Xen Project CI
Date: Fri, 31 May 2019 16:52:32 +0100	[thread overview]
Message-ID: <ffd5f689-085a-34f4-d150-5221783c0083@arm.com> (raw)
In-Reply-To: <20190530165123.22593-1-ian.jackson@eu.citrix.com>

Hi Ian,

On 30/05/2019 17:51, Ian Jackson wrote:
>    drivers/firmware/qcom_scm.c:469:47: error: passing argument 3 of `dma_alloc_coherent' from incompatible pointer type [-Werror=incompatible-pointer-types]
> 
> This is fixed by
> 
>    firmware: qcom_scm: Use proper types for dma mappings
> 
> but this is not present in all relevant stable branches.
> 
> We currently have no Qualcomm hardware in the Xen Project test lab so
> we do not need this enabled.
> 
> CC: Julien Grall <julien.grall@arm.com
> CC: Stefano Stabellini <sstabellini@kernel.org>
> CC: linux-arm-msm@vger.kernel.org
> CC: linux-kernel@vger.kernel.org
> CC: Stephen Boyd <swboyd@chromium.org>
> CC: Andy Gross <agross@kernel.org>
> CC: Bjorn Andersson <bjorn.andersson@linaro.org>
> CC: Avaneesh Kumar Dwivedi <akdwived@codeaurora.org>
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

FWIW:

Acked-by: Julien Grall <julien.grall@arm.com>

> ---
>   ts-kernel-build | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/ts-kernel-build b/ts-kernel-build
> index f7d059b0..5536586f 100755
> --- a/ts-kernel-build
> +++ b/ts-kernel-build
> @@ -274,6 +274,10 @@ setopt CONFIG_MDIO_THUNDER=m
>   setopt CONFIG_I2C_THUNDERX=m
>   setopt CONFIG_SPI_THUNDERX=m
>   
> +# Some Linux branches we care about, including 4.19, still lack
> +# firmware: qcom_scm: Use proper types for dma mappings
> +CONFIG_ARCH_QCOM=n
> +
>   ####
>   
>   END
> 

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  parent reply	other threads:[~2019-05-31 15:52 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-30 11:34 [linux-4.19 test] 135420: regressions - FAIL osstest service owner
2019-04-30 11:34 ` [Xen-devel] " osstest service owner
2019-04-30 12:44 ` linux 4.19 does not build on armhf " Ian Jackson
2019-04-30 12:44   ` [Xen-devel] " Ian Jackson
2019-04-30 14:05   ` Jan Beulich
2019-04-30 14:05     ` [Xen-devel] " Jan Beulich
2019-04-30 14:06   ` qcom_scm: Incompatible pointer type build failure Julien Grall
2019-04-30 14:06   ` Julien Grall
2019-04-30 14:06     ` [Xen-devel] " Julien Grall
2019-05-17 16:10     ` Ian Jackson
2019-05-17 16:10       ` [Xen-devel] " Ian Jackson
2019-05-17 16:10       ` Ian Jackson
2019-05-17 21:09       ` [PATCH 0/3] qcom_scm: Fix some dma mapping things Stephen Boyd
2019-05-17 21:09       ` [PATCH 1/3] firmware: qcom_scm: Use proper types for dma mappings Stephen Boyd
2019-05-20  9:41         ` Ian Jackson
2019-05-20 13:20           ` Julien Grall
2019-05-30 16:51             ` [OSSTEST PATCH] ts-kernel-build: Disable CONFIG_ARCH_QCOM in Xen Project CI Ian Jackson
2019-05-30 16:51               ` [Xen-devel] " Ian Jackson
2019-05-30 16:51               ` Ian Jackson
2019-05-31 15:52               ` Julien Grall
2019-05-31 15:52               ` Julien Grall [this message]
2019-05-31 15:52                 ` [Xen-devel] " Julien Grall
2019-05-17 21:09       ` [PATCH 2/3] firmware: qcom_scm: Cleanup code in qcom_scm_assign_mem() Stephen Boyd
2019-07-22 23:27         ` Bjorn Andersson
2019-07-23  0:04           ` Stephen Boyd
2019-07-23  0:21             ` Bjorn Andersson
2019-05-17 21:09       ` [PATCH 3/3] firmware: qcom_scm: Fix some typos in docs and printks Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ffd5f689-085a-34f4-d150-5221783c0083@arm.com \
    --to=julien.grall@arm.com \
    --cc=agross@kernel.org \
    --cc=akdwived@codeaurora.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=ian.jackson@eu.citrix.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sstabellini@kernel.org \
    --cc=swboyd@chromium.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.