All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: isa: Fix inconsistent indenting
@ 2021-04-16  9:59 ` Yang Li
  0 siblings, 0 replies; 4+ messages in thread
From: Yang Li @ 2021-04-16  9:59 UTC (permalink / raw)
  To: perex; +Cc: tiwai, alsa-devel, linux-kernel, Yang Li

Kernel test robot throws below warning ->

smatch warnings:
sound/isa/opti9xx/opti92x-ad1848.c:191 snd_opti9xx_init() warn:
inconsistent indenting
sound/isa/opti9xx/opti92x-ad1848.c:488 snd_opti9xx_init() warn:
inconsistent indenting

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 sound/isa/opti9xx/opti92x-ad1848.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/isa/opti9xx/opti92x-ad1848.c b/sound/isa/opti9xx/opti92x-ad1848.c
index 08e61d9..234f023 100644
--- a/sound/isa/opti9xx/opti92x-ad1848.c
+++ b/sound/isa/opti9xx/opti92x-ad1848.c
@@ -188,7 +188,7 @@ static int snd_opti9xx_init(struct snd_opti9xx *chip,
 		chip->mc_base_size = opti9xx_mc_size[hardware];
 	}
 #else
-		chip->mc_base_size = opti9xx_mc_size[hardware];
+	chip->mc_base_size = opti9xx_mc_size[hardware];
 #endif
 
 	switch (hardware) {
@@ -485,7 +485,7 @@ static int snd_opti9xx_configure(struct snd_opti9xx *chip,
 #endif	/* CS4231 || OPTi93X */
 
 #ifndef OPTi93X
-	 outb(irq_bits << 3 | dma_bits, chip->wss_base);
+	outb(irq_bits << 3 | dma_bits, chip->wss_base);
 #else /* OPTi93X */
 	snd_opti9xx_write(chip, OPTi9XX_MC_REG(3), (irq_bits << 3 | dma_bits));
 #endif /* OPTi93X */
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] ALSA: isa: Fix inconsistent indenting
@ 2021-04-16  9:59 ` Yang Li
  0 siblings, 0 replies; 4+ messages in thread
From: Yang Li @ 2021-04-16  9:59 UTC (permalink / raw)
  To: perex; +Cc: alsa-devel, Yang Li, tiwai, linux-kernel

Kernel test robot throws below warning ->

smatch warnings:
sound/isa/opti9xx/opti92x-ad1848.c:191 snd_opti9xx_init() warn:
inconsistent indenting
sound/isa/opti9xx/opti92x-ad1848.c:488 snd_opti9xx_init() warn:
inconsistent indenting

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 sound/isa/opti9xx/opti92x-ad1848.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/isa/opti9xx/opti92x-ad1848.c b/sound/isa/opti9xx/opti92x-ad1848.c
index 08e61d9..234f023 100644
--- a/sound/isa/opti9xx/opti92x-ad1848.c
+++ b/sound/isa/opti9xx/opti92x-ad1848.c
@@ -188,7 +188,7 @@ static int snd_opti9xx_init(struct snd_opti9xx *chip,
 		chip->mc_base_size = opti9xx_mc_size[hardware];
 	}
 #else
-		chip->mc_base_size = opti9xx_mc_size[hardware];
+	chip->mc_base_size = opti9xx_mc_size[hardware];
 #endif
 
 	switch (hardware) {
@@ -485,7 +485,7 @@ static int snd_opti9xx_configure(struct snd_opti9xx *chip,
 #endif	/* CS4231 || OPTi93X */
 
 #ifndef OPTi93X
-	 outb(irq_bits << 3 | dma_bits, chip->wss_base);
+	outb(irq_bits << 3 | dma_bits, chip->wss_base);
 #else /* OPTi93X */
 	snd_opti9xx_write(chip, OPTi9XX_MC_REG(3), (irq_bits << 3 | dma_bits));
 #endif /* OPTi93X */
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: isa: Fix inconsistent indenting
  2021-04-16  9:59 ` Yang Li
@ 2021-04-16 10:39   ` Takashi Iwai
  -1 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2021-04-16 10:39 UTC (permalink / raw)
  To: Yang Li; +Cc: perex, tiwai, alsa-devel, linux-kernel

On Fri, 16 Apr 2021 11:59:58 +0200,
Yang Li wrote:
> 
> Kernel test robot throws below warning ->
> 
> smatch warnings:
> sound/isa/opti9xx/opti92x-ad1848.c:191 snd_opti9xx_init() warn:
> inconsistent indenting
> sound/isa/opti9xx/opti92x-ad1848.c:488 snd_opti9xx_init() warn:
> inconsistent indenting
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  sound/isa/opti9xx/opti92x-ad1848.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/isa/opti9xx/opti92x-ad1848.c b/sound/isa/opti9xx/opti92x-ad1848.c
> index 08e61d9..234f023 100644
> --- a/sound/isa/opti9xx/opti92x-ad1848.c
> +++ b/sound/isa/opti9xx/opti92x-ad1848.c
> @@ -188,7 +188,7 @@ static int snd_opti9xx_init(struct snd_opti9xx *chip,
>  		chip->mc_base_size = opti9xx_mc_size[hardware];
>  	}
>  #else
> -		chip->mc_base_size = opti9xx_mc_size[hardware];
> +	chip->mc_base_size = opti9xx_mc_size[hardware];
>  #endif

No, it's not correct.

The ifdef is a bit tricky here but the line you changed belongs
to the else section.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] ALSA: isa: Fix inconsistent indenting
@ 2021-04-16 10:39   ` Takashi Iwai
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2021-04-16 10:39 UTC (permalink / raw)
  To: Yang Li; +Cc: linux-kernel, alsa-devel, tiwai

On Fri, 16 Apr 2021 11:59:58 +0200,
Yang Li wrote:
> 
> Kernel test robot throws below warning ->
> 
> smatch warnings:
> sound/isa/opti9xx/opti92x-ad1848.c:191 snd_opti9xx_init() warn:
> inconsistent indenting
> sound/isa/opti9xx/opti92x-ad1848.c:488 snd_opti9xx_init() warn:
> inconsistent indenting
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  sound/isa/opti9xx/opti92x-ad1848.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/sound/isa/opti9xx/opti92x-ad1848.c b/sound/isa/opti9xx/opti92x-ad1848.c
> index 08e61d9..234f023 100644
> --- a/sound/isa/opti9xx/opti92x-ad1848.c
> +++ b/sound/isa/opti9xx/opti92x-ad1848.c
> @@ -188,7 +188,7 @@ static int snd_opti9xx_init(struct snd_opti9xx *chip,
>  		chip->mc_base_size = opti9xx_mc_size[hardware];
>  	}
>  #else
> -		chip->mc_base_size = opti9xx_mc_size[hardware];
> +	chip->mc_base_size = opti9xx_mc_size[hardware];
>  #endif

No, it's not correct.

The ifdef is a bit tricky here but the line you changed belongs
to the else section.


thanks,

Takashi

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-16 10:40 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-16  9:59 [PATCH] ALSA: isa: Fix inconsistent indenting Yang Li
2021-04-16  9:59 ` Yang Li
2021-04-16 10:39 ` Takashi Iwai
2021-04-16 10:39   ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.