* [PATCH v3] scsi: target: alua: do not report emtpy port group
@ 2022-09-12 21:45 Dmitry Bogdanov
2022-09-16 1:43 ` Martin K. Petersen
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Bogdanov @ 2022-09-12 21:45 UTC (permalink / raw)
To: Martin Petersen, target-devel
Cc: Mike Christie, Bart Van Assche, linux-scsi, linux, Dmitry Bogdanov
Default target port group is always returned in the list of port
groups, even if the behaviour is unwanted, i.e. it has no members and
non-default port groups are primary port groups.
That violates SPC-4 "6.37 REPORT TARGET PORT GROUPS command":
Every target port group shall contain at least one target port. The
target port group descriptor shall include one target port descriptor
for each target port in the target port group.
This patch hides port groups with no ports in REPORT TARGET PORT GROUPS
response.
Signed-off-by: Dmitry Bogdanov <d.bogdanov@yadro.com>
---
v3:
update commit message
v2:
new solution - just skip all empty groups
---
drivers/target/target_core_alua.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/target/target_core_alua.c b/drivers/target/target_core_alua.c
index fb91423a4e2e..c8470e7c0e10 100644
--- a/drivers/target/target_core_alua.c
+++ b/drivers/target/target_core_alua.c
@@ -164,6 +164,9 @@ target_emulate_report_target_port_groups(struct se_cmd *cmd)
spin_lock(&dev->t10_alua.tg_pt_gps_lock);
list_for_each_entry(tg_pt_gp, &dev->t10_alua.tg_pt_gps_list,
tg_pt_gp_list) {
+ /* Skip empty port groups */
+ if (!tg_pt_gp->tg_pt_gp_members)
+ continue;
/*
* Check if the Target port group and Target port descriptor list
* based on tg_pt_gp_members count will fit into the response payload.
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v3] scsi: target: alua: do not report emtpy port group
2022-09-12 21:45 [PATCH v3] scsi: target: alua: do not report emtpy port group Dmitry Bogdanov
@ 2022-09-16 1:43 ` Martin K. Petersen
0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2022-09-16 1:43 UTC (permalink / raw)
To: Dmitry Bogdanov
Cc: Martin Petersen, target-devel, Mike Christie, Bart Van Assche,
linux-scsi, linux
Dmitry,
> Default target port group is always returned in the list of port
> groups, even if the behaviour is unwanted, i.e. it has no members and
> non-default port groups are primary port groups.
Applied to 6.1/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-09-16 1:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-12 21:45 [PATCH v3] scsi: target: alua: do not report emtpy port group Dmitry Bogdanov
2022-09-16 1:43 ` Martin K. Petersen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.