All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Måns Rullgård" <mans@mansr.com>
To: Kevin Hilman <khilman@baylibre.com>
Cc: Peter Hurley <peter@hurleysoftware.com>, arm-soc <arm@kernel.org>,
	linux-serial <linux-serial@vger.kernel.org>,
	Sebastian Frias <sebastian_frias@sigmadesigns.com>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
Subject: Re: [RESEND PATCH v2] ARM: debug: add support for Palmchip BK-310x UART
Date: Wed, 27 Jan 2016 00:44:44 +0000	[thread overview]
Message-ID: <yw1x1t93lukj.fsf@unicorn.mansr.com> (raw)
In-Reply-To: <7h60yfn9c6.fsf@baylibre.com> (Kevin Hilman's message of "Tue, 26 Jan 2016 16:40:25 -0800")

Kevin Hilman <khilman@baylibre.com> writes:

> Marc Gonzalez <marc_gonzalez@sigmadesigns.com> writes:
>
>> From: Mans Rullgard <mans@mansr.com>
>>
>> Some SoCs use a Palmchip BK-310x UART which is mostly 16550 compatible
>> but with a different register layout.
>
> ... because UART register layout is where we really need innovation. ;)
>
>> While this UART has previously
>> only been supported in MIPS based chips (Alchemy, Ralink), the ARM based
>> SMP87xx series from Sigma Designs also uses it.
>>
>> This patch allows the debug console to work with this type of UART.
>>
>> Signed-off-by: Mans Rullgard <mans@mansr.com>
>> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
>
> It appears this was previously acked by Arnd also?
> https://lkml.org/lkml/2015/11/9/116
>
>> ---
>> Peter, this is the patch I've been using on Tango for earlyprintk support.
>> arm-soc, this is just the Nov 8 patch with my Signed-off-by tag.
>> ---
>>  arch/arm/Kconfig.debug            |  9 +++++++++
>>  arch/arm/include/debug/palmchip.S | 11 +++++++++++
>>  2 files changed, 20 insertions(+)
>>  create mode 100644 arch/arm/include/debug/palmchip.S
>>
>> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
>> index 259c0ca9c99a..708aa9150c00 100644
>> --- a/arch/arm/Kconfig.debug
>> +++ b/arch/arm/Kconfig.debug
>> @@ -1304,6 +1304,7 @@ config DEBUG_SIRFSOC_UART
>>  config DEBUG_LL_INCLUDE
>>  	string
>>  	default "debug/sa1100.S" if DEBUG_SA1100
>> +	default "debug/palmchip.S" if DEBUG_UART_8250_PALMCHIP
>
> minor nit: We're trying (not always with great success) to keep various
> parts of this file sorted alphanumerically.  Can you please insert the
> new entries accordingly?

It has to precede the regular 8250 entry so as to take precedence over
that.

> Otherwise looks good to me,
>
> Acked-by: Kevin Hilman <khilman@baylibre.com>
>
> Kevin

-- 
Måns Rullgård

WARNING: multiple messages have this Message-ID (diff)
From: mans@mansr.com (Måns Rullgård)
To: linux-arm-kernel@lists.infradead.org
Subject: [RESEND PATCH v2] ARM: debug: add support for Palmchip BK-310x UART
Date: Wed, 27 Jan 2016 00:44:44 +0000	[thread overview]
Message-ID: <yw1x1t93lukj.fsf@unicorn.mansr.com> (raw)
In-Reply-To: <7h60yfn9c6.fsf@baylibre.com> (Kevin Hilman's message of "Tue, 26 Jan 2016 16:40:25 -0800")

Kevin Hilman <khilman@baylibre.com> writes:

> Marc Gonzalez <marc_gonzalez@sigmadesigns.com> writes:
>
>> From: Mans Rullgard <mans@mansr.com>
>>
>> Some SoCs use a Palmchip BK-310x UART which is mostly 16550 compatible
>> but with a different register layout.
>
> ... because UART register layout is where we really need innovation. ;)
>
>> While this UART has previously
>> only been supported in MIPS based chips (Alchemy, Ralink), the ARM based
>> SMP87xx series from Sigma Designs also uses it.
>>
>> This patch allows the debug console to work with this type of UART.
>>
>> Signed-off-by: Mans Rullgard <mans@mansr.com>
>> Signed-off-by: Marc Gonzalez <marc_gonzalez@sigmadesigns.com>
>
> It appears this was previously acked by Arnd also?
> https://lkml.org/lkml/2015/11/9/116
>
>> ---
>> Peter, this is the patch I've been using on Tango for earlyprintk support.
>> arm-soc, this is just the Nov 8 patch with my Signed-off-by tag.
>> ---
>>  arch/arm/Kconfig.debug            |  9 +++++++++
>>  arch/arm/include/debug/palmchip.S | 11 +++++++++++
>>  2 files changed, 20 insertions(+)
>>  create mode 100644 arch/arm/include/debug/palmchip.S
>>
>> diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
>> index 259c0ca9c99a..708aa9150c00 100644
>> --- a/arch/arm/Kconfig.debug
>> +++ b/arch/arm/Kconfig.debug
>> @@ -1304,6 +1304,7 @@ config DEBUG_SIRFSOC_UART
>>  config DEBUG_LL_INCLUDE
>>  	string
>>  	default "debug/sa1100.S" if DEBUG_SA1100
>> +	default "debug/palmchip.S" if DEBUG_UART_8250_PALMCHIP
>
> minor nit: We're trying (not always with great success) to keep various
> parts of this file sorted alphanumerically.  Can you please insert the
> new entries accordingly?

It has to precede the regular 8250 entry so as to take precedence over
that.

> Otherwise looks good to me,
>
> Acked-by: Kevin Hilman <khilman@baylibre.com>
>
> Kevin

-- 
M?ns Rullg?rd

  reply	other threads:[~2016-01-27  0:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-18  8:27 [RESEND PATCH v2] ARM: debug: add support for Palmchip BK-310x UART Marc Gonzalez
2016-01-18  8:27 ` Marc Gonzalez
2016-01-27  0:40 ` Kevin Hilman
2016-01-27  0:40   ` Kevin Hilman
2016-01-27  0:44   ` Måns Rullgård [this message]
2016-01-27  0:44     ` Måns Rullgård
2016-01-29 16:44     ` Marc Gonzalez
2016-01-29 16:44       ` Marc Gonzalez
2016-01-29 16:50       ` Måns Rullgård
2016-01-29 16:50         ` Måns Rullgård
2016-01-29 16:58         ` Marc Gonzalez
2016-01-29 16:58           ` Marc Gonzalez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=yw1x1t93lukj.fsf@unicorn.mansr.com \
    --to=mans@mansr.com \
    --cc=arm@kernel.org \
    --cc=khilman@baylibre.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=marc_gonzalez@sigmadesigns.com \
    --cc=peter@hurleysoftware.com \
    --cc=sebastian_frias@sigmadesigns.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.