From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Rohit kumar <rohitkr@codeaurora.org>,
agross@kernel.org, bjorn.andersson@linaro.org,
lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
plai@codeaurora.org, bgoswami@codeaurora.org, perex@perex.cz,
tiwai@suse.com, linux-arm-msm@vger.kernel.org,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 04/12] ASoC: qcom: lpass-platform: fix memory leak
Date: Fri, 24 Jul 2020 12:21:45 +0100 [thread overview]
Message-ID: <1b8f969a-8f88-2928-0b29-9325451d9613@linaro.org> (raw)
In-Reply-To: <1595413915-17867-5-git-send-email-rohitkr@codeaurora.org>
On 22/07/2020 11:31, Rohit kumar wrote:
> lpass_pcm_data is never freed. Free it in close
> ops to avoid memory leak.
>
> Fixes: 022d00ee0b55 ("ASoC: lpass-platform: Fix broken pcm data usage")
> Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
Reviewed-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
> ---
> sound/soc/qcom/lpass-platform.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/qcom/lpass-platform.c b/sound/soc/qcom/lpass-platform.c
> index fb9acfd..b195f3d 100644
> --- a/sound/soc/qcom/lpass-platform.c
> +++ b/sound/soc/qcom/lpass-platform.c
> @@ -61,7 +61,7 @@ static int lpass_platform_pcmops_open(struct snd_soc_component *component,
> int ret, dma_ch, dir = substream->stream;
> struct lpass_pcm_data *data;
>
> - data = devm_kzalloc(soc_runtime->dev, sizeof(*data), GFP_KERNEL);
> + data = kzalloc(sizeof(*data), GFP_KERNEL);
> if (!data)
> return -ENOMEM;
>
> @@ -118,6 +118,7 @@ static int lpass_platform_pcmops_close(struct snd_soc_component *component,
> if (v->free_dma_channel)
> v->free_dma_channel(drvdata, data->dma_ch);
>
> + kfree(data);
> return 0;
> }
>
>
next prev parent reply other threads:[~2020-07-24 11:23 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 10:31 [PATCH v4 00/12] ASoC: qcom: Add support for SC7180 lpass variant Rohit kumar
2020-07-22 10:31 ` [PATCH v4 01/12] ASoC: qcom: Add common array to initialize soc based core clocks Rohit kumar
2020-08-06 0:31 ` Stephen Boyd
2020-08-06 3:59 ` Rohit Kumar
2020-08-07 20:17 ` Stephen Boyd
2020-07-22 10:31 ` [PATCH v4 02/12] ASoC: qcom: lpass-cpu: Move ahbix clk to platform specific function Rohit kumar
2020-07-22 10:31 ` [PATCH v4 03/12] ASoC: qcom: lpass-platform: Replace card->dev with component->dev Rohit kumar
2020-07-22 10:31 ` [PATCH v4 04/12] ASoC: qcom: lpass-platform: fix memory leak Rohit kumar
2020-07-24 11:21 ` Srinivas Kandagatla [this message]
2020-07-22 10:31 ` [PATCH v4 05/12] ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers Rohit kumar
2020-07-22 10:31 ` [PATCH v4 06/12] ASoC: qcom: lpass-cpu: fix concurrency issue Rohit kumar
2020-07-24 11:21 ` Srinivas Kandagatla
2020-07-22 10:31 ` [PATCH v4 07/12] dt-bindings: sound: lpass-cpu: Add sc7180 lpass cpu node Rohit kumar
2020-07-23 17:10 ` Rob Herring
2020-07-22 10:31 ` [PATCH v4 08/12] include: dt-bindings: sound: Add sc7180-lpass bindings header Rohit kumar
2020-07-23 17:11 ` Rob Herring
2020-07-22 10:31 ` [PATCH v4 09/12] ASoC: qcom: lpass-sc7180: Add platform driver for lpass audio Rohit kumar
2020-07-22 10:31 ` [PATCH v4 10/12] ASoC: qcom: lpass-cpu: Use platform_get_resource Rohit kumar
2020-07-24 11:22 ` Srinivas Kandagatla
2020-07-22 10:31 ` [PATCH v4 11/12] ASoC: qcom: lpass-platform: Use platform_get_irq Rohit kumar
2020-07-22 10:31 ` [PATCH v4 12/12] dt-bindings: sound: lpass-cpu: Move to yaml format Rohit kumar
2020-07-23 17:16 ` Rob Herring
2020-08-03 8:28 ` Rohit Kumar
2020-08-03 18:22 ` Rob Herring
2020-08-05 3:32 ` Rohit Kumar
2020-07-24 11:22 ` [PATCH v4 00/12] ASoC: qcom: Add support for SC7180 lpass variant Srinivas Kandagatla
2020-07-27 9:50 ` Rohit Kumar
2020-07-28 11:43 ` Rohit Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1b8f969a-8f88-2928-0b29-9325451d9613@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).