From: Rob Herring <robh@kernel.org>
To: Rohit kumar <rohitkr@codeaurora.org>
Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org,
bgoswami@codeaurora.org, linux-arm-msm@vger.kernel.org,
plai@codeaurora.org, tiwai@suse.com, agross@kernel.org,
lgirdwood@gmail.com, broonie@kernel.org,
srinivas.kandagatla@linaro.org, bjorn.andersson@linaro.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 07/12] dt-bindings: sound: lpass-cpu: Add sc7180 lpass cpu node
Date: Thu, 23 Jul 2020 11:10:53 -0600 [thread overview]
Message-ID: <20200723171053.GA544557@bogus> (raw)
In-Reply-To: <1595413915-17867-8-git-send-email-rohitkr@codeaurora.org>
On Wed, Jul 22, 2020 at 04:01:50PM +0530, Rohit kumar wrote:
> Add dt-bindings to support "qcom,lpass-cpu-sc7180" node.
>
> Signed-off-by: Rohit kumar <rohitkr@codeaurora.org>
> ---
> .../devicetree/bindings/sound/qcom,lpass-cpu.txt | 55 +++++++++++++++++++++-
> 1 file changed, 53 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt
> index 32c2cdb..c21392e 100644
> --- a/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt
> +++ b/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.txt
> @@ -4,7 +4,8 @@ This node models the Qualcomm Technologies Low-Power Audio SubSystem (LPASS).
>
> Required properties:
>
> -- compatible : "qcom,lpass-cpu" or "qcom,apq8016-lpass-cpu"
> +- compatible : "qcom,lpass-cpu" or "qcom,apq8016-lpass-cpu" or
> + "qcom,lpass-cpu-sc7180"
qcom,sc7180-lpass-cpu
> - clocks : Must contain an entry for each entry in clock-names.
> - clock-names : A list which must include the following entries:
> * "ahbix-clk"
> @@ -18,6 +19,13 @@ Required properties:
> * "mi2s-bit-clk3"
> * "pcnoc-mport-clk"
> * "pcnoc-sway-clk"
> + : required clocks for "qcom,lpass-cpu-sc7180"
> + * "audio-core"
> + * "mclk0"
> + * "mi2s-bit-clk0"
> + * "mi2s-bit-clk1"
> + * "pcnoc-sway-clk"
> + * "pcnoc-mport-clk"
>
> - interrupts : Must contain an entry for each entry in
> interrupt-names.
> @@ -53,7 +61,8 @@ Required properties for each DAI (represented by a subnode):
> Note that adding a subnode changes the default to "no lines configured",
> so both playback and capture lines should be configured when a subnode is added.
>
> -Example:
> +Examples:
> +1)
>
> lpass@28100000 {
> compatible = "qcom,lpass-cpu";
> @@ -77,3 +86,45 @@ lpass@28100000 {
> qcom,playback-sd-lines = <0 1>;
> };
> };
> +
> +2)
> +
> +#include <dt-bindings/sound/sc7180-lpass.h>
> +
> +lpass_cpu: lpass {
> + compatible = "qcom,lpass-cpu-sc7180";
> +
> + reg = <0 0x62F00000 0 0x29000>;
> +
> + iommus = <&apps_smmu 0x1020 0>;
> +
> + power-domains = <&lpass_hm LPASS_CORE_HM_GDSCR>;
> + clocks = <&gcc GCC_LPASS_CFG_NOC_SWAY_CLK>,
> + <&lpasscorecc LPASS_AUDIO_CORE_CORE_CLK>,
> + <&lpasscorecc LPASS_AUDIO_CORE_EXT_MCLK0_CLK>,
> + <&lpasscorecc LPASS_AUDIO_CORE_SYSNOC_MPORT_CORE_CLK>,
> + <&lpasscorecc LPASS_AUDIO_CORE_LPAIF_PRI_IBIT_CLK>,
> + <&lpasscorecc LPASS_AUDIO_CORE_LPAIF_SEC_IBIT_CLK>;
> + clock-names = "pcnoc-sway-clk", "audio-core",
> + "mclk0", "pcnoc-mport-clk",
> + "mi2s-bit-clk0", "mi2s-bit-clk1";
> + interrupts = <0 160 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "lpass-irq-lpaif";
> +
> +
> + #sound-dai-cells = <1>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + mi2s-primary@0 {
> + reg = <MI2S_PRIMARY>;
> + qcom,playback-sd-lines = <1>;
> + qcom,capture-sd-lines = <0>;
> + };
> +
> + mi2s-secondary@1 {
> + reg = <MI2S_SECONDARY>;
> + qcom,playback-sd-lines = <0>;
> + };
> +};
> --
> Qualcomm India Private Limited, on behalf of Qualcomm Innovation Center, Inc.,
> is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
>
next prev parent reply other threads:[~2020-07-23 17:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 10:31 [PATCH v4 00/12] ASoC: qcom: Add support for SC7180 lpass variant Rohit kumar
2020-07-22 10:31 ` [PATCH v4 01/12] ASoC: qcom: Add common array to initialize soc based core clocks Rohit kumar
2020-08-06 0:31 ` Stephen Boyd
2020-08-06 3:59 ` Rohit Kumar
2020-08-07 20:17 ` Stephen Boyd
2020-07-22 10:31 ` [PATCH v4 02/12] ASoC: qcom: lpass-cpu: Move ahbix clk to platform specific function Rohit kumar
2020-07-22 10:31 ` [PATCH v4 03/12] ASoC: qcom: lpass-platform: Replace card->dev with component->dev Rohit kumar
2020-07-22 10:31 ` [PATCH v4 04/12] ASoC: qcom: lpass-platform: fix memory leak Rohit kumar
2020-07-24 11:21 ` Srinivas Kandagatla
2020-07-22 10:31 ` [PATCH v4 05/12] ASoC: qcom: lpass: Use regmap_field for i2sctl and dmactl registers Rohit kumar
2020-07-22 10:31 ` [PATCH v4 06/12] ASoC: qcom: lpass-cpu: fix concurrency issue Rohit kumar
2020-07-24 11:21 ` Srinivas Kandagatla
2020-07-22 10:31 ` [PATCH v4 07/12] dt-bindings: sound: lpass-cpu: Add sc7180 lpass cpu node Rohit kumar
2020-07-23 17:10 ` Rob Herring [this message]
2020-07-22 10:31 ` [PATCH v4 08/12] include: dt-bindings: sound: Add sc7180-lpass bindings header Rohit kumar
2020-07-23 17:11 ` Rob Herring
2020-07-22 10:31 ` [PATCH v4 09/12] ASoC: qcom: lpass-sc7180: Add platform driver for lpass audio Rohit kumar
2020-07-22 10:31 ` [PATCH v4 10/12] ASoC: qcom: lpass-cpu: Use platform_get_resource Rohit kumar
2020-07-24 11:22 ` Srinivas Kandagatla
2020-07-22 10:31 ` [PATCH v4 11/12] ASoC: qcom: lpass-platform: Use platform_get_irq Rohit kumar
2020-07-22 10:31 ` [PATCH v4 12/12] dt-bindings: sound: lpass-cpu: Move to yaml format Rohit kumar
2020-07-23 17:16 ` Rob Herring
2020-08-03 8:28 ` Rohit Kumar
2020-08-03 18:22 ` Rob Herring
2020-08-05 3:32 ` Rohit Kumar
2020-07-24 11:22 ` [PATCH v4 00/12] ASoC: qcom: Add support for SC7180 lpass variant Srinivas Kandagatla
2020-07-27 9:50 ` Rohit Kumar
2020-07-28 11:43 ` Rohit Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723171053.GA544557@bogus \
--to=robh@kernel.org \
--cc=agross@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=plai@codeaurora.org \
--cc=rohitkr@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).