* [PATCH] ASoC: 88pm860: Fix IO setup
@ 2014-03-04 8:39 Lars-Peter Clausen
2014-03-10 11:29 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Lars-Peter Clausen @ 2014-03-04 8:39 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood
Cc: alsa-devel, Xiubo Li, Lars-Peter Clausen, Haojian Zhuang
The 88pm860 is a MFD device and the CODEC driver is using the regmap struct of
the parent device, hence automatic IO setup will not work and we need to
manually call snd_soc_codec_set_cache_io(). The issue was introduced in commit
f9ded3b2e7 ("ASoC: 88pm860x: Use regmap for I/O").
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
sound/soc/codecs/88pm860x-codec.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/soc/codecs/88pm860x-codec.c b/sound/soc/codecs/88pm860x-codec.c
index 697d24b..8703244 100644
--- a/sound/soc/codecs/88pm860x-codec.c
+++ b/sound/soc/codecs/88pm860x-codec.c
@@ -1328,6 +1328,9 @@ static int pm860x_probe(struct snd_soc_codec *codec)
pm860x->codec = codec;
codec->control_data = pm860x->regmap;
+ ret = snd_soc_codec_set_cache_io(codec, 0, 0, SND_SOC_REGMAP);
+ if (ret)
+ return ret;
for (i = 0; i < 4; i++) {
ret = request_threaded_irq(pm860x->irq[i], NULL,
--
1.8.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: 88pm860: Fix IO setup
2014-03-04 8:39 [PATCH] ASoC: 88pm860: Fix IO setup Lars-Peter Clausen
@ 2014-03-10 11:29 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2014-03-10 11:29 UTC (permalink / raw)
To: Lars-Peter Clausen; +Cc: alsa-devel, Xiubo Li, Liam Girdwood, Haojian Zhuang
[-- Attachment #1.1: Type: text/plain, Size: 398 bytes --]
On Tue, Mar 04, 2014 at 09:39:24AM +0100, Lars-Peter Clausen wrote:
> The 88pm860 is a MFD device and the CODEC driver is using the regmap struct of
> the parent device, hence automatic IO setup will not work and we need to
> manually call snd_soc_codec_set_cache_io(). The issue was introduced in commit
> f9ded3b2e7 ("ASoC: 88pm860x: Use regmap for I/O").
Applied, thanks. Please do use Fixes:
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-10 11:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-04 8:39 [PATCH] ASoC: 88pm860: Fix IO setup Lars-Peter Clausen
2014-03-10 11:29 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).