From: Greg KH <gregkh@linuxfoundation.org>
To: Dave Ertman <david.m.ertman@intel.com>
Cc: alsa-devel@alsa-project.org, tiwai@suse.de,
ranjani.sridharan@intel.com,
pierre-louis.bossart@linux.intel.com,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Fred Oh <fred.oh@linux.intel.com>,
broonie@kernel.org, parav@nvidia.com, jgg@nvidia.com
Subject: Re: [PATCH 3/6] ASoC: SOF: Create client driver for IPC test
Date: Thu, 1 Oct 2020 15:04:50 +0200 [thread overview]
Message-ID: <20201001130450.GC2378679@kroah.com> (raw)
In-Reply-To: <20200930225051.889607-4-david.m.ertman@intel.com>
On Wed, Sep 30, 2020 at 03:50:48PM -0700, Dave Ertman wrote:
> +/*
> + * The IPC test client creates a couple of debugfs entries that will be used
> + * flood tests. Users can write to these entries to execute the IPC flood test
> + * by specifying either the number of IPCs to flood the DSP with or the duration
> + * (in ms) for which the DSP should be flooded with test IPCs. At the
> + * end of each test, the average, min and max response times are reported back.
> + * The results of the last flood test can be accessed by reading the debugfs
> + * entries.
> + */
> +static int sof_ipc_test_probe(struct ancillary_device *ancildev,
> + const struct ancillary_device_id *id)
> +{
> + struct sof_client_dev *cdev = ancillary_dev_to_sof_client_dev(ancildev);
> + struct sof_ipc_client_data *ipc_client_data;
> +
> + /*
> + * The ancillary device has a usage count of 0 even before runtime PM
> + * is enabled. So, increment the usage count to let the device
> + * suspend after probe is complete.
> + */
> + pm_runtime_get_noresume(&ancildev->dev);
> +
> + /* allocate memory for client data */
> + ipc_client_data = devm_kzalloc(&ancildev->dev, sizeof(*ipc_client_data), GFP_KERNEL);
> + if (!ipc_client_data)
> + return -ENOMEM;
> +
> + ipc_client_data->buf = devm_kzalloc(&ancildev->dev, IPC_FLOOD_TEST_RESULT_LEN, GFP_KERNEL);
> + if (!ipc_client_data->buf)
> + return -ENOMEM;
> +
> + cdev->data = ipc_client_data;
> +
> + /* create debugfs root folder with device name under parent SOF dir */
> + ipc_client_data->dfs_root = debugfs_create_dir(dev_name(&ancildev->dev),
> + sof_client_get_debugfs_root(cdev));
> +
> + /* create read-write ipc_flood_count debugfs entry */
> + debugfs_create_file("ipc_flood_count", 0644, ipc_client_data->dfs_root,
> + cdev, &sof_ipc_dfs_fops);
> +
> + /* create read-write ipc_flood_duration_ms debugfs entry */
> + debugfs_create_file("ipc_flood_duration_ms", 0644, ipc_client_data->dfs_root,
> + cdev, &sof_ipc_dfs_fops);
These debugfs files are never removed, why not?
thanks,
greg k-h
next prev parent reply other threads:[~2020-10-01 13:05 UTC|newest]
Thread overview: 99+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 22:50 [PATCH 0/6] Ancillary bus implementation and SOF multi-client support Dave Ertman
2020-09-30 22:50 ` [PATCH 1/6] Add ancillary bus support Dave Ertman
2020-09-30 23:05 ` Jason Gunthorpe
2020-10-01 11:01 ` Greg KH
2020-10-01 11:46 ` Jason Gunthorpe
2020-10-01 11:54 ` Greg KH
2020-10-01 12:02 ` Jason Gunthorpe
2020-10-01 12:15 ` Greg KH
2020-10-01 18:26 ` Ertman, David M
2020-10-01 11:02 ` Greg KH
2020-10-01 16:30 ` Ertman, David M
2020-10-01 11:05 ` Greg KH
2020-10-01 11:58 ` Jason Gunthorpe
2020-10-01 12:14 ` Greg KH
2020-10-01 14:33 ` Jason Gunthorpe
2020-10-01 14:38 ` Greg KH
2020-10-01 16:06 ` Pierre-Louis Bossart
2020-10-01 17:42 ` Jason Gunthorpe
2020-10-01 14:39 ` Parav Pandit
2020-10-01 14:43 ` Greg KH
2020-10-01 13:27 ` Mark Brown
2020-09-30 22:50 ` [PATCH 2/6] ASoC: SOF: Introduce descriptors for SOF client Dave Ertman
2020-10-01 13:02 ` Greg KH
2020-10-01 15:59 ` Sridharan, Ranjani
2020-10-01 22:16 ` Sridharan, Ranjani
2020-10-02 4:53 ` gregkh
2020-10-02 17:07 ` Sridharan, Ranjani
2020-10-03 9:02 ` gregkh
2020-10-05 2:35 ` Sridharan, Ranjani
2020-10-05 11:27 ` gregkh
2020-10-05 15:18 ` Pierre-Louis Bossart
2020-10-05 15:32 ` gregkh
2020-10-01 13:38 ` Mark Brown
2020-10-01 16:48 ` Sridharan, Ranjani
2020-09-30 22:50 ` [PATCH 3/6] ASoC: SOF: Create client driver for IPC test Dave Ertman
2020-10-01 13:04 ` Greg KH [this message]
2020-10-01 16:46 ` Sridharan, Ranjani
2020-10-01 13:09 ` Greg KH
2020-10-01 13:55 ` Pierre-Louis Bossart
2020-10-01 16:48 ` Ertman, David M
2020-10-01 13:59 ` Mark Brown
2020-09-30 22:50 ` [PATCH 4/6] ASoC: SOF: ops: Add ops for client registration Dave Ertman
2020-09-30 22:50 ` [PATCH 5/6] ASoC: SOF: Intel: Define " Dave Ertman
2020-09-30 22:50 ` [PATCH 6/6] ASoC: SOF: debug: Remove IPC flood test support in SOF core Dave Ertman
2020-10-01 5:58 ` [PATCH 0/6] Ancillary bus implementation and SOF multi-client support Greg KH
2020-10-01 15:54 ` Ertman, David M
2020-10-01 7:14 ` Greg KH
2020-10-01 15:55 ` Ertman, David M
2020-10-01 16:10 ` Greg KH
2020-10-01 17:13 ` Ertman, David M
2020-10-02 20:23 ` Ertman, David M
2020-10-03 9:08 ` Greg KH
2020-10-03 9:09 ` Greg KH
2020-10-04 2:26 ` Parav Pandit
2020-10-04 23:45 ` Williams, Dan J
2020-10-05 1:18 ` Ertman, David M
2020-10-05 2:39 ` Parav Pandit
2020-10-05 11:25 ` gregkh
2020-10-06 22:40 ` Dan Williams
2020-10-07 9:14 ` gregkh
2020-10-07 16:19 ` Dan Williams
2020-10-07 16:22 ` Mark Brown
2020-10-07 16:41 ` Dan Williams
2020-10-07 16:42 ` Pierre-Louis Bossart
2020-10-07 16:56 ` Parav Pandit
2020-10-01 10:05 ` Rojewski, Cezary
2020-10-01 10:59 ` gregkh
2020-10-01 12:49 ` Jason Gunthorpe
2020-10-01 12:55 ` gregkh
2020-10-01 13:26 ` Jason Gunthorpe
2020-10-01 14:17 ` gregkh
2020-10-01 15:08 ` Parav Pandit
2020-10-01 12:50 ` Mark Brown
2020-10-01 13:12 ` Greg KH
2020-10-01 13:42 ` Jason Gunthorpe
2020-10-01 14:40 ` Mark Brown
2020-10-01 15:32 ` Greg KH
2020-10-01 16:03 ` Mark Brown
2020-10-01 18:16 ` Greg KH
2020-10-01 18:29 ` Ertman, David M
2020-10-01 19:38 ` Mark Brown
2020-10-01 19:54 ` Ertman, David M
2020-10-01 20:17 ` Mark Brown
2020-10-02 0:47 ` Jason Gunthorpe
2020-10-02 11:19 ` Mark Brown
2020-10-02 17:23 ` Ertman, David M
2020-10-02 17:25 ` Jason Gunthorpe
2020-10-02 17:44 ` Mark Brown
2020-10-01 14:07 ` Pierre-Louis Bossart
2020-10-01 15:24 ` Mark Brown
2020-10-01 16:20 ` Pierre-Louis Bossart
2020-10-01 16:51 ` Mark Brown
2020-10-01 18:04 ` Jason Gunthorpe
2020-10-01 18:13 ` Greg KH
2020-10-01 19:23 ` Mark Brown
2020-10-01 16:50 ` Ertman, David M
2020-10-01 17:10 ` Mark Brown
2020-10-01 17:16 ` Ertman, David M
2020-10-01 17:52 ` Ertman, David M
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201001130450.GC2378679@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=david.m.ertman@intel.com \
--cc=fred.oh@linux.intel.com \
--cc=jgg@nvidia.com \
--cc=parav@nvidia.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).