* [alsa-devel] [PATCH] ALSA: hda - Force polling mode on CML for fixing codec communication
@ 2019-09-24 5:37 Sathyanarayana Nujella
2019-09-24 6:30 ` Takashi Iwai
2019-09-24 13:32 ` Pierre-Louis Bossart
0 siblings, 2 replies; 4+ messages in thread
From: Sathyanarayana Nujella @ 2019-09-24 5:37 UTC (permalink / raw)
To: tiwai, broonie
Cc: alsa-devel, harshapriya.n, pierre-louis.bossart, liam.r.girdwood,
Sathyanarayana Nujella, yung-chuan.liao, Joyce Toh
We observed the same issue as reported by commit a8d7bde23e7130686b7662
("ALSA: hda - Force polling mode on CFL for fixing codec communication")
Apply the same fix to CML.
Signed-off-by: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com>
Signed-off-by: Joyce Toh <joyce.toh@intel.com>
---
sound/pci/hda/hda_intel.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 91e71be42fa4..e6997a5bf098 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -370,6 +370,7 @@ enum {
#define IS_BXT(pci) ((pci)->vendor == 0x8086 && (pci)->device == 0x5a98)
#define IS_CFL(pci) ((pci)->vendor == 0x8086 && (pci)->device == 0xa348)
#define IS_CNL(pci) ((pci)->vendor == 0x8086 && (pci)->device == 0x9dc8)
+#define IS_CML(pci) ((pci)->vendor == 0x8086 && (pci)->device == 0x02c8)
static char *driver_short_names[] = {
[AZX_DRIVER_ICH] = "HDA Intel",
@@ -1754,7 +1755,7 @@ static int azx_create(struct snd_card *card, struct pci_dev *pci,
azx_bus(chip)->dma_type = SNDRV_DMA_TYPE_DEV_UC;
/* Workaround for a communication error on CFL (bko#199007) and CNL */
- if (IS_CFL(pci) || IS_CNL(pci))
+ if (IS_CFL(pci) || IS_CNL(pci) || IS_CML(pci))
azx_bus(chip)->polling_mode = 1;
if (chip->driver_type == AZX_DRIVER_NVIDIA) {
--
2.7.4
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [alsa-devel] [PATCH] ALSA: hda - Force polling mode on CML for fixing codec communication
2019-09-24 5:37 [alsa-devel] [PATCH] ALSA: hda - Force polling mode on CML for fixing codec communication Sathyanarayana Nujella
@ 2019-09-24 6:30 ` Takashi Iwai
2019-09-26 18:52 ` Nujella, Sathyanarayana
2019-09-24 13:32 ` Pierre-Louis Bossart
1 sibling, 1 reply; 4+ messages in thread
From: Takashi Iwai @ 2019-09-24 6:30 UTC (permalink / raw)
To: Sathyanarayana Nujella
Cc: alsa-devel, harshapriya.n, pierre-louis.bossart, liam.r.girdwood,
broonie, yung-chuan.liao, Joyce Toh
On Tue, 24 Sep 2019 07:37:23 +0200,
Sathyanarayana Nujella wrote:
>
> We observed the same issue as reported by commit a8d7bde23e7130686b7662
> ("ALSA: hda - Force polling mode on CFL for fixing codec communication")
> Apply the same fix to CML.
>
> Signed-off-by: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com>
> Signed-off-by: Joyce Toh <joyce.toh@intel.com>
Could you confirm that this workaround is still necessary for the
latest code? We switched to the write-sync on the recent Intel chips,
and this may already cover such errors.
thanks,
Takashi
> ---
> sound/pci/hda/hda_intel.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index 91e71be42fa4..e6997a5bf098 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -370,6 +370,7 @@ enum {
> #define IS_BXT(pci) ((pci)->vendor == 0x8086 && (pci)->device == 0x5a98)
> #define IS_CFL(pci) ((pci)->vendor == 0x8086 && (pci)->device == 0xa348)
> #define IS_CNL(pci) ((pci)->vendor == 0x8086 && (pci)->device == 0x9dc8)
> +#define IS_CML(pci) ((pci)->vendor == 0x8086 && (pci)->device == 0x02c8)
>
> static char *driver_short_names[] = {
> [AZX_DRIVER_ICH] = "HDA Intel",
> @@ -1754,7 +1755,7 @@ static int azx_create(struct snd_card *card, struct pci_dev *pci,
> azx_bus(chip)->dma_type = SNDRV_DMA_TYPE_DEV_UC;
>
> /* Workaround for a communication error on CFL (bko#199007) and CNL */
> - if (IS_CFL(pci) || IS_CNL(pci))
> + if (IS_CFL(pci) || IS_CNL(pci) || IS_CML(pci))
> azx_bus(chip)->polling_mode = 1;
>
> if (chip->driver_type == AZX_DRIVER_NVIDIA) {
> --
> 2.7.4
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [alsa-devel] [PATCH] ALSA: hda - Force polling mode on CML for fixing codec communication
2019-09-24 5:37 [alsa-devel] [PATCH] ALSA: hda - Force polling mode on CML for fixing codec communication Sathyanarayana Nujella
2019-09-24 6:30 ` Takashi Iwai
@ 2019-09-24 13:32 ` Pierre-Louis Bossart
1 sibling, 0 replies; 4+ messages in thread
From: Pierre-Louis Bossart @ 2019-09-24 13:32 UTC (permalink / raw)
To: Sathyanarayana Nujella, tiwai, broonie
Cc: liam.r.girdwood, harshapriya.n, alsa-devel, yung-chuan.liao, Joyce Toh
On 9/24/19 12:37 AM, Sathyanarayana Nujella wrote:
> We observed the same issue as reported by commit a8d7bde23e7130686b7662
> ("ALSA: hda - Force polling mode on CFL for fixing codec communication")
> Apply the same fix to CML.
>
> Signed-off-by: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com>
> Signed-off-by: Joyce Toh <joyce.toh@intel.com>
> ---
> sound/pci/hda/hda_intel.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
> index 91e71be42fa4..e6997a5bf098 100644
> --- a/sound/pci/hda/hda_intel.c
> +++ b/sound/pci/hda/hda_intel.c
> @@ -370,6 +370,7 @@ enum {
> #define IS_BXT(pci) ((pci)->vendor == 0x8086 && (pci)->device == 0x5a98)
> #define IS_CFL(pci) ((pci)->vendor == 0x8086 && (pci)->device == 0xa348)
> #define IS_CNL(pci) ((pci)->vendor == 0x8086 && (pci)->device == 0x9dc8)
> +#define IS_CML(pci) ((pci)->vendor == 0x8086 && (pci)->device == 0x02c8)
nit-pick: This should be IS_CML_LP(), there are two separate PCI IDs for
CometLake LP and H.
>
> static char *driver_short_names[] = {
> [AZX_DRIVER_ICH] = "HDA Intel",
> @@ -1754,7 +1755,7 @@ static int azx_create(struct snd_card *card, struct pci_dev *pci,
> azx_bus(chip)->dma_type = SNDRV_DMA_TYPE_DEV_UC;
>
> /* Workaround for a communication error on CFL (bko#199007) and CNL */
> - if (IS_CFL(pci) || IS_CNL(pci))
> + if (IS_CFL(pci) || IS_CNL(pci) || IS_CML(pci))
> azx_bus(chip)->polling_mode = 1;
>
> if (chip->driver_type == AZX_DRIVER_NVIDIA) {
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [alsa-devel] [PATCH] ALSA: hda - Force polling mode on CML for fixing codec communication
2019-09-24 6:30 ` Takashi Iwai
@ 2019-09-26 18:52 ` Nujella, Sathyanarayana
0 siblings, 0 replies; 4+ messages in thread
From: Nujella, Sathyanarayana @ 2019-09-26 18:52 UTC (permalink / raw)
To: Takashi Iwai
Cc: alsa-devel, N, Harshapriya, pierre-louis.bossart,
liam.r.girdwood, broonie, yung-chuan.liao, Toh, Joyce
> -----Original Message-----
> From: Takashi Iwai [mailto:tiwai@suse.de]
> Sent: Monday, September 23, 2019 11:30 PM
> To: Nujella, Sathyanarayana <sathyanarayana.nujella@intel.com>
> Cc: broonie@kernel.org; alsa-devel@alsa-project.org;
> liam.r.girdwood@linux.intel.com; pierre-louis.bossart@linux.intel.com; yung-
> chuan.liao@linux.intel.com; N, Harshapriya <harshapriya.n@intel.com>; Toh,
> Joyce <joyce.toh@intel.com>
> Subject: Re: [PATCH] ALSA: hda - Force polling mode on CML for fixing codec
> communication
>
>
> Could you confirm that this workaround is still necessary for the latest code?
> We switched to the write-sync on the recent Intel chips, and this may already
> cover such errors.
>
>
> thanks,
>
> Takashi
Thank you. We cross checked with latest code and specifically applied the below commit:
ALSA: hda - Fix intermittent CORB/RIRB stall on Intel chips
Now, we see suspend & resume time significantly reduced.
So, current WA patch is not needed.
BR
Sathya
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-26 18:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-24 5:37 [alsa-devel] [PATCH] ALSA: hda - Force polling mode on CML for fixing codec communication Sathyanarayana Nujella
2019-09-24 6:30 ` Takashi Iwai
2019-09-26 18:52 ` Nujella, Sathyanarayana
2019-09-24 13:32 ` Pierre-Louis Bossart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).