From: 班涛 <fengzheng923@gmail.com>
To: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
Cc: alsa-devel@alsa-project.org, samuel@sholland.org,
linux-kernel@vger.kernel.org, tiwai@suse.com,
jernej.skrabec@gmail.com, lgirdwood@gmail.com, wens@csie.org,
broonie@kernel.org, linux-sunxi@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v8 1/2] ASoC: sunxi: Add Allwinner H6 Digital MIC driver
Date: Tue, 23 Aug 2022 23:05:52 +0800 [thread overview]
Message-ID: <CAE=m61-djqRrCCaWgQQA+Qhf06ZObeHrPvrCz3+13nEDGgyueA@mail.gmail.com> (raw)
In-Reply-To: <73dceca7-5244-ffa6-6ead-d4de84584b68@linux.intel.com>
Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com> 于2022年8月12日周五
23:20写道：
> On 8/11/2022 4:49 PM, Ban Tao wrote:
> > The Allwinner H6 and later SoCs have an DMIC block
> > which is capable of capture.
> >
> > Signed-off-by: Ban Tao <fengzheng923@gmail.com>
> > ---
>
> ...
>
> > +
> > +#define SUN50I_DMIC_RATES (SNDRV_PCM_RATE_8000_48000)
>
> Seeing supported rates in hw_params callback, you probably want to take
> a look at SNDRV_PCM_RATE_KNOT?
>
No, I don't need SNDRV_PCM_RATE_KNOT. Dmic does not support unknown rates.
>
> > +#define SUN50I_DMIC_FORMATS (SNDRV_PCM_FMTBIT_S16_LE |
> SNDRV_PCM_FMTBIT_S24_LE)
> > +
> > +static struct snd_soc_dai_driver sun50i_dmic_dai = {
> > + .capture = {
> > + .channels_min = 1,
> > + .channels_max = 8,
> > + .rates = SUN50I_DMIC_RATES,
> > + .formats = SUN50I_DMIC_FORMATS,
> > + .sig_bits = 21,
> > + },
> > + .probe = sun50i_dmic_soc_dai_probe,
> > + .ops = &sun50i_dmic_dai_ops,
> > + .name = "dmic",
> > +};
> > +
>
> ...
>
>
prev parent reply other threads:[~2022-08-23 15:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-11 14:49 [PATCH v8 1/2] ASoC: sunxi: Add Allwinner H6 Digital MIC driver Ban Tao
2022-08-20 6:57 ` Samuel Holland
2022-08-23 15:08 ` 班涛
2022-08-26 3:35 ` Samuel Holland
[not found] ` <73dceca7-5244-ffa6-6ead-d4de84584b68@linux.intel.com>
2022-08-23 15:05 ` 班涛 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE=m61-djqRrCCaWgQQA+Qhf06ZObeHrPvrCz3+13nEDGgyueA@mail.gmail.com' \
--to=fengzheng923@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=jernej.skrabec@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=samuel@sholland.org \
--cc=tiwai@suse.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).