Missed review / mailing list submission?

Missed review / mailing list submission?

[Andy Shevchenko]

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/ci.git/commit/?h=asoc-6.10&id=710f9a3673d6839c485d6a1cd59a2b5078092d47

I can't find this in the mailing list.
Moreover, it has an obstacle to be applied, i.e. as per
https://elixir.bootlin.com/linux/v6.9-rc5/source/include/linux/gpio.h#L5
the gpio.h must not be included in a new code and brief looking into
that driver shows that legacy APIs are being used without _any_ good
reason.

This has to be fixed (by the author).

-- 
With Best Regards,
Andy Shevchenko

Re: Missed review / mailing list submission?

[Andy Shevchenko]

On Mon, Apr 22, 2024 at 9:28 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/ci.git/commit/?h=asoc-6.10&id=710f9a3673d6839c485d6a1cd59a2b5078092d47
>
> I can't find this in the mailing list.

To be clear I have checked lore and spinics.net. So, it's not a lore
problem if you wonder.

> Moreover, it has an obstacle to be applied, i.e. as per
> https://elixir.bootlin.com/linux/v6.9-rc5/source/include/linux/gpio.h#L5
> the gpio.h must not be included in a new code and brief looking into
> that driver shows that legacy APIs are being used without _any_ good
> reason.
>
> This has to be fixed (by the author).

-- 
With Best Regards,
Andy Shevchenko

Re: Missed review / mailing list submission?

[Andy Shevchenko]

On Mon, Apr 22, 2024 at 9:30 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Mon, Apr 22, 2024 at 9:28 PM Andy Shevchenko
> <andy.shevchenko@gmail.com> wrote:
> >
> > https://git.kernel.org/pub/scm/linux/kernel/git/broonie/ci.git/commit/?h=asoc-6.10&id=710f9a3673d6839c485d6a1cd59a2b5078092d47
> >
> > I can't find this in the mailing list.
>
> To be clear I have checked lore and spinics.net. So, it's not a lore
> problem if you wonder.

Okay, I found it eventually.

> > Moreover, it has an obstacle to be applied, i.e. as per
> > https://elixir.bootlin.com/linux/v6.9-rc5/source/include/linux/gpio.h#L5
> > the gpio.h must not be included in a new code and brief looking into
> > that driver shows that legacy APIs are being used without _any_ good
> > reason.
> >
> > This has to be fixed (by the author).



-- 
With Best Regards,
Andy Shevchenko

Re: Missed review / mailing list submission?

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 1443 bytes --]

On Mon, Apr 22, 2024 at 09:28:45PM +0300, Andy Shevchenko wrote:

> https://git.kernel.org/pub/scm/linux/kernel/git/broonie/ci.git/commit/?h=asoc-6.10&id=710f9a3673d6839c485d6a1cd59a2b5078092d47

Please include human readable descriptions of things like commits and
issues being discussed in e-mail in your mails, this makes them much
easier for humans to read especially when they have no internet access.
I do frequently catch up on my mail on flights or while otherwise
travelling so this is even more pressing for me than just being about
making things a bit easier to read.

For the benefit of those playing at home (or like me, on a high speed
train) this is the PCM6240 driver.

> I can't find this in the mailing list.

That was like v9 or something, as you later noticed it's been on the
list over a very extended period with many revisions - there has been a
more than adequate opportunity for review here (Pierre did a bunch for
example).

> Moreover, it has an obstacle to be applied, i.e. as per
> https://elixir.bootlin.com/linux/v6.9-rc5/source/include/linux/gpio.h#L5
> the gpio.h must not be included in a new code and brief looking into
> that driver shows that legacy APIs are being used without _any_ good
> reason.

> This has to be fixed (by the author).

Or someone else, for example you could do it if you were so moved.  You
haven't even CCed Shenghao here...  please at least send a mail to him
explaining the issue.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: Missed review / mailing list submission?

[Andy Shevchenko]

On Tue, Apr 23, 2024 at 7:54 AM Mark Brown <broonie@kernel.org> wrote:
> On Mon, Apr 22, 2024 at 09:28:45PM +0300, Andy Shevchenko wrote:

> > I can't find this in the mailing list.
>
> That was like v9 or something, as you later noticed it's been on the
> list over a very extended period with many revisions - there has been a
> more than adequate opportunity for review here (Pierre did a bunch for
> example).

Right, I simply looked at the wrong place, sorry.

> > Moreover, it has an obstacle to be applied, i.e. as per
> > https://elixir.bootlin.com/linux/v6.9-rc5/source/include/linux/gpio.h#L5
> > the gpio.h must not be included in a new code and brief looking into
> > that driver shows that legacy APIs are being used without _any_ good
> > reason.
>
> > This has to be fixed (by the author).
>
> Or someone else, for example you could do it if you were so moved.

Sure.

> You
> haven't even CCed Shenghao here...  please at least send a mail to him
> explaining the issue.

I Cc'ed in the last of the three I have sent.


-- 
With Best Regards,
Andy Shevchenko