Re: [PATCH v1 0/7] Add support for various laptops using CS35L41 HDA without _DSD

Re: [PATCH v1 0/7] Add support for various laptops using CS35L41 HDA without _DSD

[Niclas Söderlund]

Hi,

amazingly high level of laymanship here and equally high level of dispear. But model after model is added to fix the problem with speakers not working, but nowhere is my model seen. I have the Lenovo 13X G2 model and even at kernel 6.8.7 my speakers still doesnt work.

Where can I add a request to also include this model in the patches, so I have a hope of having the speakers start working?

I do apologise in advance but it would be a huge loss if this laptop is not appended as being one of the models being fixed.

Mvh, Niclas Söderlund

RE: [PATCH v1 0/7] Add support for various laptops using CS35L41 HDA without _DSD

[Stefan Binding]

Hi Niclas,
 
The SKU in question isn't currently scheduled for support, however if you create a bugzilla ticket at the below address and CC Cirrus Patches (patches@opensource.cirrus.com) to it, we will investigate adding support as soon as we can.
 
https://bugzilla.kernel.org/
 
Thanks,
 
Stefan
 
From: Niclas Söderlund <niclas@soderlund.org> 
Sent: Friday, April 19, 2024 8:45 AM
To: sbinding@opensource.cirrus.com
Cc: alsa-devel@alsa-project.org; linux-kernel@vger.kernel.org; linux-sound@vger.kernel.org; patches@opensource.cirrus.com; perex@perex.cz; tiwai@suse.com
Subject: RE: [PATCH v1 0/7] Add support for various laptops using CS35L41 HDA without _DSD
 
Hi,

amazingly high level of laymanship here and equally high level of dispear. But model after model is added to fix the problem with speakers not working, but nowhere is my model seen. I have the Lenovo 13X G2 model and even at kernel 6.8.7 my speakers still doesnt work.

Where can I add a request to also include this model in the patches, so I have a hope of having the speakers start working?

I do apologise in advance,

Mvh, Niclas
 
 

RE: [PATCH v1 0/7] Add support for various laptops using CS35L41 HDA without _DSD

[Niclas Söderlund]

Hi,

amazingly high level of laymanship here and equally high level of dispear.
But model after model is added to fix the problem with speakers not
working, but nowhere is my model seen. I have the Lenovo 13X G2 model and
even at kernel 6.8.7 my speakers still doesnt work.

Where can I add a request to also include this model in the patches, so I
have a hope of having the speakers start working?

I do apologise in advance,

Mvh, Niclas

Re: [PATCH v1 0/7] Add support for various laptops using CS35L41 HDA without _DSD

[Niclas Söderlund]

Hi,

amazingly high level of laymanship here and equally high level of dispear. But model after model is added to fix the problem with speakers not working, but nowhere is my model seen. I have the Lenovo 13X G2 model and even at kernel 6.8.7 my speakers still doesnt work.

Where can I add a request to also include this model in the patches, so I have a hope of having the speakers start working?

I do apologise in advance,


Mvh, Niclas

Re: [PATCH v1 0/7] Add support for various laptops using CS35L41 HDA without _DSD

[Takashi Iwai]

On Mon, 18 Dec 2023 16:12:14 +0100,
Stefan Binding wrote:
> 
> The CS35L41 HDA driver requires various system defined properties to configure
> the driver for an individual system. For some laptops, these properties are
> missing in the BIOS. To be able to support these laptops, there is a mechanism
> in the driver to get this configuration from a lookup table, to be able to add
> or patch _DSD as necessary.
> 
> However this mechanism currently only allows for laptops to be patched one at
> a time, however, in the case where there are many laptops which need to be
> configured generically, a generic function has been added, with an additional
> lookup table to the individual laptops, indexed by SSID.
> 
> To support laptops using SPI without _DSD, an additional workaround is needed
> to be able to support the SPI Chip Select GPIOs whose resources are defined
> inside the _CRS for the Speaker ACPI Node. This workaround only works for
> SPI laptops which contain up to 2 amps, since the SPI controller would not
> allow more than 2 amps to be instantiated without the cs-gpios entry in
> _DSD.
> 
> These patches add support for various ASUS laptops without _DSD, but the
> framework added here allows for support for more laptops in the future
> for other manufacturers. Support for laptops without _DSD from other
> manufacturers is coming in the future.
> 
> Note: for systems which use modified _DSD to emulate the missing _DSD,
> these patches are incompatible, and the modified _DSD must be removed in
> order for the support through this framework to work for those laptops.
> 
> Stefan Binding (7):
>   ALSA: hda: cs35l41: Add config table to support many laptops without
>     _DSD
>   ALSA: hda: cs35l41: Support additional ASUS ROG 2023 models
>   ALSA: hda/realtek: Add quirks for ASUS ROG 2023 models
>   ALSA: hda: cs35l41: Support additional ASUS Zenbook 2022 Models
>   ALSA: hda/realtek: Add quirks for ASUS Zenbook 2022 Models
>   ALSA: hda: cs35l41: Support additional ASUS Zenbook 2023 Models
>   ALSA: hda/realtek: Add quirks for ASUS Zenbook 2023 Models

Applied all seven patches now.  Thanks.


Takashi

[PATCH v1 0/7] Add support for various laptops using CS35L41 HDA without _DSD

[Stefan Binding]

The CS35L41 HDA driver requires various system defined properties to configure
the driver for an individual system. For some laptops, these properties are
missing in the BIOS. To be able to support these laptops, there is a mechanism
in the driver to get this configuration from a lookup table, to be able to add
or patch _DSD as necessary.

However this mechanism currently only allows for laptops to be patched one at
a time, however, in the case where there are many laptops which need to be
configured generically, a generic function has been added, with an additional
lookup table to the individual laptops, indexed by SSID.

To support laptops using SPI without _DSD, an additional workaround is needed
to be able to support the SPI Chip Select GPIOs whose resources are defined
inside the _CRS for the Speaker ACPI Node. This workaround only works for
SPI laptops which contain up to 2 amps, since the SPI controller would not
allow more than 2 amps to be instantiated without the cs-gpios entry in
_DSD.

These patches add support for various ASUS laptops without _DSD, but the
framework added here allows for support for more laptops in the future
for other manufacturers. Support for laptops without _DSD from other
manufacturers is coming in the future.

Note: for systems which use modified _DSD to emulate the missing _DSD,
these patches are incompatible, and the modified _DSD must be removed in
order for the support through this framework to work for those laptops.

Stefan Binding (7):
  ALSA: hda: cs35l41: Add config table to support many laptops without
    _DSD
  ALSA: hda: cs35l41: Support additional ASUS ROG 2023 models
  ALSA: hda/realtek: Add quirks for ASUS ROG 2023 models
  ALSA: hda: cs35l41: Support additional ASUS Zenbook 2022 Models
  ALSA: hda/realtek: Add quirks for ASUS Zenbook 2022 Models
  ALSA: hda: cs35l41: Support additional ASUS Zenbook 2023 Models
  ALSA: hda/realtek: Add quirks for ASUS Zenbook 2023 Models

 sound/pci/hda/cs35l41_hda.c          |   2 +
 sound/pci/hda/cs35l41_hda.h          |   5 +-
 sound/pci/hda/cs35l41_hda_property.c | 362 ++++++++++++++++++++++++---
 sound/pci/hda/patch_realtek.c        |  39 ++-
 4 files changed, 353 insertions(+), 55 deletions(-)

-- 
2.34.1