* [alsa-devel] Add quirk for Lenovo X1 Yoga
@ 2020-01-08 9:19 Kailang
2020-01-08 9:29 ` Jaroslav Kysela
0 siblings, 1 reply; 5+ messages in thread
From: Kailang @ 2020-01-08 9:19 UTC (permalink / raw)
To: Takashi Iwai (tiwai@suse.de); +Cc: (alsa-devel@alsa-project.org)
[-- Attachment #1: Type: text/plain, Size: 69 bytes --]
Hi Takashi,
Attach patch was for Lenovo X1 Yoga.
BR,
Kailang
[-- Attachment #2: 0000-lenovo-x1-yoga.patch --]
[-- Type: application/octet-stream, Size: 1282 bytes --]
From 1b86a9969efc59bf5535b22ae633942c872f4732 Mon Sep 17 00:00:00 2001
From: Kailang Yang <kailang@realtek.com>
Date: Wed, 8 Jan 2020 16:47:56 +0800
Subject: [PATCH] ALSA: hda/realtek - Add quirk for the bass speaker on Lenovo Yoga
X1 7th gen
Add quirk to ALC285_FIXUP_SPEAKER2_TO_DAC1.
Fixes: d2cd795c4ece ("ALSA: hda - fixup for the bass speaker on Lenovo Carbon X1 7th gen")
Signed-off-by: Kailang Yang <kailang@realtek.com>
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 73407b25a777..a008d85a4ea9 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -7267,6 +7267,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x17aa, 0x224c, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
SND_PCI_QUIRK(0x17aa, 0x224d, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
SND_PCI_QUIRK(0x17aa, 0x225d, "Thinkpad T480", ALC269_FIXUP_LIMIT_INT_MIC_BOOST),
+ SND_PCI_QUIRK(0x17aa, 0x2292, "Thinkpad X1 Yoga 7th", ALC285_FIXUP_SPEAKER2_TO_DAC1),
SND_PCI_QUIRK(0x17aa, 0x2293, "Thinkpad X1 Carbon 7th", ALC285_FIXUP_SPEAKER2_TO_DAC1),
SND_PCI_QUIRK(0x17aa, 0x30bb, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),
SND_PCI_QUIRK(0x17aa, 0x30e2, "ThinkCentre AIO", ALC233_FIXUP_LENOVO_LINE2_MIC_HOTKEY),
[-- Attachment #3: Type: text/plain, Size: 161 bytes --]
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [alsa-devel] Add quirk for Lenovo X1 Yoga
2020-01-08 9:19 [alsa-devel] Add quirk for Lenovo X1 Yoga Kailang
@ 2020-01-08 9:29 ` Jaroslav Kysela
2020-01-08 9:37 ` Kailang
2020-01-08 9:47 ` Takashi Iwai
0 siblings, 2 replies; 5+ messages in thread
From: Jaroslav Kysela @ 2020-01-08 9:29 UTC (permalink / raw)
To: Kailang, Takashi Iwai (tiwai@suse.de); +Cc: (alsa-devel@alsa-project.org)
Dne 08. 01. 20 v 10:19 Kailang napsal(a):
> Hi Takashi,
>
> Attach patch was for Lenovo X1 Yoga.
Remove the 'Fixes:' line. It's the different device. Otherwise:
Reviewed-by: Jaroslav Kysela <perex@perex.cz>
>
> BR,
> Kailang
>
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
--
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [alsa-devel] Add quirk for Lenovo X1 Yoga
2020-01-08 9:29 ` Jaroslav Kysela
@ 2020-01-08 9:37 ` Kailang
2020-01-08 9:49 ` Jaroslav Kysela
2020-01-08 9:47 ` Takashi Iwai
1 sibling, 1 reply; 5+ messages in thread
From: Kailang @ 2020-01-08 9:37 UTC (permalink / raw)
To: Jaroslav Kysela, Takashi Iwai (tiwai@suse.de)
Cc: (alsa-devel@alsa-project.org)
Hi Jaroslav,
Had Your Redhat kernel implement the Intel SOF driver?
PCH Dmic need to enable by SOF driver.
If it had SOF driver, it doesn't need to apply this patch.
SOF could via UCM to control bass speaker volume.
BR,
Kailang
> -----Original Message-----
> From: Jaroslav Kysela <perex@perex.cz>
> Sent: Wednesday, January 8, 2020 5:30 PM
> To: Kailang <kailang@realtek.com>; Takashi Iwai (tiwai@suse.de)
> <tiwai@suse.de>
> Cc: (alsa-devel@alsa-project.org) <alsa-devel@alsa-project.org>
> Subject: Re: [alsa-devel] Add quirk for Lenovo X1 Yoga
>
> Dne 08. 01. 20 v 10:19 Kailang napsal(a):
> > Hi Takashi,
> >
> > Attach patch was for Lenovo X1 Yoga.
>
> Remove the 'Fixes:' line. It's the different device. Otherwise:
>
> Reviewed-by: Jaroslav Kysela <perex@perex.cz>
>
> >
> > BR,
> > Kailang
> >
> >
> > _______________________________________________
> > Alsa-devel mailing list
> > Alsa-devel@alsa-project.org
> > https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> >
>
>
> --
> Jaroslav Kysela <perex@perex.cz>
> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
>
> ------Please consider the environment before printing this e-mail.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [alsa-devel] Add quirk for Lenovo X1 Yoga
2020-01-08 9:29 ` Jaroslav Kysela
2020-01-08 9:37 ` Kailang
@ 2020-01-08 9:47 ` Takashi Iwai
1 sibling, 0 replies; 5+ messages in thread
From: Takashi Iwai @ 2020-01-08 9:47 UTC (permalink / raw)
To: Jaroslav Kysela; +Cc: (alsa-devel@alsa-project.org), Kailang
On Wed, 08 Jan 2020 10:29:53 +0100,
Jaroslav Kysela wrote:
>
> Dne 08. 01. 20 v 10:19 Kailang napsal(a):
> > Hi Takashi,
> >
> > Attach patch was for Lenovo X1 Yoga.
>
> Remove the 'Fixes:' line. It's the different device. Otherwise:
>
> Reviewed-by: Jaroslav Kysela <perex@perex.cz>
OK, I updated the description and removed the fixes tag.
Now applied.
thanks,
Takashi
>
> >
> > BR,
> > Kailang
> >
> >
> > _______________________________________________
> > Alsa-devel mailing list
> > Alsa-devel@alsa-project.org
> > https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
> >
>
>
> --
> Jaroslav Kysela <perex@perex.cz>
> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [alsa-devel] Add quirk for Lenovo X1 Yoga
2020-01-08 9:37 ` Kailang
@ 2020-01-08 9:49 ` Jaroslav Kysela
0 siblings, 0 replies; 5+ messages in thread
From: Jaroslav Kysela @ 2020-01-08 9:49 UTC (permalink / raw)
To: Kailang, Takashi Iwai (tiwai@suse.de); +Cc: (alsa-devel@alsa-project.org)
Dne 08. 01. 20 v 10:37 Kailang napsal(a):
> Hi Jaroslav,
>
> Had Your Redhat kernel implement the Intel SOF driver?
> PCH Dmic need to enable by SOF driver.
> If it had SOF driver, it doesn't need to apply this patch.
> SOF could via UCM to control bass speaker volume.
Hi,
It's not correct. Those platforms have 4 speakers and we need to route the
stereo stream to all of them. The SOF driver uses the same HDA codec driver as
the HDA legacy driver (snd-hda-intel), so the situation is similar. UCM just
controls, if the second pair speakers is activated or not.
So, we need this for both legacy and SOF, otherwise the "bass" speakers will
be routed from another HDA DAC.
Jaroslav
>
> BR,
> Kailang
>
>> -----Original Message-----
>> From: Jaroslav Kysela <perex@perex.cz>
>> Sent: Wednesday, January 8, 2020 5:30 PM
>> To: Kailang <kailang@realtek.com>; Takashi Iwai (tiwai@suse.de)
>> <tiwai@suse.de>
>> Cc: (alsa-devel@alsa-project.org) <alsa-devel@alsa-project.org>
>> Subject: Re: [alsa-devel] Add quirk for Lenovo X1 Yoga
>>
>> Dne 08. 01. 20 v 10:19 Kailang napsal(a):
>>> Hi Takashi,
>>>
>>> Attach patch was for Lenovo X1 Yoga.
>>
>> Remove the 'Fixes:' line. It's the different device. Otherwise:
>>
>> Reviewed-by: Jaroslav Kysela <perex@perex.cz>
>>
>>>
>>> BR,
>>> Kailang
>>>
>>>
>>> _______________________________________________
>>> Alsa-devel mailing list
>>> Alsa-devel@alsa-project.org
>>> https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>>>
>>
>>
>> --
>> Jaroslav Kysela <perex@perex.cz>
>> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
>>
>> ------Please consider the environment before printing this e-mail.
--
Jaroslav Kysela <perex@perex.cz>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-01-08 9:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-08 9:19 [alsa-devel] Add quirk for Lenovo X1 Yoga Kailang
2020-01-08 9:29 ` Jaroslav Kysela
2020-01-08 9:37 ` Kailang
2020-01-08 9:49 ` Jaroslav Kysela
2020-01-08 9:47 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).