[PATCH] backports: Update hwsim defconfig

[PATCH] backports: Update hwsim defconfig

[Mathy Vanhoef]

In the current hwsim config no rate control algorithm is enabled. This
means that, when using defconfig-hwsim, the mac80211_hwsim fails to load
with the following error:

	[  132.155183] ieee80211 phy0: Failed to select rate control algorithm
	[  132.155196] ieee80211 phy0: Failed to initialize rate control algorithm

Fix this by enabling rate control algorithms in the provided hwsim
config.

Experiments were also less reliable when WEXT was enabled. So this patch
also disables WEXT when using defconfig-hwsim to make the default more
reliable for users.

Signed-off-by: Mathy Vanhoef <Mathy.Vanhoef@kuleuven.be>
---
 backport/defconfigs/hwsim | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/backport/defconfigs/hwsim b/backport/defconfigs/hwsim
index 9d8006ea..9f054c79 100644
--- a/backport/defconfigs/hwsim
+++ b/backport/defconfigs/hwsim
@@ -1,11 +1,15 @@
 CPTCFG_CFG80211=m
 CPTCFG_CFG80211_DEFAULT_PS=y
 CPTCFG_CFG80211_DEBUGFS=y
-CPTCFG_CFG80211_WEXT=y
+CPTCFG_CFG80211_WEXT=n
 CPTCFG_MAC80211=m
+
 # CPTCFG_MAC80211_RC_PID is not set
-# CPTCFG_MAC80211_RC_MINSTREL is not set
-# CPTCFG_MAC80211_RC_DEFAULT_MINSTREL is not set
+CPTCFG_MAC80211_HAS_RC=y
+CPTCFG_MAC80211_RC_MINSTREL=y
+CPTCFG_MAC80211_RC_DEFAULT_MINSTREL=y
+CPTCFG_MAC80211_RC_DEFAULT="minstrel_ht"
+
 CPTCFG_MAC80211_DEBUGFS=y
 CPTCFG_MAC80211_MESSAGE_TRACING=y
 CPTCFG_WLAN=y
-- 
2.35.1

--
To unsubscribe from this list: send the line "unsubscribe backports" in

Re: [PATCH] backports: Update hwsim defconfig

[Johannes Berg]

> Experiments were also less reliable when WEXT was enabled. So this patch
> also disables WEXT when using defconfig-hwsim to make the default more
> reliable for users.

No objection. I thought we actually just disabled it completely in
backports, but perhaps that's an Intel defconfig too.


> -CPTCFG_CFG80211_WEXT=y
> +CPTCFG_CFG80211_WEXT=n

But does that even work? I thought it had to be like this:

>  # CPTCFG_MAC80211_RC_PID is not set
> 

johannes
--
To unsubscribe from this list: send the line "unsubscribe backports" in

Re: [PATCH] backports: Update hwsim defconfig

[Mathy Vanhoef]

> > -CPTCFG_CFG80211_WEXT=y
> > +CPTCFG_CFG80211_WEXT=n
>
> But does that even work? I thought it had to be like this:
>
> >  # CPTCFG_MAC80211_RC_PID is not set
> >

I think you're right, specifying "=n" is the wrong way.

Somehow doing that did disable WEXT for me, but that likely was
specific to my setup.
--
To unsubscribe from this list: send the line "unsubscribe backports" in