From: Sven Eckelmann <sven.eckelmann@open-mesh.com>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 2/3] batman-adv: Introduce packet type independent TVLV handler API
Date: Thu, 29 Sep 2016 18:05:29 +0200 [thread overview]
Message-ID: <3001776.TrYjlrxxJQ@sven-edge> (raw)
In-Reply-To: <20160920121245.593-3-linus.luessing@c0d3.blue>
[-- Attachment #1: Type: text/plain, Size: 999 bytes --]
On Dienstag, 20. September 2016 14:12:44 CEST Linus Lüssing wrote:
[...]
> +/**
> + * batadv_tvlv_ogm_unpack_ctx - unpack context received with a TVLV handler call
> + * @orig_node: An orig_node to pack
> + *
> + * This unpacks the context received within an OGM TVLV handler, here the
> + * orig_node the packet came from.
> + *
> + * Return: The orig_node the packet came from.
> + */
> +struct batadv_orig_node *batadv_tvlv_ogm_unpack_ctx(void *ctx)
> +{
> + return (struct batadv_orig_node *)ctx;
> +}
The function doesn't have a parameter orig_node but it is documented in the
kernel-doc block. Instead the ctx should be documented.
[...]
> /**
> + * batadv_tvlv_handler_unregister2 - unregister a tvlv handler
> + * @bat_priv: the bat priv with all the soft interface information
> + * @tvlv_type: packet type to unregistered for
> + * @tvlv_type: tvlv handler type to be unregistered
tvlv_type is documented twice - and differently.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2016-09-29 16:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 12:12 [B.A.T.M.A.N.] Broadcast Avoidances, Neighborhood Hash Linus Lüssing
2016-09-20 12:12 ` [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: Store and transmit own neighborhood hash Linus Lüssing
2016-09-20 13:01 ` Sven Eckelmann
2016-09-29 15:31 ` Sven Eckelmann
2016-10-06 1:55 ` Linus Lüssing
2016-10-06 3:03 ` Linus Lüssing
2016-10-06 15:41 ` Linus Lüssing
2016-09-29 16:05 ` Sven Eckelmann
2016-09-29 16:39 ` Sven Eckelmann
2016-09-20 12:12 ` [B.A.T.M.A.N.] [PATCH 2/3] batman-adv: Introduce packet type independent TVLV handler API Linus Lüssing
2016-09-29 16:05 ` Sven Eckelmann [this message]
2016-09-29 16:46 ` Sven Eckelmann
2016-09-20 12:12 ` [B.A.T.M.A.N.] [PATCH 3/3] batman-adv: Evaluate and use neighborhood hash TVLV Linus Lüssing
2016-09-29 15:48 ` Sven Eckelmann
2016-09-29 16:05 ` Sven Eckelmann
2016-09-29 16:55 ` Sven Eckelmann
2016-09-20 12:23 ` [B.A.T.M.A.N.] Broadcast Avoidances, Neighborhood Hash Linus Lüssing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3001776.TrYjlrxxJQ@sven-edge \
--to=sven.eckelmann@open-mesh.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).