From: Sven Eckelmann <sven.eckelmann@open-mesh.com>
To: b.a.t.m.a.n@lists.open-mesh.org
Subject: Re: [B.A.T.M.A.N.] [PATCH 3/3] batman-adv: Evaluate and use neighborhood hash TVLV
Date: Thu, 29 Sep 2016 18:55:21 +0200 [thread overview]
Message-ID: <4118077.YhDRDWzlPo@sven-edge> (raw)
In-Reply-To: <20160920121245.593-4-linus.luessing@c0d3.blue>
[-- Attachment #1: Type: text/plain, Size: 1621 bytes --]
On Dienstag, 20. September 2016 14:12:45 CEST Linus Lüssing wrote:
> diff --git a/net/batman-adv/bat_v.c b/net/batman-adv/bat_v.c
> index 762b34c..75a4147 100644
> --- a/net/batman-adv/bat_v.c
> +++ b/net/batman-adv/bat_v.c
[...]
> + hardif_neigh = batadv_v_elp_unpack_ctx(ctx);
> + if (WARN_ON(!hardif_neigh))
> + return NET_RX_DROP;
Please include linux/bug.h for WARN_ON.
> index ed5936c..69a9a94 100644
> --- a/net/batman-adv/bat_v_elp.h
> +++ b/net/batman-adv/bat_v_elp.h
[...]
> +bool batadv_v_elp_nhh_cmp(struct batadv_hardif_neigh_node *hardif_neigh);
> +bool batadv_v_elp_rx_ingress_bad(struct batadv_hardif_neigh_node *hardif_neigh);
> +bool batadv_v_elp_rx_egress_bad(struct batadv_hardif_neigh_node *hardif_neigh);
> +bool batadv_v_elp_tx_ingress_bad(struct batadv_hardif_neigh_node *hardif_neigh);
> +bool batadv_v_elp_tx_egress_bad(struct batadv_hardif_neigh_node *hardif_neigh);
> +bool batadv_v_elp_no_broadcast(struct batadv_hard_iface *if_outgoing,
> + struct batadv_hardif_neigh_node *hardif_neigh,
> + bool inverse_metric);
Please include linux/types.h for bool.
> diff --git a/net/batman-adv/bat_v_ogm.c b/net/batman-adv/bat_v_ogm.c
> index 606f899..147d746 100644
> --- a/net/batman-adv/bat_v_ogm.c
> +++ b/net/batman-adv/bat_v_ogm.c
> @@ -43,6 +43,7 @@
> #include "hard-interface.h"
> #include "hash.h"
> #include "log.h"
> +#include "bat_v_ogm.h"
> #include "originator.h"
> #include "packet.h"
> #include "routing.h"
Please remove this duplicate include. bat_v_ogm.h is the first include
in this file :)
Thanks,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2016-09-29 16:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 12:12 [B.A.T.M.A.N.] Broadcast Avoidances, Neighborhood Hash Linus Lüssing
2016-09-20 12:12 ` [B.A.T.M.A.N.] [PATCH 1/3] batman-adv: Store and transmit own neighborhood hash Linus Lüssing
2016-09-20 13:01 ` Sven Eckelmann
2016-09-29 15:31 ` Sven Eckelmann
2016-10-06 1:55 ` Linus Lüssing
2016-10-06 3:03 ` Linus Lüssing
2016-10-06 15:41 ` Linus Lüssing
2016-09-29 16:05 ` Sven Eckelmann
2016-09-29 16:39 ` Sven Eckelmann
2016-09-20 12:12 ` [B.A.T.M.A.N.] [PATCH 2/3] batman-adv: Introduce packet type independent TVLV handler API Linus Lüssing
2016-09-29 16:05 ` Sven Eckelmann
2016-09-29 16:46 ` Sven Eckelmann
2016-09-20 12:12 ` [B.A.T.M.A.N.] [PATCH 3/3] batman-adv: Evaluate and use neighborhood hash TVLV Linus Lüssing
2016-09-29 15:48 ` Sven Eckelmann
2016-09-29 16:05 ` Sven Eckelmann
2016-09-29 16:55 ` Sven Eckelmann [this message]
2016-09-20 12:23 ` [B.A.T.M.A.N.] Broadcast Avoidances, Neighborhood Hash Linus Lüssing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4118077.YhDRDWzlPo@sven-edge \
--to=sven.eckelmann@open-mesh.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).