From: Jiri Olsa <jolsa@redhat.com>
To: Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: "Jiri Olsa" <jolsa@kernel.org>,
"Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
netdev@vger.kernel.org, bpf@vger.kernel.org,
"Andrii Nakryiko" <andriin@fb.com>, "Yonghong Song" <yhs@fb.com>,
"Song Liu" <songliubraving@fb.com>,
"Martin KaFai Lau" <kafai@fb.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"David Miller" <davem@redhat.com>,
"Björn Töpel" <bjorn.topel@intel.com>,
"John Fastabend" <john.fastabend@gmail.com>,
"Jesper Dangaard Brouer" <hawk@kernel.org>
Subject: Re: [PATCH 00/14] bpf: Add trampoline and dispatcher to /proc/kallsyms
Date: Wed, 12 Feb 2020 11:46:47 +0100 [thread overview]
Message-ID: <20200212104647.GB183981@krava> (raw)
In-Reply-To: <20200211191347.GH3416@kernel.org>
On Tue, Feb 11, 2020 at 04:13:47PM -0300, Arnaldo Carvalho de Melo wrote:
> Em Sat, Feb 08, 2020 at 04:41:55PM +0100, Jiri Olsa escreveu:
> > hi,
> > this patchset adds trampoline and dispatcher objects
> > to be visible in /proc/kallsyms. The last patch also
> > adds sorting for all bpf objects in /proc/kallsyms.
>
> This will allow those to appear in profiles, right? That would be
yea, one would think so.. but as you saw in the other email
there are still some issues ;-)
> interesting to explicitely state, i.e. the _why_ of this patch, not just
> the _what_.
I guess another reason would be accountability of the kernel space,
so that everything with the symbol would appear in /proc/kallsyms
jirka
>
> Thanks,
>
> - Arnaldo
>
> > $ sudo cat /proc/kallsyms | tail -20
> > ...
> > ffffffffa050f000 t bpf_prog_5a2b06eab81b8f51 [bpf]
> > ffffffffa0511000 t bpf_prog_6deef7357e7b4530 [bpf]
> > ffffffffa0542000 t bpf_trampoline_13832 [bpf]
> > ffffffffa0548000 t bpf_prog_96f1b5bf4e4cc6dc_mutex_lock [bpf]
> > ffffffffa0572000 t bpf_prog_d1c63e29ad82c4ab_bpf_prog1 [bpf]
> > ffffffffa0585000 t bpf_prog_e314084d332a5338__dissect [bpf]
> > ffffffffa0587000 t bpf_prog_59785a79eac7e5d2_mutex_unlock [bpf]
> > ffffffffa0589000 t bpf_prog_d0db6e0cac050163_mutex_lock [bpf]
> > ffffffffa058d000 t bpf_prog_d8f047721e4d8321_bpf_prog2 [bpf]
> > ffffffffa05df000 t bpf_trampoline_25637 [bpf]
> > ffffffffa05e3000 t bpf_prog_d8f047721e4d8321_bpf_prog2 [bpf]
> > ffffffffa05e5000 t bpf_prog_3b185187f1855c4c [bpf]
> > ffffffffa05e7000 t bpf_prog_d8f047721e4d8321_bpf_prog2 [bpf]
> > ffffffffa05eb000 t bpf_prog_93cebb259dd5c4b2_do_sys_open [bpf]
> > ffffffffa0677000 t bpf_dispatcher_xdp [bpf]
> >
> > thanks,
> > jirka
> >
> >
> > ---
> > Björn Töpel (1):
> > bpf: Add bpf_trampoline_ name prefix for DECLARE_BPF_DISPATCHER
> >
> > Jiri Olsa (13):
> > x86/mm: Rename is_kernel_text to __is_kernel_text
> > bpf: Add struct bpf_ksym
> > bpf: Add name to struct bpf_ksym
> > bpf: Add lnode list node to struct bpf_ksym
> > bpf: Add bpf_kallsyms_tree tree
> > bpf: Move bpf_tree add/del from bpf_prog_ksym_node_add/del
> > bpf: Separate kallsyms add/del functions
> > bpf: Add bpf_ksym_add/del functions
> > bpf: Re-initialize lnode in bpf_ksym_del
> > bpf: Rename bpf_tree to bpf_progs_tree
> > bpf: Add trampolines to kallsyms
> > bpf: Add dispatchers to kallsyms
> > bpf: Sort bpf kallsyms symbols
> >
> > arch/x86/mm/init_32.c | 14 ++++++----
> > include/linux/bpf.h | 54 ++++++++++++++++++++++++++------------
> > include/linux/filter.h | 13 +++-------
> > kernel/bpf/core.c | 182 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------
> > kernel/bpf/dispatcher.c | 6 +++++
> > kernel/bpf/trampoline.c | 23 ++++++++++++++++
> > kernel/events/core.c | 4 +--
> > net/core/filter.c | 5 ++--
> > 8 files changed, 219 insertions(+), 82 deletions(-)
> >
>
> --
>
> - Arnaldo
>
prev parent reply other threads:[~2020-02-12 10:47 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-08 15:41 [PATCH 00/14] bpf: Add trampoline and dispatcher to /proc/kallsyms Jiri Olsa
2020-02-08 15:41 ` [PATCH 01/14] x86/mm: Rename is_kernel_text to __is_kernel_text Jiri Olsa
2020-02-08 15:41 ` [PATCH 02/14] bpf: Add bpf_trampoline_ name prefix for DECLARE_BPF_DISPATCHER Jiri Olsa
2020-02-08 15:41 ` [PATCH 03/14] bpf: Add struct bpf_ksym Jiri Olsa
2020-02-08 15:41 ` [PATCH 04/14] bpf: Add name to " Jiri Olsa
2020-02-08 15:42 ` [PATCH 05/14] bpf: Add lnode list node " Jiri Olsa
2020-02-08 15:42 ` [PATCH 06/14] bpf: Add bpf_kallsyms_tree tree Jiri Olsa
2020-02-11 18:21 ` Andrii Nakryiko
2020-02-12 10:49 ` Jiri Olsa
2020-02-08 15:42 ` [PATCH 07/14] bpf: Move bpf_tree add/del from bpf_prog_ksym_node_add/del Jiri Olsa
2020-02-08 15:42 ` [PATCH 08/14] bpf: Separate kallsyms add/del functions Jiri Olsa
2020-02-08 15:42 ` [PATCH 09/14] bpf: Add bpf_ksym_add/del functions Jiri Olsa
2020-02-08 15:42 ` [PATCH 10/14] bpf: Re-initialize lnode in bpf_ksym_del Jiri Olsa
2020-02-11 18:28 ` Andrii Nakryiko
2020-02-12 10:43 ` Jiri Olsa
2020-02-08 15:42 ` [PATCH 11/14] bpf: Rename bpf_tree to bpf_progs_tree Jiri Olsa
2020-02-08 15:42 ` [PATCH 12/14] bpf: Add trampolines to kallsyms Jiri Olsa
2020-02-11 18:51 ` Andrii Nakryiko
2020-02-12 11:10 ` Jiri Olsa
2020-02-12 16:33 ` Andrii Nakryiko
2020-02-12 22:58 ` Jiri Olsa
2020-02-12 23:02 ` Jiri Olsa
2020-02-08 15:42 ` [PATCH 13/14] bpf: Add dispatchers " Jiri Olsa
2020-02-11 19:03 ` Andrii Nakryiko
2020-02-12 10:52 ` Jiri Olsa
2020-02-08 15:42 ` [PATCH 14/14] bpf: Sort bpf kallsyms symbols Jiri Olsa
2020-02-11 19:12 ` Andrii Nakryiko
2020-02-10 15:51 ` [PATCH 00/14] bpf: Add trampoline and dispatcher to /proc/kallsyms Björn Töpel
2020-02-10 16:17 ` Jiri Olsa
2020-02-11 19:32 ` Arnaldo Carvalho de Melo
2020-02-12 11:13 ` Jiri Olsa
2020-02-12 13:31 ` Arnaldo Carvalho de Melo
2020-02-12 22:40 ` Jiri Olsa
2020-02-13 16:23 ` Jiri Olsa
2020-02-11 19:13 ` Arnaldo Carvalho de Melo
2020-02-12 10:46 ` Jiri Olsa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200212104647.GB183981@krava \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=andriin@fb.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@intel.com \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@redhat.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kafai@fb.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).