From: Hangbin Liu <liuhangbin@gmail.com>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: "Jesper Dangaard Brouer" <brouer@redhat.com>,
bpf@vger.kernel.org, netdev@vger.kernel.org,
"Jiri Benc" <jbenc@redhat.com>,
"Eelco Chaudron" <echaudro@redhat.com>,
ast@kernel.org, "Daniel Borkmann" <daniel@iogearbox.net>,
"Lorenzo Bianconi" <lorenzo.bianconi@redhat.com>,
"David Ahern" <dsahern@gmail.com>,
"Andrii Nakryiko" <andrii.nakryiko@gmail.com>,
"Alexei Starovoitov" <alexei.starovoitov@gmail.com>,
"John Fastabend" <john.fastabend@gmail.com>,
"Maciej Fijalkowski" <maciej.fijalkowski@intel.com>,
"Björn Töpel" <bjorn.topel@gmail.com>,
"Martin KaFai Lau" <kafai@fb.com>
Subject: Re: [PATCHv9 bpf-next 2/4] xdp: extend xdp_redirect_map with broadcast support
Date: Sat, 24 Apr 2021 21:55:28 +0800 [thread overview]
Message-ID: <20210424135528.GJ3465@Leo-laptop-t470s> (raw)
In-Reply-To: <87zgxoc8kg.fsf@toke.dk>
On Sat, Apr 24, 2021 at 11:53:35AM +0200, Toke Høiland-Jørgensen wrote:
> >> Hi Jesper,
> >>
> >> From the performance data, there is only a slightly impact. Do we still need
> >> to block the whole patch on this? Or if you have a better solution?
> >
> > I'm basically just asking you to add an unlikely() annotation:
>
> Maybe the maintainers could add this while applying, though? Or we could
> fix it in a follow-up? Hangbin has been respinning this series with very
> minor changes for a while now, so I can certainly emphasise with his
> reluctance to keep doing this. IMO it's way past time to merge this
> already... :/
Not sure if Daniel will do it. If it's already missed the merge window. I can
post a new version.
Thanks
Hangbin
next prev parent reply other threads:[~2021-04-24 13:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 7:14 [PATCHv9 bpf-next 0/4] xdp: extend xdp_redirect_map with broadcast support Hangbin Liu
2021-04-22 7:14 ` [PATCHv9 bpf-next 1/4] bpf: run devmap xdp_prog on flush instead of bulk enqueue Hangbin Liu
2021-04-22 7:14 ` [PATCHv9 bpf-next 2/4] xdp: extend xdp_redirect_map with broadcast support Hangbin Liu
2021-04-22 16:53 ` Jesper Dangaard Brouer
2021-04-22 18:02 ` Toke Høiland-Jørgensen
2021-04-23 16:54 ` Jesper Dangaard Brouer
2021-04-24 1:09 ` Hangbin Liu
2021-04-24 7:01 ` Jesper Dangaard Brouer
2021-04-24 9:53 ` Toke Høiland-Jørgensen
2021-04-24 13:55 ` Hangbin Liu [this message]
2021-04-26 6:01 ` Hangbin Liu
2021-04-26 9:23 ` Jesper Dangaard Brouer
2021-04-26 10:25 ` Hangbin Liu
2021-04-22 7:14 ` [PATCHv9 bpf-next 3/4] sample/bpf: add xdp_redirect_map_multi for redirect_map broadcast test Hangbin Liu
2021-04-22 7:14 ` [PATCHv9 bpf-next 4/4] selftests/bpf: add xdp_redirect_multi test Hangbin Liu
2021-04-26 9:28 ` Jesper Dangaard Brouer
2021-04-26 10:19 ` Hangbin Liu
2021-04-26 14:29 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210424135528.GJ3465@Leo-laptop-t470s \
--to=liuhangbin@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=dsahern@gmail.com \
--cc=echaudro@redhat.com \
--cc=jbenc@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=lorenzo.bianconi@redhat.com \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).