From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Hangbin Liu <liuhangbin@gmail.com>,
Jesper Dangaard Brouer <brouer@redhat.com>
Cc: bpf@vger.kernel.org, netdev@vger.kernel.org,
"Jiri Benc" <jbenc@redhat.com>,
"Eelco Chaudron" <echaudro@redhat.com>,
ast@kernel.org, "Daniel Borkmann" <daniel@iogearbox.net>,
"Lorenzo Bianconi" <lorenzo.bianconi@redhat.com>,
"David Ahern" <dsahern@gmail.com>,
"Andrii Nakryiko" <andrii.nakryiko@gmail.com>,
"Alexei Starovoitov" <alexei.starovoitov@gmail.com>,
"John Fastabend" <john.fastabend@gmail.com>,
"Maciej Fijalkowski" <maciej.fijalkowski@intel.com>,
"Björn Töpel" <bjorn.topel@gmail.com>,
"Martin KaFai Lau" <kafai@fb.com>
Subject: Re: [PATCHv9 bpf-next 4/4] selftests/bpf: add xdp_redirect_multi test
Date: Mon, 26 Apr 2021 16:29:33 +0200 [thread overview]
Message-ID: <878s55ce5u.fsf@toke.dk> (raw)
In-Reply-To: <20210426101940.GP3465@Leo-laptop-t470s>
Hangbin Liu <liuhangbin@gmail.com> writes:
> On Mon, Apr 26, 2021 at 11:28:32AM +0200, Jesper Dangaard Brouer wrote:
>> On Thu, 22 Apr 2021 15:14:54 +0800
>> Hangbin Liu <liuhangbin@gmail.com> wrote:
>>
>> > Add a bpf selftest for new helper xdp_redirect_map_multi(). In this
>> > test there are 3 forward groups and 1 exclude group. The test will
>> > redirect each interface's packets to all the interfaces in the forward
>> > group, and exclude the interface in exclude map.
>> >
>> > Two maps (DEVMAP, DEVMAP_HASH) and two xdp modes (generic, drive) will
>> > be tested. XDP egress program will also be tested by setting pkt src MAC
>> > to egress interface's MAC address.
>> >
>> > For more test details, you can find it in the test script. Here is
>> > the test result.
>> > ]# ./test_xdp_redirect_multi.sh
>>
>> Running this test takes a long time around 3 minutes.
>
> Yes, there are some sleeps, ping tests. Don't know if I missed
> anything, is there a time limit for the selftest?
Not formally, but we already get complaints about tests running too
long, and if you write a test that takes three minutes to run you all
but guarantee that no one is going to run it in practice... :)
You could play with things like decreasing the ping interval (with -i),
maybe running fewer of them, and getting rid of all those 'sleep'
statements to decrease the runtime...
-Toke
prev parent reply other threads:[~2021-04-26 14:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 7:14 [PATCHv9 bpf-next 0/4] xdp: extend xdp_redirect_map with broadcast support Hangbin Liu
2021-04-22 7:14 ` [PATCHv9 bpf-next 1/4] bpf: run devmap xdp_prog on flush instead of bulk enqueue Hangbin Liu
2021-04-22 7:14 ` [PATCHv9 bpf-next 2/4] xdp: extend xdp_redirect_map with broadcast support Hangbin Liu
2021-04-22 16:53 ` Jesper Dangaard Brouer
2021-04-22 18:02 ` Toke Høiland-Jørgensen
2021-04-23 16:54 ` Jesper Dangaard Brouer
2021-04-24 1:09 ` Hangbin Liu
2021-04-24 7:01 ` Jesper Dangaard Brouer
2021-04-24 9:53 ` Toke Høiland-Jørgensen
2021-04-24 13:55 ` Hangbin Liu
2021-04-26 6:01 ` Hangbin Liu
2021-04-26 9:23 ` Jesper Dangaard Brouer
2021-04-26 10:25 ` Hangbin Liu
2021-04-22 7:14 ` [PATCHv9 bpf-next 3/4] sample/bpf: add xdp_redirect_map_multi for redirect_map broadcast test Hangbin Liu
2021-04-22 7:14 ` [PATCHv9 bpf-next 4/4] selftests/bpf: add xdp_redirect_multi test Hangbin Liu
2021-04-26 9:28 ` Jesper Dangaard Brouer
2021-04-26 10:19 ` Hangbin Liu
2021-04-26 14:29 ` Toke Høiland-Jørgensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s55ce5u.fsf@toke.dk \
--to=toke@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@gmail.com \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=daniel@iogearbox.net \
--cc=dsahern@gmail.com \
--cc=echaudro@redhat.com \
--cc=jbenc@redhat.com \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=liuhangbin@gmail.com \
--cc=lorenzo.bianconi@redhat.com \
--cc=maciej.fijalkowski@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).