From: Jiri Benc <jbenc@redhat.com>
To: David Ahern <dsahern@gmail.com>
Cc: bpf@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
William Tu <u9012063@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next] seltests: bpf: test_tunnel: use ip neigh
Date: Tue, 21 Sep 2021 18:31:59 +0200 [thread overview]
Message-ID: <20210921183159.596a2662@redhat.com> (raw)
In-Reply-To: <2f9554d2-c9c7-5c37-7df0-d011d80d7460@gmail.com>
On Tue, 21 Sep 2021 09:23:06 -0600, David Ahern wrote:
> I realize you are just following suit with this change, but ip can
> change namespaces internally:
>
> ip -netns at_ns0 neigh add 10.1.1.200 lladdr 52:54:00:d9:02:00 dev $DEV_NS
>
> All of the 'ip netns exec ... ip ...' commands can be simplified.
I know and I don't like the superfluous exec, either. But that's
something for a different patch. As you said, I'm just following what's
already there. There's ton of different stuff that can be cleaned up in
this and other selftests, unfortunately.
Jiri
prev parent reply other threads:[~2021-09-21 16:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 14:59 [PATCH bpf-next] seltests: bpf: test_tunnel: use ip neigh Jiri Benc
2021-09-21 15:23 ` David Ahern
2021-09-21 16:31 ` Jiri Benc [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210921183159.596a2662@redhat.com \
--to=jbenc@redhat.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=u9012063@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).