From: David Ahern <dsahern@gmail.com>
To: Jiri Benc <jbenc@redhat.com>, bpf@vger.kernel.org
Cc: Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
William Tu <u9012063@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next] seltests: bpf: test_tunnel: use ip neigh
Date: Tue, 21 Sep 2021 09:23:06 -0600 [thread overview]
Message-ID: <2f9554d2-c9c7-5c37-7df0-d011d80d7460@gmail.com> (raw)
In-Reply-To: <40f24b9d3f0f53b5c44471b452f9a11f4d13b7af.1632236133.git.jbenc@redhat.com>
On 9/21/21 8:59 AM, Jiri Benc wrote:
> The 'arp' command is deprecated and is another dependency of the selftest.
> Just use 'ip neigh', the test depends on iproute2 already.
>
> Signed-off-by: Jiri Benc <jbenc@redhat.com>
> ---
> tools/testing/selftests/bpf/test_tunnel.sh | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/bpf/test_tunnel.sh b/tools/testing/selftests/bpf/test_tunnel.sh
> index 1ccbe804e8e1..ca1372924023 100755
> --- a/tools/testing/selftests/bpf/test_tunnel.sh
> +++ b/tools/testing/selftests/bpf/test_tunnel.sh
> @@ -168,14 +168,15 @@ add_vxlan_tunnel()
> ip netns exec at_ns0 \
> ip link set dev $DEV_NS address 52:54:00:d9:01:00 up
> ip netns exec at_ns0 ip addr add dev $DEV_NS 10.1.1.100/24
> - ip netns exec at_ns0 arp -s 10.1.1.200 52:54:00:d9:02:00
> + ip netns exec at_ns0 \
> + ip neigh add 10.1.1.200 lladdr 52:54:00:d9:02:00 dev $DEV_NS
I realize you are just following suit with this change, but ip can
change namespaces internally:
ip -netns at_ns0 neigh add 10.1.1.200 lladdr 52:54:00:d9:02:00 dev $DEV_NS
All of the 'ip netns exec ... ip ...' commands can be simplified.
> ip netns exec at_ns0 iptables -A OUTPUT -j MARK --set-mark 0x800FF
>
> # root namespace
> ip link add dev $DEV type $TYPE external gbp dstport 4789
> ip link set dev $DEV address 52:54:00:d9:02:00 up
> ip addr add dev $DEV 10.1.1.200/24
> - arp -s 10.1.1.100 52:54:00:d9:01:00
> + ip neigh add 10.1.1.100 lladdr 52:54:00:d9:01:00 dev $DEV
> }
>
> add_ip6vxlan_tunnel()
>
next prev parent reply other threads:[~2021-09-21 15:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 14:59 [PATCH bpf-next] seltests: bpf: test_tunnel: use ip neigh Jiri Benc
2021-09-21 15:23 ` David Ahern [this message]
2021-09-21 16:31 ` Jiri Benc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f9554d2-c9c7-5c37-7df0-d011d80d7460@gmail.com \
--to=dsahern@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jbenc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=u9012063@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).