* [PATCH] bpf/tests: Use struct_size()
@ 2023-05-31 4:32 Su Hui
2023-05-31 6:08 ` Yonghong Song
2023-05-31 11:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Su Hui @ 2023-05-31 4:32 UTC (permalink / raw)
To: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko,
Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa
Cc: bpf, linux-kernel, kernel-janitors, Su Hui
Use struct_size() instead of hand writing it.
This is less verbose and more informative.
Signed-off-by: Su Hui <suhui@nfschina.com>
---
lib/test_bpf.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/lib/test_bpf.c b/lib/test_bpf.c
index ade9ac672adb..fa0833410ac1 100644
--- a/lib/test_bpf.c
+++ b/lib/test_bpf.c
@@ -15056,8 +15056,7 @@ static __init int prepare_tail_call_tests(struct bpf_array **pprogs)
int which, err;
/* Allocate the table of programs to be used for tall calls */
- progs = kzalloc(sizeof(*progs) + (ntests + 1) * sizeof(progs->ptrs[0]),
- GFP_KERNEL);
+ progs = kzalloc(struct_size(progs, ptrs, ntests + 1), GFP_KERNEL);
if (!progs)
goto out_nomem;
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] bpf/tests: Use struct_size()
2023-05-31 4:32 [PATCH] bpf/tests: Use struct_size() Su Hui
@ 2023-05-31 6:08 ` Yonghong Song
2023-05-31 11:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Yonghong Song @ 2023-05-31 6:08 UTC (permalink / raw)
To: Su Hui, Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko,
Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
KP Singh, Stanislav Fomichev, Hao Luo, Jiri Olsa
Cc: bpf, linux-kernel, kernel-janitors
On 5/30/23 9:32 PM, Su Hui wrote:
> Use struct_size() instead of hand writing it.
> This is less verbose and more informative.
>
> Signed-off-by: Su Hui <suhui@nfschina.com>
Acked-by: Yonghong Song <yhs@fb.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] bpf/tests: Use struct_size()
2023-05-31 4:32 [PATCH] bpf/tests: Use struct_size() Su Hui
2023-05-31 6:08 ` Yonghong Song
@ 2023-05-31 11:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-05-31 11:10 UTC (permalink / raw)
To: Su Hui
Cc: ast, daniel, andrii, martin.lau, song, yhs, john.fastabend,
kpsingh, sdf, haoluo, jolsa, bpf, linux-kernel, kernel-janitors
Hello:
This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:
On Wed, 31 May 2023 12:32:51 +0800 you wrote:
> Use struct_size() instead of hand writing it.
> This is less verbose and more informative.
>
> Signed-off-by: Su Hui <suhui@nfschina.com>
> ---
> lib/test_bpf.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Here is the summary with links:
- bpf/tests: Use struct_size()
https://git.kernel.org/bpf/bpf-next/c/0d2da4b595d0
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-05-31 11:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-31 4:32 [PATCH] bpf/tests: Use struct_size() Su Hui
2023-05-31 6:08 ` Yonghong Song
2023-05-31 11:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).