From: Yafang Shao <laoar.shao@gmail.com>
To: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
martin.lau@linux.dev, song@kernel.org, yhs@fb.com,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@google.com,
haoluo@google.com, jolsa@kernel.org, quentin@isovalent.com
Cc: bpf@vger.kernel.org, Yafang Shao <laoar.shao@gmail.com>
Subject: [PATCH v2 bpf-next 00/11] bpf: Support ->fill_link_info for kprobe_multi and perf_event links
Date: Thu, 8 Jun 2023 10:35:12 +0000 [thread overview]
Message-ID: <20230608103523.102267-1-laoar.shao@gmail.com> (raw)
This patchset enhances the usability of kprobe_multi programs by introducing
support for ->fill_link_info. This allows users to easily determine the
probed functions associated with a kprobe_multi program. While
`bpftool perf show` already provides information about functions probed by
perf_event programs, supporting ->fill_link_info ensures consistent access to
this information across all bpf links.
In addition, this patch extends support to generic perf events, which are
currently not covered by `bpftool perf show`. While userspace is exposed to
only the perf type and config, other attributes such as sample_period and
sample_freq are disregarded.
To ensure accurate identification of probed functions, it is preferable to
expose the address directly rather than relying solely on the symbol name.
However, this implementation respects the kptr_restrict setting and avoids
exposing the address if it is not permitted.
v1->v2:
- Fix sparse warning (Stanislav, lkp@intel.com)
- Fix BPF CI build error
- Reuse kernel_syms_load() (Alexei)
- Print 'name' instead of 'func' (Alexei)
- Show whether the probe is retprobe or not (Andrii)
- Add comment for the meaning of perf_event name (Andrii)
- Add support for generic perf event
- Adhere to the kptr_restrict setting
RFC->v1:
- Use a single copy_to_user() instead (Jiri)
- Show also the symbol name in bpftool (Quentin, Alexei)
- Use calloc() instead of malloc() in bpftool (Quentin)
- Avoid having conditional entries in the JSON output (Quentin)
- Drop ->show_fdinfo (Alexei)
- Use __u64 instead of __aligned_u64 for the field addr (Alexei)
- Avoid the contradiction in perf_event name length (Alexei)
- Address a build warning reported by kernel test robot <lkp@intel.com>
Yafang Shao (11):
bpf: Support ->fill_link_info for kprobe_multi
bpftool: Add address filtering in kernel_syms_load()
bpftool: Show probed function in kprobe_multi link info
bpf: Protect probed address based on kptr_restrict setting
bpf: Clear the probe_addr for uprobe
bpf: Expose symbol addresses for precise identification
bpf: Add a common helper bpf_copy_to_user()
bpf: Support ->fill_link_info for perf_event
libbpf: Add perf event names
bpftool: Move get_prog_info() into do_show_link()
bpftool: Show probed function in perf_event link info
include/uapi/linux/bpf.h | 27 ++++
kernel/bpf/syscall.c | 132 +++++++++++++++--
kernel/trace/bpf_trace.c | 34 ++++-
kernel/trace/trace_kprobe.c | 6 +-
tools/bpf/bpftool/link.c | 299 +++++++++++++++++++++++++++++++++++---
tools/bpf/bpftool/prog.c | 6 +-
tools/bpf/bpftool/xlated_dumper.c | 72 +++++++--
tools/bpf/bpftool/xlated_dumper.h | 3 +-
tools/include/uapi/linux/bpf.h | 27 ++++
tools/lib/bpf/libbpf.c | 107 ++++++++++++++
tools/lib/bpf/libbpf.h | 56 +++++++
tools/lib/bpf/libbpf.map | 6 +
12 files changed, 719 insertions(+), 56 deletions(-)
--
1.8.3.1
next reply other threads:[~2023-06-08 10:35 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 10:35 Yafang Shao [this message]
2023-06-08 10:35 ` [PATCH v2 bpf-next 01/11] bpf: Support ->fill_link_info for kprobe_multi Yafang Shao
2023-06-08 23:05 ` Andrii Nakryiko
2023-06-09 9:13 ` Yafang Shao
2023-06-09 18:25 ` Andrii Nakryiko
2023-06-10 2:19 ` Yafang Shao
2023-06-08 10:35 ` [PATCH v2 bpf-next 02/11] bpftool: Add address filtering in kernel_syms_load() Yafang Shao
2023-06-08 10:35 ` [PATCH v2 bpf-next 03/11] bpftool: Show probed function in kprobe_multi link info Yafang Shao
2023-06-08 23:08 ` Andrii Nakryiko
2023-06-09 9:15 ` Yafang Shao
2023-06-08 10:35 ` [PATCH v2 bpf-next 04/11] bpf: Protect probed address based on kptr_restrict setting Yafang Shao
2023-06-08 23:08 ` Andrii Nakryiko
2023-06-09 9:16 ` Yafang Shao
2023-06-08 10:35 ` [PATCH v2 bpf-next 05/11] bpf: Clear the probe_addr for uprobe Yafang Shao
2023-06-08 10:35 ` [PATCH v2 bpf-next 06/11] bpf: Expose symbol addresses for precise identification Yafang Shao
2023-06-08 10:35 ` [PATCH v2 bpf-next 07/11] bpf: Add a common helper bpf_copy_to_user() Yafang Shao
2023-06-08 10:35 ` [PATCH v2 bpf-next 08/11] bpf: Support ->fill_link_info for perf_event Yafang Shao
2023-06-08 23:12 ` Andrii Nakryiko
2023-06-09 9:53 ` Yafang Shao
2023-06-09 9:56 ` Yafang Shao
2023-06-09 18:26 ` Andrii Nakryiko
2023-06-10 2:21 ` Yafang Shao
2023-06-08 10:35 ` [PATCH v2 bpf-next 09/11] libbpf: Add perf event names Yafang Shao
2023-06-08 23:14 ` Andrii Nakryiko
2023-06-09 4:36 ` Song Liu
2023-06-10 2:22 ` Yafang Shao
2023-06-10 20:34 ` Quentin Monnet
2023-06-11 15:52 ` Yafang Shao
2023-06-10 22:37 ` Jiri Olsa
2023-06-10 22:43 ` Jiri Olsa
2023-06-11 15:55 ` Yafang Shao
2023-06-08 10:35 ` [PATCH v2 bpf-next 10/11] bpftool: Move get_prog_info() into do_show_link() Yafang Shao
2023-06-08 10:35 ` [PATCH v2 bpf-next 11/11] bpftool: Show probed function in perf_event link info Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230608103523.102267-1-laoar.shao@gmail.com \
--to=laoar.shao@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=martin.lau@linux.dev \
--cc=quentin@isovalent.com \
--cc=sdf@google.com \
--cc=song@kernel.org \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).