bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Quentin Monnet <quentin@isovalent.com>
To: Jiri Olsa <jolsa@kernel.org>, Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>
Cc: bpf@vger.kernel.org, Martin KaFai Lau <kafai@fb.com>,
	Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@chromium.org>,
	Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
	Yafang Shao <laoar.shao@gmail.com>
Subject: Re: [PATCH bpf-next 7/8] bpftool: Display cookie for perf event link probes
Date: Thu, 18 Jan 2024 17:51:10 +0000	[thread overview]
Message-ID: <56c6613d-8907-4582-9ce8-d08dcbb995af@isovalent.com> (raw)
In-Reply-To: <20240118095416.989152-8-jolsa@kernel.org>

2024-01-18 09:55 UTC+0000 ~ Jiri Olsa <jolsa@kernel.org>
> Displaying cookie for perf event link probes, in plain mode:
> 
>   # bpftool link
>   17: perf_event  prog 90
>           kprobe ffffffff82b1c2b0 bpf_fentry_test1  cookie 3735928559
>   18: perf_event  prog 90
>           kretprobe ffffffff82b1c2b0 bpf_fentry_test1  cookie 3735928559
>   20: perf_event  prog 92
>           tracepoint sched_switch  cookie 3735928559
>   21: perf_event  prog 93
>           event software:page-faults  cookie 3735928559
>   22: perf_event  prog 91
>           uprobe /proc/self/exe+0xd703c  cookie 3735928559
> 
> And in json mode:
> 
>   # bpftool link -j | jq
> 
>   {
>     "id": 30,
>     "type": "perf_event",
>     "prog_id": 160,
>     "retprobe": false,
>     "addr": 18446744071607272112,
>     "func": "bpf_fentry_test1",
>     "offset": 0,
>     "missed": 0,
>     "cookie": 3735928559
>   }
> 
>   {
>     "id": 33,
>     "type": "perf_event",
>     "prog_id": 162,
>     "tracepoint": "sched_switch",
>     "cookie": 3735928559
>   }
> 
>   {
>     "id": 34,
>     "type": "perf_event",
>     "prog_id": 163,
>     "event_type": "software",
>     "event_config": "page-faults",
>     "cookie": 3735928559
>   }
> 
>   {
>     "id": 35,
>     "type": "perf_event",
>     "prog_id": 161,
>     "retprobe": false,
>     "file": "/proc/self/exe",
>     "offset": 880700,
>     "cookie": 3735928559
>   }
> 
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>

Reviewed-by: Quentin Monnet <quentin@isovalent.com>

Thanks!

  reply	other threads:[~2024-01-18 17:51 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-18  9:54 [PATCH bpf-next 0/8] bpf: Add cookies retrieval for perf/kprobe multi links Jiri Olsa
2024-01-18  9:54 ` [PATCH bpf-next 1/8] bpf: Add cookie to perf_event bpf_link_info records Jiri Olsa
2024-01-18 12:24   ` Yafang Shao
2024-01-19  8:03     ` Jiri Olsa
2024-01-18  9:54 ` [PATCH bpf-next 2/8] bpf: Store cookies in kprobe_multi bpf_link_info data Jiri Olsa
2024-01-18 13:21   ` Yafang Shao
2024-01-18  9:54 ` [PATCH bpf-next 3/8] bpftool: Fix wrong free call in do_show_link Jiri Olsa
2024-01-18 12:29   ` Yafang Shao
2024-01-18 17:51     ` Quentin Monnet
2024-01-18  9:54 ` [PATCH bpf-next 4/8] selftests/bpf: Add cookies check for kprobe_multi fill_link_info test Jiri Olsa
2024-01-18  9:54 ` [PATCH bpf-next 5/8] selftests/bpf: Add cookies check for perf_event " Jiri Olsa
2024-01-18  9:54 ` [PATCH bpf-next 6/8] selftests/bpf: Add fill_link_info test for perf event Jiri Olsa
2024-01-18  9:54 ` [PATCH bpf-next 7/8] bpftool: Display cookie for perf event link probes Jiri Olsa
2024-01-18 17:51   ` Quentin Monnet [this message]
2024-01-18  9:54 ` [PATCH bpf-next 8/8] bpftool: Display cookie for kprobe multi link Jiri Olsa
2024-01-18 17:51   ` Quentin Monnet
2024-01-19  8:03     ` Jiri Olsa
2024-01-18 12:42 ` [PATCH bpf-next 0/8] bpf: Add cookies retrieval for perf/kprobe multi links Yafang Shao
2024-01-19  8:03   ` Jiri Olsa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56c6613d-8907-4582-9ce8-d08dcbb995af@isovalent.com \
    --to=quentin@isovalent.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=haoluo@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kafai@fb.com \
    --cc=kpsingh@chromium.org \
    --cc=laoar.shao@gmail.com \
    --cc=sdf@google.com \
    --cc=songliubraving@fb.com \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).