Re: [PATCH bpf-next 3/8] bpftool: Fix wrong free call in do_show_link

From: Yafang Shao <laoar.shao@gmail.com>
To: Jiri Olsa <jolsa@kernel.org>
Cc: Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	 Andrii Nakryiko <andrii@kernel.org>,
	bpf@vger.kernel.org, Martin KaFai Lau <kafai@fb.com>,
	 Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
	 John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@chromium.org>,
	 Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
	 Quentin Monnet <quentin@isovalent.com>
Subject: Re: [PATCH bpf-next 3/8] bpftool: Fix wrong free call in do_show_link
Date: Thu, 18 Jan 2024 20:29:42 +0800	[thread overview]
Message-ID: <CALOAHbAOJX01vb87FdRFC3Km7UDBVkJmDb9x1s-Yhb3hiWqfOQ@mail.gmail.com> (raw)
In-Reply-To: <20240118095416.989152-4-jolsa@kernel.org>

On Thu, Jan 18, 2024 at 5:55 PM Jiri Olsa <jolsa@kernel.org> wrote:
>
> The error path frees wrong array, it should be ref_ctr_offsets.
>
> Fixes: a7795698f8b6 ("bpftool: Add support to display uprobe_multi links")
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>

Acked-by: Yafang Shao <laoar.shao@gmail.com>

> ---
>  tools/bpf/bpftool/link.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/bpf/bpftool/link.c b/tools/bpf/bpftool/link.c
> index cb46667a6b2e..35b6859dd7c3 100644
> --- a/tools/bpf/bpftool/link.c
> +++ b/tools/bpf/bpftool/link.c
> @@ -977,7 +977,7 @@ static int do_show_link(int fd)
>                         cookies = calloc(count, sizeof(__u64));
>                         if (!cookies) {
>                                 p_err("mem alloc failed");
> -                               free(cookies);
> +                               free(ref_ctr_offsets);
>                                 free(offsets);
>                                 close(fd);
>                                 return -ENOMEM;
> --
> 2.43.0
>


-- 
Regards
Yafang