From: John Fastabend <john.fastabend@gmail.com>
To: Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net
Cc: andrii@kernel.org, kernel-team@fb.com
Subject: RE: [PATCH v2 bpf-next 0/4] libbpf: deprecate legacy BPF map definitions
Date: Tue, 25 Jan 2022 12:52:56 -0800 [thread overview]
Message-ID: <61f0632858dd3_2e4c520882@john.notmuch> (raw)
In-Reply-To: <20220120060529.1890907-1-andrii@kernel.org>
Andrii Nakryiko wrote:
> Officially deprecate legacy BPF map definitions in libbpf. They've been slated
> for deprecation for a while in favor of more powerful BTF-defined map
> definitions and this patch set adds warnings and a way to enforce this in
> libbpf through LIBBPF_STRICT_MAP_DEFINITIONS strict mode flag.
>
> Selftests are fixed up and updated, BPF documentation is updated, bpftool's
> strict mode usage is adjusted to avoid breaking users unnecessarily.
>
> v1->v2:
> - replace missed bpf_map_def case in Documentation/bpf/btf.rst (Alexei).
LGTM.
Acked-by: John Fastabend <john.fastabend@gmail.com>
>
> Andrii Nakryiko (4):
> selftests/bpf: fail build on compilation warning
> selftests/bpf: convert remaining legacy map definitions
> libbpf: deprecate legacy BPF map definitions
> docs/bpf: update BPF map definition example
>
> Documentation/bpf/btf.rst | 32 ++++++++-----------
> tools/bpf/bpftool/main.c | 9 +++++-
> tools/lib/bpf/bpf_helpers.h | 2 +-
> tools/lib/bpf/libbpf.c | 8 +++++
> tools/lib/bpf/libbpf_legacy.h | 5 +++
> tools/testing/selftests/bpf/Makefile | 4 +--
> tools/testing/selftests/bpf/prog_tests/btf.c | 4 +++
> .../bpf/progs/freplace_cls_redirect.c | 12 +++----
> .../selftests/bpf/progs/sample_map_ret0.c | 24 +++++++-------
> .../selftests/bpf/progs/test_btf_haskv.c | 3 ++
> .../selftests/bpf/progs/test_btf_newkv.c | 3 ++
> .../selftests/bpf/progs/test_btf_nokv.c | 12 +++----
> .../bpf/progs/test_skb_cgroup_id_kern.c | 12 +++----
> .../testing/selftests/bpf/progs/test_tc_edt.c | 12 +++----
> .../bpf/progs/test_tcp_check_syncookie_kern.c | 12 +++----
> 15 files changed, 90 insertions(+), 64 deletions(-)
>
> --
> 2.30.2
>
prev parent reply other threads:[~2022-01-25 20:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 6:05 [PATCH v2 bpf-next 0/4] libbpf: deprecate legacy BPF map definitions Andrii Nakryiko
2022-01-20 6:05 ` [PATCH v2 bpf-next 1/4] selftests/bpf: fail build on compilation warning Andrii Nakryiko
2022-01-20 6:05 ` [PATCH v2 bpf-next 2/4] selftests/bpf: convert remaining legacy map definitions Andrii Nakryiko
2022-01-20 6:05 ` [PATCH v2 bpf-next 3/4] libbpf: deprecate legacy BPF " Andrii Nakryiko
2022-01-20 11:44 ` Toke Høiland-Jørgensen
2022-01-20 19:13 ` Andrii Nakryiko
2022-01-21 20:43 ` Toke Høiland-Jørgensen
2022-01-21 22:04 ` David Ahern
2022-01-24 16:21 ` Andrii Nakryiko
2022-01-24 16:15 ` Andrii Nakryiko
2022-01-25 0:27 ` David Ahern
2022-01-25 5:41 ` Andrii Nakryiko
2022-01-25 12:10 ` Toke Høiland-Jørgensen
2022-01-25 20:52 ` John Fastabend
2022-01-25 21:52 ` Toke Høiland-Jørgensen
2022-01-25 22:35 ` John Fastabend
2022-01-26 0:01 ` Andrii Nakryiko
2022-01-26 2:02 ` David Ahern
2022-01-25 23:46 ` Andrii Nakryiko
2022-01-20 6:05 ` [PATCH v2 bpf-next 4/4] docs/bpf: update BPF map definition example Andrii Nakryiko
2022-01-25 20:52 ` John Fastabend [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61f0632858dd3_2e4c520882@john.notmuch \
--to=john.fastabend@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).