From: "Toke Høiland-Jørgensen" <toke@redhat.com>
To: Andrii Nakryiko <andrii@kernel.org>,
bpf@vger.kernel.org, ast@kernel.org, daniel@iogearbox.net
Cc: andrii@kernel.org, kernel-team@fb.com
Subject: Re: [PATCH v2 bpf-next 3/4] libbpf: deprecate legacy BPF map definitions
Date: Thu, 20 Jan 2022 12:44:35 +0100 [thread overview]
Message-ID: <87wniu7hss.fsf@toke.dk> (raw)
In-Reply-To: <20220120060529.1890907-4-andrii@kernel.org>
Andrii Nakryiko <andrii@kernel.org> writes:
> Enact deprecation of legacy BPF map definition in SEC("maps") ([0]). For
> the definitions themselves introduce LIBBPF_STRICT_MAP_DEFINITIONS flag
> for libbpf strict mode. If it is set, error out on any struct
> bpf_map_def-based map definition. If not set, libbpf will print out
> a warning for each legacy BPF map to raise awareness that it goes
> away.
We've touched upon this subject before, but I (still) don't think it's a
good idea to remove this support entirely: It makes it impossible to
write a loader that can handle both new and old BPF objects.
So discourage the use of the old map definitions, sure, but please don't
make it completely impossible to load such objects.
-Toke
next prev parent reply other threads:[~2022-01-20 11:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-20 6:05 [PATCH v2 bpf-next 0/4] libbpf: deprecate legacy BPF map definitions Andrii Nakryiko
2022-01-20 6:05 ` [PATCH v2 bpf-next 1/4] selftests/bpf: fail build on compilation warning Andrii Nakryiko
2022-01-20 6:05 ` [PATCH v2 bpf-next 2/4] selftests/bpf: convert remaining legacy map definitions Andrii Nakryiko
2022-01-20 6:05 ` [PATCH v2 bpf-next 3/4] libbpf: deprecate legacy BPF " Andrii Nakryiko
2022-01-20 11:44 ` Toke Høiland-Jørgensen [this message]
2022-01-20 19:13 ` Andrii Nakryiko
2022-01-21 20:43 ` Toke Høiland-Jørgensen
2022-01-21 22:04 ` David Ahern
2022-01-24 16:21 ` Andrii Nakryiko
2022-01-24 16:15 ` Andrii Nakryiko
2022-01-25 0:27 ` David Ahern
2022-01-25 5:41 ` Andrii Nakryiko
2022-01-25 12:10 ` Toke Høiland-Jørgensen
2022-01-25 20:52 ` John Fastabend
2022-01-25 21:52 ` Toke Høiland-Jørgensen
2022-01-25 22:35 ` John Fastabend
2022-01-26 0:01 ` Andrii Nakryiko
2022-01-26 2:02 ` David Ahern
2022-01-25 23:46 ` Andrii Nakryiko
2022-01-20 6:05 ` [PATCH v2 bpf-next 4/4] docs/bpf: update BPF map definition example Andrii Nakryiko
2022-01-25 20:52 ` [PATCH v2 bpf-next 0/4] libbpf: deprecate legacy BPF map definitions John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wniu7hss.fsf@toke.dk \
--to=toke@redhat.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).