Re: [PATCH] libbpf: Fix KERNEL_VERSION macro

* Re: [PATCH] libbpf: Fix KERNEL_VERSION macro
       [not found] <ME4P282MB1174C26FCD8E61817960F596C0789@ME4P282MB1174.AUSP282.PROD.OUTLOOK.COM>
@ 2021-04-05  0:16 ` Andrii Nakryiko
  0 siblings, 0 replies; only message in thread
From: Andrii Nakryiko @ 2021-04-05  0:16 UTC (permalink / raw)
  To: Hengqi Chen
  Cc: bpf, Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko,
	Martin KaFai Lau, Song Liu, Yonghong Song, John Fastabend,
	KP Singh, Networking, open list

On Sun, Apr 4, 2021 at 2:53 AM Hengqi Chen <chenhengqi@outlook.com> wrote:
>
> Add missing ')' for KERNEL_VERSION macro.
>
> Signed-off-by: Hengqi Chen <chenhengqi@outlook.com>
> ---

The fix looks good, thank you. But your patch didn't make it into
bpf/netdev patchworks instance ([0]) most probably due to too long CC
list. Can you please re-send with just maintainers and bpf@ and
netdev@ mailing lists in to/cc.

Also for bpf and bpf-next tree, we ask to specify the tree with [PATCH
bpf-next] prefix, so when re-submitting please adjust as well. Thanks.

  [0] https://patchwork.kernel.org/project/netdevbpf/list/

>  tools/lib/bpf/bpf_helpers.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/lib/bpf/bpf_helpers.h b/tools/lib/bpf/bpf_helpers.h
> index cc2e51c64a54..b904128626c2 100644
> --- a/tools/lib/bpf/bpf_helpers.h
> +++ b/tools/lib/bpf/bpf_helpers.h
> @@ -51,7 +51,7 @@
>  #endif
>
>  #ifndef KERNEL_VERSION
> -#define KERNEL_VERSION(a,b,c) (((a) << 16) + ((b) << 8) + ((c) > 255 ? 255 : (c))
> +#define KERNEL_VERSION(a, b, c) (((a) << 16) + ((b) << 8) + ((c) > 255 ? 255 : (c)))
>  #endif
>
>  /*
> --
> 2.25.1
>

^ permalink raw reply	[flat|nested] only message in thread