From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Song Liu <songliubraving@fb.com>
Cc: bpf <bpf@vger.kernel.org>, Networking <netdev@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Ziljstra <peterz@infradead.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
john fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>, Kernel Team <kernel-team@fb.com>,
Hao Luo <haoluo@google.com>
Subject: Re: [PATCH bpf-next 2/4] selftests/bpf: add non-BPF_LSM test for task local storage
Date: Mon, 11 Jan 2021 23:06:38 -0800 [thread overview]
Message-ID: <CAEf4BzbfiAx1QuNaDxcV0zX4wxOAOLUres61B7wf6SgZKa-E7w@mail.gmail.com> (raw)
In-Reply-To: <20210108231950.3844417-3-songliubraving@fb.com>
On Fri, Jan 8, 2021 at 3:30 PM Song Liu <songliubraving@fb.com> wrote:
>
> Task local storage is enabled for tracing programs. Add a test for it
> without CONFIG_BPF_LSM.
>
> Signed-off-by: Song Liu <songliubraving@fb.com>
> ---
> .../bpf/prog_tests/test_task_local_storage.c | 34 +++++++++++++++++
> .../selftests/bpf/progs/task_local_storage.c | 37 +++++++++++++++++++
> 2 files changed, 71 insertions(+)
> create mode 100644 tools/testing/selftests/bpf/prog_tests/test_task_local_storage.c
> create mode 100644 tools/testing/selftests/bpf/progs/task_local_storage.c
>
> diff --git a/tools/testing/selftests/bpf/prog_tests/test_task_local_storage.c b/tools/testing/selftests/bpf/prog_tests/test_task_local_storage.c
> new file mode 100644
> index 0000000000000..7de7a154ebbe6
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/prog_tests/test_task_local_storage.c
> @@ -0,0 +1,34 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/* Copyright (c) 2020 Facebook */
> +
> +#include <sys/types.h>
> +#include <unistd.h>
> +#include <test_progs.h>
> +#include "task_local_storage.skel.h"
> +
> +static unsigned int duration;
> +
> +void test_test_task_local_storage(void)
nit: let's not use "test_test_" tautology. It can be simply
test_task_local_storage() and this file itself should be called
task_local_storage.c.
> +{
> + struct task_local_storage *skel;
> + const int count = 10;
> + int i, err;
> +
> + skel = task_local_storage__open_and_load();
> +
> + if (CHECK(!skel, "skel_open_and_load", "skeleton open and load failed\n"))
btw, can you ASSERT_OK_PTR(skel, "skel_open_and_load"); and save
yourself a bunch of typing
> + return;
> +
> + err = task_local_storage__attach(skel);
> +
> + if (CHECK(err, "skel_attach", "skeleton attach failed\n"))
> + goto out;
similarly, ASSERT_OK(err, "skel_attach")
> +
> + for (i = 0; i < count; i++)
> + usleep(1000);
> + CHECK(skel->bss->value < count, "task_local_storage_value",
> + "task local value too small\n");
> +
> +out:
> + task_local_storage__destroy(skel);
> +}
[...]
prev parent reply other threads:[~2021-01-12 7:07 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210108231950.3844417-1-songliubraving@fb.com>
[not found] ` <20210108231950.3844417-2-songliubraving@fb.com>
2021-01-11 6:27 ` [PATCH bpf-next 1/4] bpf: enable task local storage for tracing programs Yonghong Song
2021-01-11 10:17 ` KP Singh
2021-01-11 15:56 ` Yonghong Song
2021-01-11 10:14 ` KP Singh
2021-01-11 23:16 ` Song Liu
2021-01-11 17:16 ` Yonghong Song
2021-01-11 18:56 ` Martin KaFai Lau
2021-01-11 21:35 ` KP Singh
2021-01-11 21:58 ` Martin KaFai Lau
2021-01-11 23:45 ` Song Liu
2021-01-12 16:32 ` Yonghong Song
2021-01-12 16:53 ` KP Singh
2021-01-15 23:34 ` Song Liu
2021-01-16 0:55 ` Yonghong Song
2021-01-16 1:12 ` Song Liu
2021-01-16 1:50 ` Yonghong Song
2021-01-11 23:41 ` Song Liu
2021-01-12 18:21 ` Martin KaFai Lau
[not found] ` <20210108231950.3844417-4-songliubraving@fb.com>
2021-01-11 17:37 ` [PATCH bpf-next 3/4] bpf: runqslower: prefer use local vmlinux Yonghong Song
[not found] ` <20210108231950.3844417-5-songliubraving@fb.com>
2021-01-11 17:49 ` [PATCH bpf-next 4/4] bpf: runqslower: use task local storage Yonghong Song
2021-01-11 22:54 ` Song Liu
2021-01-12 3:24 ` Yonghong Song
2021-01-12 7:14 ` Andrii Nakryiko
2021-01-12 7:33 ` Yonghong Song
[not found] ` <20210108231950.3844417-3-songliubraving@fb.com>
2021-01-11 17:30 ` [PATCH bpf-next 2/4] selftests/bpf: add non-BPF_LSM test for " Yonghong Song
2021-01-11 17:44 ` KP Singh
2021-01-11 22:50 ` Song Liu
2021-01-11 22:49 ` Song Liu
2021-01-12 7:06 ` Andrii Nakryiko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4BzbfiAx1QuNaDxcV0zX4wxOAOLUres61B7wf6SgZKa-E7w@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=john.fastabend@gmail.com \
--cc=kernel-team@fb.com \
--cc=kpsingh@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=songliubraving@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).