* [PATCH bpf] bpf: Fix oudated __bpf_skc_lookup() comment
@ 2022-07-29 19:45 Daniel Xu
2022-07-29 22:27 ` Andrii Nakryiko
0 siblings, 1 reply; 2+ messages in thread
From: Daniel Xu @ 2022-07-29 19:45 UTC (permalink / raw)
To: bpf, ast, daniel, andrii; +Cc: Daniel Xu, linux-kernel
The function returns a pointer now.
Fixes: edbf8c01de5a ("bpf: add skc_lookup_tcp helper")
Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
---
net/core/filter.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/net/core/filter.c b/net/core/filter.c
index 5d16d66727fc..866ca05f95e0 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -6463,8 +6463,6 @@ static struct sock *sk_lookup(struct net *net, struct bpf_sock_tuple *tuple,
/* bpf_skc_lookup performs the core lookup for different types of sockets,
* taking a reference on the socket if it doesn't have the flag SOCK_RCU_FREE.
- * Returns the socket as an 'unsigned long' to simplify the casting in the
- * callers to satisfy BPF_CALL declarations.
*/
static struct sock *
__bpf_skc_lookup(struct sk_buff *skb, struct bpf_sock_tuple *tuple, u32 len,
--
2.37.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH bpf] bpf: Fix oudated __bpf_skc_lookup() comment
2022-07-29 19:45 [PATCH bpf] bpf: Fix oudated __bpf_skc_lookup() comment Daniel Xu
@ 2022-07-29 22:27 ` Andrii Nakryiko
0 siblings, 0 replies; 2+ messages in thread
From: Andrii Nakryiko @ 2022-07-29 22:27 UTC (permalink / raw)
To: Daniel Xu
Cc: bpf, Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko, open list
On Fri, Jul 29, 2022 at 12:47 PM Daniel Xu <dxu@dxuuu.xyz> wrote:
>
> The function returns a pointer now.
>
> Fixes: edbf8c01de5a ("bpf: add skc_lookup_tcp helper")
> Signed-off-by: Daniel Xu <dxu@dxuuu.xyz>
> ---
This was already done in [0] in bpf-next.
[0] f5be22c64bd6 ("bpf: Fix bpf_skc_lookup comment wrt. return type")
> net/core/filter.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/net/core/filter.c b/net/core/filter.c
> index 5d16d66727fc..866ca05f95e0 100644
> --- a/net/core/filter.c
> +++ b/net/core/filter.c
> @@ -6463,8 +6463,6 @@ static struct sock *sk_lookup(struct net *net, struct bpf_sock_tuple *tuple,
>
> /* bpf_skc_lookup performs the core lookup for different types of sockets,
> * taking a reference on the socket if it doesn't have the flag SOCK_RCU_FREE.
> - * Returns the socket as an 'unsigned long' to simplify the casting in the
> - * callers to satisfy BPF_CALL declarations.
> */
> static struct sock *
> __bpf_skc_lookup(struct sk_buff *skb, struct bpf_sock_tuple *tuple, u32 len,
> --
> 2.37.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-29 22:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-29 19:45 [PATCH bpf] bpf: Fix oudated __bpf_skc_lookup() comment Daniel Xu
2022-07-29 22:27 ` Andrii Nakryiko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).