bpf.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH bpf-next] tools headers: Remove s390 ptrace.h in check-headers.sh
@ 2023-04-07  2:21 Tiezhu Yang
  2023-04-07 10:27 ` Jiri Olsa
  0 siblings, 1 reply; 4+ messages in thread
From: Tiezhu Yang @ 2023-04-07  2:21 UTC (permalink / raw)
  To: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko,
	Arnaldo Carvalho de Melo
  Cc: bpf, linux-perf-users, linux-kernel, loongson-kernel

After commit 1f265d2aea0d ("selftests/bpf: Remove not used headers"),
tools/arch/s390/include/uapi/asm/ptrace.h has been removed, so remove
it in check-headers.sh too, otherwise we can see the following build
warning:

  diff: tools/arch/s390/include/uapi/asm/ptrace.h: No such file or directory

Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202304050029.38NdbQPf-lkp@intel.com/
Fixes: 1f265d2aea0d ("selftests/bpf: Remove not used headers")
Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
---

commit 1f265d2aea0d ("selftests/bpf: Remove not used headers") is in
bpf-next tree, so I prefer this patch can be applied to bpf-next tree.

 tools/perf/check-headers.sh | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh
index eacca9a..e4a8b53 100755
--- a/tools/perf/check-headers.sh
+++ b/tools/perf/check-headers.sh
@@ -52,7 +52,6 @@ arch/x86/include/uapi/asm/vmx.h
 arch/powerpc/include/uapi/asm/kvm.h
 arch/s390/include/uapi/asm/kvm.h
 arch/s390/include/uapi/asm/kvm_perf.h
-arch/s390/include/uapi/asm/ptrace.h
 arch/s390/include/uapi/asm/sie.h
 arch/arm/include/uapi/asm/kvm.h
 arch/arm64/include/uapi/asm/kvm.h
-- 
2.1.0


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH bpf-next] tools headers: Remove s390 ptrace.h in check-headers.sh
  2023-04-07  2:21 [PATCH bpf-next] tools headers: Remove s390 ptrace.h in check-headers.sh Tiezhu Yang
@ 2023-04-07 10:27 ` Jiri Olsa
  2023-04-11 17:35   ` Daniel Borkmann
  0 siblings, 1 reply; 4+ messages in thread
From: Jiri Olsa @ 2023-04-07 10:27 UTC (permalink / raw)
  To: Tiezhu Yang
  Cc: Alexei Starovoitov, Daniel Borkmann, Andrii Nakryiko,
	Arnaldo Carvalho de Melo, bpf, linux-perf-users, linux-kernel,
	loongson-kernel

On Fri, Apr 07, 2023 at 10:21:30AM +0800, Tiezhu Yang wrote:
> After commit 1f265d2aea0d ("selftests/bpf: Remove not used headers"),
> tools/arch/s390/include/uapi/asm/ptrace.h has been removed, so remove
> it in check-headers.sh too, otherwise we can see the following build
> warning:
> 
>   diff: tools/arch/s390/include/uapi/asm/ptrace.h: No such file or directory
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Link: https://lore.kernel.org/oe-kbuild-all/202304050029.38NdbQPf-lkp@intel.com/
> Fixes: 1f265d2aea0d ("selftests/bpf: Remove not used headers")
> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>

not sure this should go through Arnaldo's tree instead,
either way is fine with me

Acked-by: Jiri Olsa <jolsa@kernel.org>

jirka

> ---
> 
> commit 1f265d2aea0d ("selftests/bpf: Remove not used headers") is in
> bpf-next tree, so I prefer this patch can be applied to bpf-next tree.
> 
>  tools/perf/check-headers.sh | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/perf/check-headers.sh b/tools/perf/check-headers.sh
> index eacca9a..e4a8b53 100755
> --- a/tools/perf/check-headers.sh
> +++ b/tools/perf/check-headers.sh
> @@ -52,7 +52,6 @@ arch/x86/include/uapi/asm/vmx.h
>  arch/powerpc/include/uapi/asm/kvm.h
>  arch/s390/include/uapi/asm/kvm.h
>  arch/s390/include/uapi/asm/kvm_perf.h
> -arch/s390/include/uapi/asm/ptrace.h
>  arch/s390/include/uapi/asm/sie.h
>  arch/arm/include/uapi/asm/kvm.h
>  arch/arm64/include/uapi/asm/kvm.h
> -- 
> 2.1.0
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH bpf-next] tools headers: Remove s390 ptrace.h in check-headers.sh
  2023-04-07 10:27 ` Jiri Olsa
@ 2023-04-11 17:35   ` Daniel Borkmann
  2023-04-12 13:33     ` Arnaldo Carvalho de Melo
  0 siblings, 1 reply; 4+ messages in thread
From: Daniel Borkmann @ 2023-04-11 17:35 UTC (permalink / raw)
  To: Jiri Olsa, Tiezhu Yang
  Cc: Alexei Starovoitov, Andrii Nakryiko, Arnaldo Carvalho de Melo,
	bpf, linux-perf-users, linux-kernel, loongson-kernel

On 4/7/23 12:27 PM, Jiri Olsa wrote:
> On Fri, Apr 07, 2023 at 10:21:30AM +0800, Tiezhu Yang wrote:
>> After commit 1f265d2aea0d ("selftests/bpf: Remove not used headers"),
>> tools/arch/s390/include/uapi/asm/ptrace.h has been removed, so remove
>> it in check-headers.sh too, otherwise we can see the following build
>> warning:
>>
>>    diff: tools/arch/s390/include/uapi/asm/ptrace.h: No such file or directory
>>
>> Reported-by: kernel test robot <lkp@intel.com>
>> Link: https://lore.kernel.org/oe-kbuild-all/202304050029.38NdbQPf-lkp@intel.com/
>> Fixes: 1f265d2aea0d ("selftests/bpf: Remove not used headers")
>> Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> 
> not sure this should go through Arnaldo's tree instead,
> either way is fine with me

Agree, perf tree is better given the script is located there, so:

Acked-by: Daniel Borkmann <daniel@iogearbox.net>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH bpf-next] tools headers: Remove s390 ptrace.h in check-headers.sh
  2023-04-11 17:35   ` Daniel Borkmann
@ 2023-04-12 13:33     ` Arnaldo Carvalho de Melo
  0 siblings, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2023-04-12 13:33 UTC (permalink / raw)
  To: Daniel Borkmann
  Cc: Jiri Olsa, Tiezhu Yang, Alexei Starovoitov, Andrii Nakryiko, bpf,
	linux-perf-users, linux-kernel, loongson-kernel

Em Tue, Apr 11, 2023 at 07:35:02PM +0200, Daniel Borkmann escreveu:
> On 4/7/23 12:27 PM, Jiri Olsa wrote:
> > On Fri, Apr 07, 2023 at 10:21:30AM +0800, Tiezhu Yang wrote:
> > > After commit 1f265d2aea0d ("selftests/bpf: Remove not used headers"),
> > > tools/arch/s390/include/uapi/asm/ptrace.h has been removed, so remove
> > > it in check-headers.sh too, otherwise we can see the following build
> > > warning:
> > > 
> > >    diff: tools/arch/s390/include/uapi/asm/ptrace.h: No such file or directory
> > > 
> > > Reported-by: kernel test robot <lkp@intel.com>
> > > Link: https://lore.kernel.org/oe-kbuild-all/202304050029.38NdbQPf-lkp@intel.com/
> > > Fixes: 1f265d2aea0d ("selftests/bpf: Remove not used headers")
> > > Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn>
> > 
> > not sure this should go through Arnaldo's tree instead,
> > either way is fine with me
> 
> Agree, perf tree is better given the script is located there, so:
> 
> Acked-by: Daniel Borkmann <daniel@iogearbox.net>

Thanks, applied.

- Arnaldo


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2023-04-12 13:34 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-04-07  2:21 [PATCH bpf-next] tools headers: Remove s390 ptrace.h in check-headers.sh Tiezhu Yang
2023-04-07 10:27 ` Jiri Olsa
2023-04-11 17:35   ` Daniel Borkmann
2023-04-12 13:33     ` Arnaldo Carvalho de Melo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).