[cip-dev] [PATCH 4.19.y-cip 0/3] Add WLAN/BT support

[cip-dev] [PATCH 4.19.y-cip 0/3] Add WLAN/BT support

[Biju Das]

This patch series add WLAN/BT support for HiHope RZ/G2M platform.

This patch series is based on linux-4.19.y-cip and all the patches
in this series are cherry-picked from linux rc tree.

Biju Das (3):
  arm64: dts: renesas: hihope-common: Add PCA9654 I/O expander
  arm64: dts: renesas: hihope-common: Add BT support
  arm64: dts: renesas: hihope-common: Add WLAN support

 arch/arm64/boot/dts/renesas/hihope-common.dtsi | 78 ++++++++++++++++++++++++++
 1 file changed, 78 insertions(+)

-- 
2.7.4

[cip-dev] [PATCH 4.19.y-cip 1/3] arm64: dts: renesas: hihope-common: Add PCA9654 I/O expander

[Biju Das]

commit cd3e43be14189542d8934faa94eff0392da32536 upstream.

Enable PCA9654 GPIO expander, so that we can configure its GPIOs later.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm64/boot/dts/renesas/hihope-common.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/hihope-common.dtsi b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
index 23fd022..a13cb88 100644
--- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
@@ -162,6 +162,13 @@
 	clock-frequency = <400000>;
 	status = "okay";
 
+	gpio_expander: gpio at 20 {
+		compatible = "onnn,pca9654";
+		reg = <0x20>;
+		gpio-controller;
+		#gpio-cells = <2>;
+	};
+
 	versaclock5: clock-generator at 6a {
 		compatible = "idt,5p49v5923";
 		reg = <0x6a>;
-- 
2.7.4

[cip-dev] [PATCH 4.19.y-cip 2/3] arm64: dts: renesas: hihope-common: Add BT support

[Biju Das]

commit d112c20925443b4a8876b101e5b7b13ef105057e upstream.

This patch enables BT support for the HiHope RZ/G2[MN] boards.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm64/boot/dts/renesas/hihope-common.dtsi | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/hihope-common.dtsi b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
index a13cb88..76f7a9a 100644
--- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
@@ -10,6 +10,7 @@
 / {
 	aliases {
 		serial0 = &scif2;
+		serial1 = &hscif0;
 	};
 
 	chosen {
@@ -31,6 +32,13 @@
 	leds {
 		compatible = "gpio-leds";
 
+		bt_active_led {
+			label = "blue:bt";
+			gpios = <&gpio7  0 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "hci0-power";
+			default-state = "off";
+		};
+
 		led0 {
 			gpios = <&gpio6 11 GPIO_ACTIVE_HIGH>;
 		};
@@ -153,6 +161,19 @@
 	};
 };
 
+&hscif0 {
+	pinctrl-0 = <&hscif0_pins>;
+	pinctrl-names = "default";
+
+	uart-has-rtscts;
+	status = "okay";
+
+	bluetooth {
+		compatible = "ti,wl1837-st";
+		enable-gpios = <&gpio_expander 2 GPIO_ACTIVE_HIGH>;
+	};
+};
+
 &hsusb {
 	dr_mode = "otg";
 	status = "okay";
@@ -194,6 +215,11 @@
 	pinctrl-0 = <&scif_clk_pins>;
 	pinctrl-names = "default";
 
+	hscif0_pins: hscif0 {
+		groups = "hscif0_data", "hscif0_ctrl";
+		function = "hscif0";
+	};
+
 	scif2_pins: scif2 {
 		groups = "scif2_data_a";
 		function = "scif2";
-- 
2.7.4

[cip-dev] [PATCH 4.19.y-cip 3/3] arm64: dts: renesas: hihope-common: Add WLAN support

[Biju Das]

commit 176f936a1e887a53d78f05248dc3c9bbd2c7f4c8 upstream.

This patch enables WLAN support for the HiHope RZ/G2[MN] boards.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm64/boot/dts/renesas/hihope-common.dtsi | 45 ++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/hihope-common.dtsi b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
index 76f7a9a..0daff2d 100644
--- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
@@ -54,6 +54,13 @@
 		led3 {
 			gpios = <&gpio0  0 GPIO_ACTIVE_HIGH>;
 		};
+
+		wlan_active_led {
+			label = "yellow:wlan";
+			gpios = <&gpio7  1 GPIO_ACTIVE_HIGH>;
+			linux,default-trigger = "phy0tx";
+			default-state = "off";
+		};
 	};
 
 	reg_1p8v: regulator0 {
@@ -98,6 +105,17 @@
 			  1800000 0>;
 	};
 
+	wlan_en_reg: regulator-wlan_en {
+		compatible = "regulator-fixed";
+		regulator-name = "wlan-en-regulator";
+		regulator-min-microvolt = <1800000>;
+		regulator-max-microvolt = <1800000>;
+		startup-delay-us = <70000>;
+
+		gpio = <&gpio_expander 1 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+	};
+
 	x302_clk: x302-clock {
 		compatible = "fixed-clock";
 		#clock-cells = <0>;
@@ -242,6 +260,12 @@
 		power-source = <1800>;
 	};
 
+	sdhi2_pins: sd2 {
+		groups = "sdhi2_data4", "sdhi2_ctrl";
+		function = "sdhi2";
+		power-source = <1800>;
+	};
+
 	sdhi3_pins: sd3 {
 		groups = "sdhi3_data8", "sdhi3_ctrl", "sdhi3_ds";
 		function = "sdhi3";
@@ -301,6 +325,27 @@
 	status = "okay";
 };
 
+&sdhi2 {
+	status = "okay";
+	pinctrl-0 = <&sdhi2_pins>;
+	pinctrl-names = "default";
+
+	vmmc-supply = <&wlan_en_reg>;
+	bus-width = <4>;
+	non-removable;
+	cap-power-off-card;
+	keep-power-in-suspend;
+
+	#address-cells = <1>;
+	#size-cells = <0>;
+	wlcore: wlcore at 2 {
+		compatible = "ti,wl1837";
+		reg = <2>;
+		interrupt-parent = <&gpio2>;
+		interrupts = <5 IRQ_TYPE_LEVEL_HIGH>;
+	};
+};
+
 &sdhi3 {
 	pinctrl-0 = <&sdhi3_pins>;
 	pinctrl-1 = <&sdhi3_pins>;
-- 
2.7.4

[cip-dev] [PATCH 4.19.y-cip 2/3] arm64: dts: renesas: hihope-common: Add BT support

[Pavel Machek]

Hi!

> commit d112c20925443b4a8876b101e5b7b13ef105057e upstream.
> 
> This patch enables BT support for the HiHope RZ/G2[MN] boards.

> +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> @@ -31,6 +32,13 @@
>  	leds {
>  		compatible = "gpio-leds";
>  
> +		bt_active_led {
> +			label = "blue:bt";

It would be good to change this to "blue:bluetooth", for consistency
with include/dt-bindings/leds/common.h . It will change names in the
sysfs.

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.cip-project.org/pipermail/cip-dev/attachments/20191010/0b1bbd64/attachment.sig>

[cip-dev] [PATCH 4.19.y-cip 0/3] Add WLAN/BT support

[Pavel Machek]

Hi!

> This patch series add WLAN/BT support for HiHope RZ/G2M platform.
> 
> This patch series is based on linux-4.19.y-cip and all the patches
> in this series are cherry-picked from linux rc tree.
> 
> Biju Das (3):
>   arm64: dts: renesas: hihope-common: Add PCA9654 I/O expander
>   arm64: dts: renesas: hihope-common: Add BT support
>   arm64: dts: renesas: hihope-common: Add WLAN support

Thank you, series looks good. (Comment about label probably should be
resolved in the mainline, first).

I can apply it unless Iwamatsu wants to do that?

Best regards,
								Pavel
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.cip-project.org/pipermail/cip-dev/attachments/20191010/a39c8273/attachment.sig>

[cip-dev] [PATCH 4.19.y-cip 2/3] arm64: dts: renesas: hihope-common: Add BT support

[Biju Das]

Hi Pavel,

Thanks for the feedback.

> -----Original Message-----
> From: Pavel Machek <pavel@denx.de>
> Sent: Thursday, October 10, 2019 8:38 AM
> To: Biju Das <biju.das@bp.renesas.com>
> Cc: cip-dev at lists.cip-project.org; Nobuhiro Iwamatsu
> <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek <pavel@denx.de>;
> Chris Paterson <Chris.Paterson2@renesas.com>; Fabrizio Castro
> <fabrizio.castro@bp.renesas.com>
> Subject: Re: [PATCH 4.19.y-cip 2/3] arm64: dts: renesas: hihope-common:
> Add BT support
> 
> Hi!
> 
> > commit d112c20925443b4a8876b101e5b7b13ef105057e upstream.
> >
> > This patch enables BT support for the HiHope RZ/G2[MN] boards.
> 
> > +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > @@ -31,6 +32,13 @@
> >  	leds {
> >  		compatible = "gpio-leds";
> >
> > +		bt_active_led {
> > +			label = "blue:bt";

As you mentioned, I agree we should fix this in mainline first and then backported to cip.

Cherrs,
Biju

> It would be good to change this to "blue:bluetooth", for consistency with
> include/dt-bindings/leds/common.h . It will change names in the sysfs.
> 
> Best regards,
> 								Pavel
> --
> DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

[cip-dev] [PATCH 4.19.y-cip 0/3] Add WLAN/BT support

[nobuhiro1.iwamatsu at toshiba.co.jp]

Hi all,

> -----Original Message-----
> From: Pavel Machek [mailto:pavel at denx.de]
> Sent: Thursday, October 10, 2019 4:43 PM
> To: Biju Das <biju.das@bp.renesas.com>
> Cc: cip-dev at lists.cip-project.org; iwamatsu nobuhiro(?? ?? ???
> ?????) <nobuhiro1.iwamatsu@toshiba.co.jp>; Pavel Machek
> <pavel@denx.de>; Chris Paterson <chris.paterson2@renesas.com>;
> Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Subject: Re: [PATCH 4.19.y-cip 0/3] Add WLAN/BT support
> 
> Hi!
> 
> > This patch series add WLAN/BT support for HiHope RZ/G2M platform.
> >
> > This patch series is based on linux-4.19.y-cip and all the patches in
> > this series are cherry-picked from linux rc tree.
> >
> > Biju Das (3):
> >   arm64: dts: renesas: hihope-common: Add PCA9654 I/O expander
> >   arm64: dts: renesas: hihope-common: Add BT support
> >   arm64: dts: renesas: hihope-common: Add WLAN support
> 
> Thank you, series looks good. (Comment about label probably should be
> resolved in the mainline, first).
> 

Looks good to me too.

> I can apply it unless Iwamatsu wants to do that?
> 

Please apply.

Best regards,
  Nobuhiro

[cip-dev] [PATCH 4.19.y-cip 2/3] arm64: dts: renesas: hihope-common: Add BT support

[Biju Das]

Hi Pavel,

Thanks for feedback.

> Subject: Re: [PATCH 4.19.y-cip 2/3] arm64: dts: renesas: hihope-common:
> Add BT support
> 
> Hi!
> 
> > commit d112c20925443b4a8876b101e5b7b13ef105057e upstream.
> >
> > This patch enables BT support for the HiHope RZ/G2[MN] boards.
> 
> > +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > @@ -31,6 +32,13 @@
> >  	leds {
> >  		compatible = "gpio-leds";
> >
> > +		bt_active_led {
> > +			label = "blue:bt";
> 
> It would be good to change this to "blue:bluetooth", for consistency with
> include/dt-bindings/leds/common.h . It will change names in the sysfs.

Can you please me point to the right file? There is nothing related to "blue:bluetooth",
Mentioned in include/dt-bindings/leds/common.h

Cheers,
Biju

[cip-dev] [PATCH 4.19.y-cip 0/3] Add WLAN/BT support

[Pavel Machek]

On Thu 2019-10-10 07:45:12, Biju Das wrote:
> This patch series add WLAN/BT support for HiHope RZ/G2M platform.
> 
> This patch series is based on linux-4.19.y-cip and all the patches
> in this series are cherry-picked from linux rc tree.

Thanks, applied.

Best regards,
								Pavel
									
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.cip-project.org/pipermail/cip-dev/attachments/20191013/d82daaa5/attachment.sig>