[cip-dev] [isar-cip-core][PATCH] ebg-secure-boot-secrets: Fix broken SRC_URI

[cip-dev] [isar-cip-core][PATCH] ebg-secure-boot-secrets: Fix broken SRC_URI

[Vijai Kumar K]

[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]

As per documentation, we need to copy the db and cert
to recipes-devtools/ebg-secure-boot-secrets/files.

SRC_URI expects file:// prefix for local files. Add that.

Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
---
 .../ebg-secure-boot-secrets/ebg-secure-boot-secrets_0.1.bb    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/recipes-devtools/ebg-secure-boot-secrets/ebg-secure-boot-secrets_0.1.bb b/recipes-devtools/ebg-secure-boot-secrets/ebg-secure-boot-secrets_0.1.bb
index 37b35c9..0d57910 100644
--- a/recipes-devtools/ebg-secure-boot-secrets/ebg-secure-boot-secrets_0.1.bb
+++ b/recipes-devtools/ebg-secure-boot-secrets/ebg-secure-boot-secrets_0.1.bb
@@ -29,8 +29,8 @@ DEBIAN_CONFLICTS = "ebg-secure-boot-snakeoil"
 SRC_URI = " \
     file://sign_secure_image.sh.tmpl \
     file://control.tmpl"
-SRC_URI_append = " ${@ d.getVar(SB_CERTDB) or "" }"
-SRC_URI_append = " ${@ d.getVar(SB_VERIFY_CERT) or "" }"
+SRC_URI_append = " ${@ "file://"+d.getVar('SB_CERTDB') if d.getVar('SB_CERTDB') else '' }"
+SRC_URI_append = " ${@ "file://"+d.getVar('SB_VERIFY_CERT') if d.getVar('SB_VERIFY_CERT') else '' }"
 TEMPLATE_FILES = "sign_secure_image.sh.tmpl"
 TEMPLATE_VARS += "SB_CERT_PATH SB_CERTDB SB_VERIFY_CERT SB_KEY_NAME"
 
-- 
2.17.1


[-- Attachment #2: Type: text/plain, Size: 420 bytes --]


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5938): https://lists.cip-project.org/g/cip-dev/message/5938
Mute This Topic: https://lists.cip-project.org/mt/78629989/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [cip-dev] [isar-cip-core][PATCH] ebg-secure-boot-secrets: Fix broken SRC_URI

[Jan Kiszka]

[-- Attachment #1: Type: text/plain, Size: 1463 bytes --]

On 01.12.20 08:49, Vijai Kumar K wrote:
> As per documentation, we need to copy the db and cert
> to recipes-devtools/ebg-secure-boot-secrets/files.
> 
> SRC_URI expects file:// prefix for local files. Add that.
> 
> Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
> ---
>  .../ebg-secure-boot-secrets/ebg-secure-boot-secrets_0.1.bb    | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/recipes-devtools/ebg-secure-boot-secrets/ebg-secure-boot-secrets_0.1.bb b/recipes-devtools/ebg-secure-boot-secrets/ebg-secure-boot-secrets_0.1.bb
> index 37b35c9..0d57910 100644
> --- a/recipes-devtools/ebg-secure-boot-secrets/ebg-secure-boot-secrets_0.1.bb
> +++ b/recipes-devtools/ebg-secure-boot-secrets/ebg-secure-boot-secrets_0.1.bb
> @@ -29,8 +29,8 @@ DEBIAN_CONFLICTS = "ebg-secure-boot-snakeoil"
>  SRC_URI = " \
>      file://sign_secure_image.sh.tmpl \
>      file://control.tmpl"
> -SRC_URI_append = " ${@ d.getVar(SB_CERTDB) or "" }"
> -SRC_URI_append = " ${@ d.getVar(SB_VERIFY_CERT) or "" }"
> +SRC_URI_append = " ${@ "file://"+d.getVar('SB_CERTDB') if d.getVar('SB_CERTDB') else '' }"
> +SRC_URI_append = " ${@ "file://"+d.getVar('SB_VERIFY_CERT') if d.getVar('SB_VERIFY_CERT') else '' }"
>  TEMPLATE_FILES = "sign_secure_image.sh.tmpl"
>  TEMPLATE_VARS += "SB_CERT_PATH SB_CERTDB SB_VERIFY_CERT SB_KEY_NAME"
>  
> 

Thanks, applied to next.

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux

[-- Attachment #2: Type: text/plain, Size: 420 bytes --]


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5931): https://lists.cip-project.org/g/cip-dev/message/5931
Mute This Topic: https://lists.cip-project.org/mt/78629989/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-

[cip-dev] [isar-cip-core][PATCH] ebg-secure-boot-secrets: Fix broken SRC_URI

[Kanagarajan, Vijaikumar]

[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]

As per documentation, we need to copy the db and cert
to recipes-devtools/ebg-secure-boot-secrets/files.

SRC_URI expects file:// prefix for local files. Add that.

Signed-off-by: Vijai Kumar K <Vijaikumar_Kanagarajan@mentor.com>
---
 .../ebg-secure-boot-secrets/ebg-secure-boot-secrets_0.1.bb    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/recipes-devtools/ebg-secure-boot-secrets/ebg-secure-boot-secrets_0.1.bb b/recipes-devtools/ebg-secure-boot-secrets/ebg-secure-boot-secrets_0.1.bb
index 37b35c9..0d57910 100644
--- a/recipes-devtools/ebg-secure-boot-secrets/ebg-secure-boot-secrets_0.1.bb
+++ b/recipes-devtools/ebg-secure-boot-secrets/ebg-secure-boot-secrets_0.1.bb
@@ -29,8 +29,8 @@ DEBIAN_CONFLICTS = "ebg-secure-boot-snakeoil"
 SRC_URI = " \
     file://sign_secure_image.sh.tmpl \
     file://control.tmpl"
-SRC_URI_append = " ${@ d.getVar(SB_CERTDB) or "" }"
-SRC_URI_append = " ${@ d.getVar(SB_VERIFY_CERT) or "" }"
+SRC_URI_append = " ${@ "file://"+d.getVar('SB_CERTDB') if d.getVar('SB_CERTDB') else '' }"
+SRC_URI_append = " ${@ "file://"+d.getVar('SB_VERIFY_CERT') if d.getVar('SB_VERIFY_CERT') else '' }"
 TEMPLATE_FILES = "sign_secure_image.sh.tmpl"
 TEMPLATE_VARS += "SB_CERT_PATH SB_CERTDB SB_VERIFY_CERT SB_KEY_NAME"
 
-- 
2.17.1


[-- Attachment #2: Type: text/plain, Size: 420 bytes --]


-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5930): https://lists.cip-project.org/g/cip-dev/message/5930
Mute This Topic: https://lists.cip-project.org/mt/78629989/4520388
Group Owner: cip-dev+owner@lists.cip-project.org
Unsubscribe: https://lists.cip-project.org/g/cip-dev/leave/8129055/727948398/xyzzy [cip-dev@archiver.kernel.org]
-=-=-=-=-=-=-=-=-=-=-=-