* [cip-dev] [PATCH] spi: pxa2xx: Fix build error because of missing header
@ 2018-09-18 4:10 Kazuhiro Hayashi
2018-09-18 4:25 ` HAYASHI Kazuhiro
0 siblings, 1 reply; 5+ messages in thread
From: Kazuhiro Hayashi @ 2018-09-18 4:10 UTC (permalink / raw)
To: cip-dev
From: Mika Westerberg <mika.westerberg@linux.intel.com>
commit 089bd46d8bc1fe5a28351e82e4adcaa5a40121b5 upstream.
Kbuild test robot reports:
drivers/spi/spi-pxa2xx.c: In function ?setup_cs?:
drivers/spi/spi-pxa2xx.c:1190:20: error: implicit declaration of function ?desc_to_gpio?
...
Reason for this is the fact that those functions are declared in
linux/gpio/consumer.h which is not included in the driver. Fix this by
including it.
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Kazuhiro Hayashi <kazuhiro3.hayashi@toshiba.co.jp>
---
drivers/spi/spi-pxa2xx.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
index 5e2ed7d..dd7b5b4 100644
--- a/drivers/spi/spi-pxa2xx.c
+++ b/drivers/spi/spi-pxa2xx.c
@@ -28,6 +28,7 @@
#include <linux/spi/spi.h>
#include <linux/delay.h>
#include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
#include <linux/slab.h>
#include <linux/clk.h>
#include <linux/pm_runtime.h>
--
2.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [cip-dev] [PATCH] spi: pxa2xx: Fix build error because of missing header
2018-09-18 4:10 [cip-dev] [PATCH] spi: pxa2xx: Fix build error because of missing header Kazuhiro Hayashi
@ 2018-09-18 4:25 ` HAYASHI Kazuhiro
2018-09-18 5:18 ` Jan Kiszka
0 siblings, 1 reply; 5+ messages in thread
From: HAYASHI Kazuhiro @ 2018-09-18 4:25 UTC (permalink / raw)
To: cip-dev
Hi,
On 2018/09/18 13:10, Kazuhiro Hayashi wrote:
> From: Mika Westerberg <mika.westerberg@linux.intel.com>
>
> commit 089bd46d8bc1fe5a28351e82e4adcaa5a40121b5 upstream.
>
> Kbuild test robot reports:
>
> drivers/spi/spi-pxa2xx.c: In function ?setup_cs?:
> drivers/spi/spi-pxa2xx.c:1190:20: error: implicit declaration of function ?desc_to_gpio?
> ...
I got the above error when I enabled pxa2xx by
CONFIG_SPI_PXA2XX_DMA=y
CONFIG_SPI_PXA2XX=y
CONFIG_SPI_PXA2XX_PCI=y
and confirmed that the patch fixes the issue.
Kernel version: 4.4.138-cip25-rt19
Architecture: x86_64
gcc: 4.9.2 (Debian 8)
This issue seems to be caused by 3d3bc507 in CIP (99f499cd in upstream) [1],
and the patch is already merged in the upstream.
https://git.kernel.org/pub/scm/linux/kernel/git/bwh/linux-cip.git/commit/?id=3d3bc50700ba7e7c370229f20f0b3ddafc1562cd
Please consider to apply the patch to 4.4-cip as well.
[1] https://lists.01.org/pipermail/kbuild-all/2016-September/025744.html
Regards,
Kazu
>
> Reason for this is the fact that those functions are declared in
> linux/gpio/consumer.h which is not included in the driver. Fix this by
> including it.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> Signed-off-by: Kazuhiro Hayashi <kazuhiro3.hayashi@toshiba.co.jp>
> ---
> drivers/spi/spi-pxa2xx.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
> index 5e2ed7d..dd7b5b4 100644
> --- a/drivers/spi/spi-pxa2xx.c
> +++ b/drivers/spi/spi-pxa2xx.c
> @@ -28,6 +28,7 @@
> #include <linux/spi/spi.h>
> #include <linux/delay.h>
> #include <linux/gpio.h>
> +#include <linux/gpio/consumer.h>
> #include <linux/slab.h>
> #include <linux/clk.h>
> #include <linux/pm_runtime.h>
>
--
Kazuhiro Hayashi
Corporate Software Engineering & Technology Center
Toshiba Corporation
Tel: +8144-549-2476
E-mail: kazuhiro3.hayashi at toshiba.co.jp
^ permalink raw reply [flat|nested] 5+ messages in thread
* [cip-dev] [PATCH] spi: pxa2xx: Fix build error because of missing header
2018-09-18 4:25 ` HAYASHI Kazuhiro
@ 2018-09-18 5:18 ` Jan Kiszka
2018-09-18 7:07 ` nobuhiro.iwamatsu at cybertrust.co.jp
0 siblings, 1 reply; 5+ messages in thread
From: Jan Kiszka @ 2018-09-18 5:18 UTC (permalink / raw)
To: cip-dev
On 18.09.18 06:25, HAYASHI Kazuhiro wrote:
> Hi,
>
> On 2018/09/18 13:10, Kazuhiro Hayashi wrote:
>> From: Mika Westerberg <mika.westerberg@linux.intel.com>
>>
>> commit 089bd46d8bc1fe5a28351e82e4adcaa5a40121b5 upstream.
>>
>> Kbuild test robot reports:
>>
>> ?? drivers/spi/spi-pxa2xx.c: In function ?setup_cs?:
>> ?? drivers/spi/spi-pxa2xx.c:1190:20: error: implicit declaration of function
>> ?desc_to_gpio?
>> ?? ...
> I got the above error when I enabled pxa2xx by
> CONFIG_SPI_PXA2XX_DMA=y
> CONFIG_SPI_PXA2XX=y
> CONFIG_SPI_PXA2XX_PCI=y
> and confirmed that the patch fixes the issue.
>
> Kernel version: 4.4.138-cip25-rt19
> Architecture: x86_64
> gcc: 4.9.2 (Debian 8)
>
> This issue seems to be caused by 3d3bc507 in CIP (99f499cd in upstream) [1],
> and the patch is already merged in the upstream.
> https://git.kernel.org/pub/scm/linux/kernel/git/bwh/linux-cip.git/commit/?id=3d3bc50700ba7e7c370229f20f0b3ddafc1562cd
>
> Please consider to apply the patch to 4.4-cip as well.
>
> [1] https://lists.01.org/pipermail/kbuild-all/2016-September/025744.html
We are building that config, and I just checked my last log for 138-cip25 -
nothing. Maybe it was surfaced by some change after that release.
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
^ permalink raw reply [flat|nested] 5+ messages in thread
* [cip-dev] [PATCH] spi: pxa2xx: Fix build error because of missing header
2018-09-18 5:18 ` Jan Kiszka
@ 2018-09-18 7:07 ` nobuhiro.iwamatsu at cybertrust.co.jp
2018-09-18 8:16 ` Kazuhiro Hayashi
0 siblings, 1 reply; 5+ messages in thread
From: nobuhiro.iwamatsu at cybertrust.co.jp @ 2018-09-18 7:07 UTC (permalink / raw)
To: cip-dev
Hi,
>> Please consider to apply the patch to 4.4-cip as well.
>>
>> [1] https://lists.01.org/pipermail/kbuild-all/2016-September/025744.html
>
> We are building that config, and I just checked my last log for 138-cip25 -
> nothing. Maybe it was surfaced by some change after that release.
I could confirm with x86, arm does not have this problem.
Best regards,
Nobuhiro
________________________________________
???: cip-dev-bounces at lists.cip-project.org <cip-dev-bounces@lists.cip-project.org> ? Jan Kiszka <jan.kiszka@siemens.com> ??????
????: 2018?9?18? 14:18
??: HAYASHI Kazuhiro; cip-dev at lists.cip-project.org
??: Re: [cip-dev] [PATCH] spi: pxa2xx: Fix build error because of missing header
On 18.09.18 06:25, HAYASHI Kazuhiro wrote:
> Hi,
>
> On 2018/09/18 13:10, Kazuhiro Hayashi wrote:
>> From: Mika Westerberg <mika.westerberg@linux.intel.com>
>>
>> commit 089bd46d8bc1fe5a28351e82e4adcaa5a40121b5 upstream.
>>
>> Kbuild test robot reports:
>>
>> drivers/spi/spi-pxa2xx.c: In function ?setup_cs?:
>> drivers/spi/spi-pxa2xx.c:1190:20: error: implicit declaration of function
>> ?desc_to_gpio?
>> ...
> I got the above error when I enabled pxa2xx by
> CONFIG_SPI_PXA2XX_DMA=y
> CONFIG_SPI_PXA2XX=y
> CONFIG_SPI_PXA2XX_PCI=y
> and confirmed that the patch fixes the issue.
>
> Kernel version: 4.4.138-cip25-rt19
> Architecture: x86_64
> gcc: 4.9.2 (Debian 8)
>
> This issue seems to be caused by 3d3bc507 in CIP (99f499cd in upstream) [1],
> and the patch is already merged in the upstream.
> https://git.kernel.org/pub/scm/linux/kernel/git/bwh/linux-cip.git/commit/?id=3d3bc50700ba7e7c370229f20f0b3ddafc1562cd
>
> Please consider to apply the patch to 4.4-cip as well.
>
> [1] https://lists.01.org/pipermail/kbuild-all/2016-September/025744.html
We are building that config, and I just checked my last log for 138-cip25 -
nothing. Maybe it was surfaced by some change after that release.
Jan
--
Siemens AG, Corporate Technology, CT RDA IOT SES-DE
Corporate Competence Center Embedded Linux
_______________________________________________
cip-dev mailing list
cip-dev at lists.cip-project.org
https://lists.cip-project.org/mailman/listinfo/cip-dev
^ permalink raw reply [flat|nested] 5+ messages in thread
* [cip-dev] [PATCH] spi: pxa2xx: Fix build error because of missing header
2018-09-18 7:07 ` nobuhiro.iwamatsu at cybertrust.co.jp
@ 2018-09-18 8:16 ` Kazuhiro Hayashi
0 siblings, 0 replies; 5+ messages in thread
From: Kazuhiro Hayashi @ 2018-09-18 8:16 UTC (permalink / raw)
To: cip-dev
Hello Jan, Nobuhiro,
Thank you for your confirmation.
The error occurs only when CONFIG_GPIOLIB=n,
so the patch should be applied for such configs.
If CONFIG_GPIOLIB=y, pxa2xx.c indirectly includes <linux/gpio/consumer.h>:
(linux/gpio.h => asm-generic/gpio.h => linux/gpio/consumer.h)
Best regards,
Kazu
On 2018/09/18 16:07, nobuhiro.iwamatsu at cybertrust.co.jp wrote:
> Hi,
>
>>> Please consider to apply the patch to 4.4-cip as well.
>>>
>>> [1] https://lists.01.org/pipermail/kbuild-all/2016-September/025744.html
>>
>> We are building that config, and I just checked my last log for 138-cip25 -
>> nothing. Maybe it was surfaced by some change after that release.
>
> I could confirm with x86, arm does not have this problem.
>
> Best regards,
> Nobuhiro
> ________________________________________
> ???: cip-dev-bounces at lists.cip-project.org <cip-dev-bounces@lists.cip-project.org> ? Jan Kiszka <jan.kiszka@siemens.com> ??????
> ????: 2018?9?18? 14:18
> ??: HAYASHI Kazuhiro; cip-dev at lists.cip-project.org
> ??: Re: [cip-dev] [PATCH] spi: pxa2xx: Fix build error because of missing header
>
> On 18.09.18 06:25, HAYASHI Kazuhiro wrote:
>> Hi,
>>
>> On 2018/09/18 13:10, Kazuhiro Hayashi wrote:
>>> From: Mika Westerberg <mika.westerberg@linux.intel.com>
>>>
>>> commit 089bd46d8bc1fe5a28351e82e4adcaa5a40121b5 upstream.
>>>
>>> Kbuild test robot reports:
>>>
>>> drivers/spi/spi-pxa2xx.c: In function ?setup_cs?:
>>> drivers/spi/spi-pxa2xx.c:1190:20: error: implicit declaration of function
>>> ?desc_to_gpio?
>>> ...
>> I got the above error when I enabled pxa2xx by
>> CONFIG_SPI_PXA2XX_DMA=y
>> CONFIG_SPI_PXA2XX=y
>> CONFIG_SPI_PXA2XX_PCI=y
>> and confirmed that the patch fixes the issue.
>>
>> Kernel version: 4.4.138-cip25-rt19
>> Architecture: x86_64
>> gcc: 4.9.2 (Debian 8)
>>
>> This issue seems to be caused by 3d3bc507 in CIP (99f499cd in upstream) [1],
>> and the patch is already merged in the upstream.
>> https://git.kernel.org/pub/scm/linux/kernel/git/bwh/linux-cip.git/commit/?id=3d3bc50700ba7e7c370229f20f0b3ddafc1562cd
>>
>> Please consider to apply the patch to 4.4-cip as well.
>>
>> [1] https://lists.01.org/pipermail/kbuild-all/2016-September/025744.html
>
> We are building that config, and I just checked my last log for 138-cip25 -
> nothing. Maybe it was surfaced by some change after that release.
>
> Jan
>
> --
> Siemens AG, Corporate Technology, CT RDA IOT SES-DE
> Corporate Competence Center Embedded Linux
> _______________________________________________
> cip-dev mailing list
> cip-dev at lists.cip-project.org
> https://lists.cip-project.org/mailman/listinfo/cip-dev
>
>
--
Kazuhiro Hayashi
Corporate Software Engineering & Technology Center
Toshiba Corporation
Tel: +8144-549-2476
E-mail: kazuhiro3.hayashi at toshiba.co.jp
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-09-18 8:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-09-18 4:10 [cip-dev] [PATCH] spi: pxa2xx: Fix build error because of missing header Kazuhiro Hayashi
2018-09-18 4:25 ` HAYASHI Kazuhiro
2018-09-18 5:18 ` Jan Kiszka
2018-09-18 7:07 ` nobuhiro.iwamatsu at cybertrust.co.jp
2018-09-18 8:16 ` Kazuhiro Hayashi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).