* Re: [Cocci] [PATCH net-next v1] can: ti_hecc: convert to devm_platform_ioremap_resource_byname()
@ 2020-04-19 16:19 Markus Elfring
2020-04-20 13:13 ` Dejin Zheng
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2020-04-19 16:19 UTC (permalink / raw)
To: Dejin Zheng, linux-can, netdev, David S. Miller,
Marc Kleine-Budde, Wolfgang Grandegger
Cc: kernel-janitors, linux-kernel, Coccinelle
> use devm_platform_ioremap_resource_byname() to simplify code,
> it contains platform_get_resource_byname() and
> devm_ioremap_resource(), and also remove some duplicate error
> message.
How do you think about a wording variant like the following?
Use the function “devm_platform_ioremap_resource_byname” to simplify
source code which calls the functions “platform_get_resource_byname”
and “devm_ioremap_resource”.
Remove also a few error messages which became unnecessary with this
software refactoring.
Will any more contributors get into the development mood to achieve
similar collateral evolution by the means of the semantic patch language?
Would you like to increase applications of the Coccinelle software?
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Cocci] [PATCH net-next v1] can: ti_hecc: convert to devm_platform_ioremap_resource_byname()
2020-04-19 16:19 [Cocci] [PATCH net-next v1] can: ti_hecc: convert to devm_platform_ioremap_resource_byname() Markus Elfring
@ 2020-04-20 13:13 ` Dejin Zheng
0 siblings, 0 replies; 2+ messages in thread
From: Dejin Zheng @ 2020-04-20 13:13 UTC (permalink / raw)
To: Markus Elfring
Cc: netdev, kernel-janitors, linux-kernel, linux-can,
Marc Kleine-Budde, Coccinelle, David S. Miller,
Wolfgang Grandegger
On Sun, Apr 19, 2020 at 06:19:12PM +0200, Markus Elfring wrote:
> > use devm_platform_ioremap_resource_byname() to simplify code,
> > it contains platform_get_resource_byname() and
> > devm_ioremap_resource(), and also remove some duplicate error
> > message.
>
> How do you think about a wording variant like the following?
>
> Use the function “devm_platform_ioremap_resource_byname” to simplify
> source code which calls the functions “platform_get_resource_byname”
> and “devm_ioremap_resource”.
> Remove also a few error messages which became unnecessary with this
> software refactoring.
>
Markus, Thank you very much！yes, your comments is better. I will send
the patch v2. Thanks again!
>
> Will any more contributors get into the development mood to achieve
> similar collateral evolution by the means of the semantic patch language?
> Would you like to increase applications of the Coccinelle software?
>
I want, but currently I don't have much free time, sorry！
BR,
Dejin
> Regards,
> Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-04-20 15:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-19 16:19 [Cocci] [PATCH net-next v1] can: ti_hecc: convert to devm_platform_ioremap_resource_byname() Markus Elfring
2020-04-20 13:13 ` Dejin Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).