From: Markus Elfring <Markus.Elfring@web.de>
To: Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] Moving exception handling code to the end of a function implementation with SmPL?
Date: Thu, 31 Oct 2019 13:27:39 +0100 [thread overview]
Message-ID: <226b4ce7-8284-ed03-a478-98e3e532cb15@web.de> (raw)
In-Reply-To: <708207db-69d7-8962-e507-cd705142d0c4@web.de>
> Unfortunately, I stumble on the error message “replacement: already tagged token:
> C code context” then.
It might be that the transformation approach was too generic for
the implementation of the function “megasas_mgmt_ioctl_fw”.
https://elixir.bootlin.com/linux/v5.4-rc5/source/drivers/scsi/megaraid/megaraid_sas_base.c#L8258
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/scsi/megaraid/megaraid_sas_base.c?id=e472c64aa4fa6150c6076fd36d101d667d71c30a#n8258
The following SmPL script variant can generate an usable test result.
@replacement@
expression result;
identifier work;
type t != void;
@@
t work(...)
{
<+...
if (...)
(
-{
-result = -ENODEV;
goto
- out_kfree_ioc
+ e_nodev
;
-}
|
{
...
-result = -ENODEV;
goto
- out_kfree_ioc
+ e_nodev
;
}
)
...+>
out_kfree_ioc:
... when exists
return result;
+e_nodev:
+result = -ENODEV;
+goto out_kfree_ioc;
}
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2019-10-31 12:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 17:45 [Cocci] Moving exception handling code to the end of a function implementation with SmPL? Markus Elfring
2019-06-27 8:33 ` Markus Elfring
2019-06-27 11:33 ` Julia Lawall
2019-06-27 12:18 ` Markus Elfring
[not found] ` <alpine.DEB.2.21.1906271427250.2627@hadrien>
2019-06-27 12:45 ` Markus Elfring
2019-06-27 14:12 ` Markus Elfring
2019-06-27 14:54 ` Julia Lawall
2019-06-27 15:01 ` Markus Elfring
2019-10-31 12:27 ` Markus Elfring [this message]
2019-10-31 12:42 ` Julia Lawall
2019-10-31 13:50 ` Markus Elfring
2019-11-01 9:12 ` [Cocci] Checking the occurrence of trailing spaces in a semantic patch Markus Elfring
2019-11-01 9:38 ` Julia Lawall
2019-11-01 9:56 ` Markus Elfring
2019-11-01 11:50 ` Markus Elfring
2019-11-01 16:03 ` [Cocci] Checking code layout for adding jump targets with SmPL Markus Elfring
2019-11-01 16:12 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=226b4ce7-8284-ed03-a478-98e3e532cb15@web.de \
--to=markus.elfring@web.de \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).