From: Julia Lawall <julia.lawall@lip6.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Coccinelle <cocci@systeme.lip6.fr>
Subject: Re: [Cocci] Checking the occurrence of trailing spaces in a semantic patch
Date: Fri, 1 Nov 2019 10:38:08 +0100 (CET) [thread overview]
Message-ID: <alpine.DEB.2.21.1911011037250.2883@hadrien> (raw)
In-Reply-To: <08618116-cd93-fedb-f90e-64c17b319794@web.de>
[-- Attachment #1: Type: text/plain, Size: 937 bytes --]
On Fri, 1 Nov 2019, Markus Elfring wrote:
> > The following SmPL script variant can generate an usable test result.
>
> Yesterday I noticed during the preparation of a corresponding commit
> that unwanted space characters were added at three places in the generated patch.
>
> elfring@Sonne:~/Projekte/Linux/next-patched> spatch --in-place drivers/scsi/megaraid/megaraid_sas_base.c ~/Projekte/Coccinelle/janitor/move_error_code_assignment_to_function_end2.cocci
>
> git GUI:
> …
> @@ -8270,31 +8270,24 @@ static int megasas_mgmt_ioctl_fw(struct file *file, unsigned long arg)
> …
> + if (!instance)
> …
> + if (instance->requestorId && !allow_vf_ioctls)
> …
> + if (instance->unload == 1)
> …
And the unwanted space characters are where?
>
> How would you like to improve the pretty-printing for the Coccinelle software?
I don't know. How would you like to improve the pretty-printing for the
Coccinelle software?
julia
[-- Attachment #2: Type: text/plain, Size: 136 bytes --]
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
next prev parent reply other threads:[~2019-11-01 9:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-21 17:45 [Cocci] Moving exception handling code to the end of a function implementation with SmPL? Markus Elfring
2019-06-27 8:33 ` Markus Elfring
2019-06-27 11:33 ` Julia Lawall
2019-06-27 12:18 ` Markus Elfring
[not found] ` <alpine.DEB.2.21.1906271427250.2627@hadrien>
2019-06-27 12:45 ` Markus Elfring
2019-06-27 14:12 ` Markus Elfring
2019-06-27 14:54 ` Julia Lawall
2019-06-27 15:01 ` Markus Elfring
2019-10-31 12:27 ` Markus Elfring
2019-10-31 12:42 ` Julia Lawall
2019-10-31 13:50 ` Markus Elfring
2019-11-01 9:12 ` [Cocci] Checking the occurrence of trailing spaces in a semantic patch Markus Elfring
2019-11-01 9:38 ` Julia Lawall [this message]
2019-11-01 9:56 ` Markus Elfring
2019-11-01 11:50 ` Markus Elfring
2019-11-01 16:03 ` [Cocci] Checking code layout for adding jump targets with SmPL Markus Elfring
2019-11-01 16:12 ` Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.21.1911011037250.2883@hadrien \
--to=julia.lawall@lip6.fr \
--cc=Markus.Elfring@web.de \
--cc=cocci@systeme.lip6.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).