From: Ricardo Ribalda <ribalda@chromium.org>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: Julia Lawall <Julia.Lawall@inria.fr>,
cocci@inria.fr, LKML <linux-kernel@vger.kernel.org>,
Denis Efremov <efremov@linux.com>,
Nicolas Palix <nicolas.palix@imag.fr>
Subject: Re: [cocci] [PATCH] coccinelle: misc: minmax: Suppress reports for err returns
Date: Tue, 16 Apr 2024 13:32:52 +0200 [thread overview]
Message-ID: <CANiDSCuvXvjfhw2mjSef1wR8RiL=9KrDEoh+3o1ed4+8P+AqGw@mail.gmail.com> (raw)
In-Reply-To: <fbf22b53-7b68-4e60-99c7-ab38a77a53c8@web.de>
Hi Markus
On Tue, 16 Apr 2024 at 13:30, Markus Elfring <Markus.Elfring@web.de> wrote:
>
> …
> > +++ b/scripts/coccinelle/misc/minmax.cocci
> > @@ -50,11 +50,26 @@ func(...)
> > ...>
> > }
> >
> > +// Ignore errcode returns.
> > +@errcode@
> …
>
> I see that you would like to omit the specification “depends on patch”
> from the previous SmPL rule location.
>
> Would you really like to influence and adjust SmPL code any more
> according to affected coccicheck operation modes?
I probably do not know what I am doing :), it is my first .cocci patch.
If I leave the "depends on patch", then the change is ignored in report mode.
I think errcode needs to be executed in report and in patch mode, but
there might be a better way to do it.
>
> Regards,
> Markus
--
Ricardo Ribalda
next prev parent reply other threads:[~2024-04-16 12:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 21:15 [cocci] [PATCH] coccinelle: misc: minmax: Suppress reports for err returns Ricardo Ribalda
2024-04-16 8:32 ` Julia Lawall
2024-04-16 11:30 ` Markus Elfring
2024-04-16 11:32 ` Ricardo Ribalda [this message]
2024-04-16 11:50 ` Markus Elfring
[not found] ` <CANiDSCtZzAs0u2tqJGRaJz6iqCTu_p-j_rkyGU7a9HFqUbJEMg@mail.gmail.com>
2024-04-17 13:02 ` [cocci] " Markus Elfring
2024-04-18 20:55 ` [cocci] [PATCH] " Julia Lawall
2024-04-19 6:51 ` Markus Elfring
2024-04-19 7:01 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANiDSCuvXvjfhw2mjSef1wR8RiL=9KrDEoh+3o1ed4+8P+AqGw@mail.gmail.com' \
--to=ribalda@chromium.org \
--cc=Julia.Lawall@inria.fr \
--cc=Markus.Elfring@web.de \
--cc=cocci@inria.fr \
--cc=efremov@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).