From: Julia Lawall <julia.lawall@inria.fr>
To: Ricardo Ribalda <ribalda@chromium.org>
Cc: Nicolas Palix <nicolas.palix@imag.fr>,
Denis Efremov <efremov@linux.com>,
cocci@inria.fr, linux-kernel@vger.kernel.org
Subject: Re: [cocci] [PATCH] coccinelle: misc: minmax: Suppress reports for err returns
Date: Thu, 18 Apr 2024 22:55:23 +0200 (CEST) [thread overview]
Message-ID: <alpine.DEB.2.22.394.2404182255010.3213@hadrien> (raw)
In-Reply-To: <20240415-minimax-v1-1-5feb20d66a79@chromium.org>
On Mon, 15 Apr 2024, Ricardo Ribalda wrote:
> Most of the people prefer:
>
> return ret < 0 ? ret: 0;
>
> than:
>
> return min(ret, 0);
>
> Let's tweak the cocci file to ignore those lines completely.
>
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Applied, thanks. (Coccinelle for-6.10 branch).
julia
> ---
> Following discussion at:
> https://lore.kernel.org/linux-media/20240415203304.GA3460978@ragnatech.se/T/#m4dce34572312bd8a02542d798f21af7e4fc05fe8
> ---
> scripts/coccinelle/misc/minmax.cocci | 32 ++++++++++++++++----------------
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/scripts/coccinelle/misc/minmax.cocci b/scripts/coccinelle/misc/minmax.cocci
> index fcf908b34f27..ca4830ae3042 100644
> --- a/scripts/coccinelle/misc/minmax.cocci
> +++ b/scripts/coccinelle/misc/minmax.cocci
> @@ -50,11 +50,26 @@ func(...)
> ...>
> }
>
> +// Ignore errcode returns.
> +@errcode@
> +position p;
> +identifier func;
> +expression x;
> +binary operator cmp = {<, <=};
> +@@
> +
> +func(...)
> +{
> + <...
> + return ((x) cmp@p 0 ? (x) : 0);
> + ...>
> +}
> +
> @rmin depends on !patch@
> identifier func;
> expression x, y;
> binary operator cmp = {<, <=};
> -position p;
> +position p != errcode.p;
> @@
>
> func(...)
> @@ -116,21 +131,6 @@ func(...)
> ...>
> }
>
> -// Don't generate patches for errcode returns.
> -@errcode depends on patch@
> -position p;
> -identifier func;
> -expression x;
> -binary operator cmp = {<, <=};
> -@@
> -
> -func(...)
> -{
> - <...
> - return ((x) cmp@p 0 ? (x) : 0);
> - ...>
> -}
> -
> @pmin depends on patch@
> identifier func;
> expression x, y;
>
> ---
> base-commit: 71b3ed53b08d87212fbbe51bdc3bf44eb8c462f8
> change-id: 20240415-minimax-1e9110d4697b
>
> Best regards,
> --
> Ricardo Ribalda <ribalda@chromium.org>
>
>
next prev parent reply other threads:[~2024-04-18 20:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-15 21:15 [cocci] [PATCH] coccinelle: misc: minmax: Suppress reports for err returns Ricardo Ribalda
2024-04-16 8:32 ` Julia Lawall
2024-04-16 11:30 ` Markus Elfring
2024-04-16 11:32 ` Ricardo Ribalda
2024-04-16 11:50 ` Markus Elfring
[not found] ` <CANiDSCtZzAs0u2tqJGRaJz6iqCTu_p-j_rkyGU7a9HFqUbJEMg@mail.gmail.com>
2024-04-17 13:02 ` [cocci] " Markus Elfring
2024-04-18 20:55 ` Julia Lawall [this message]
2024-04-19 6:51 ` [cocci] [PATCH] " Markus Elfring
2024-04-19 7:01 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.DEB.2.22.394.2404182255010.3213@hadrien \
--to=julia.lawall@inria.fr \
--cc=cocci@inria.fr \
--cc=efremov@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
--cc=ribalda@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).