* Re: [Cocci] [PATCH v2] scripts: coccicheck: Do not use shift command when rule is specified
@ 2020-09-09 8:50 Markus Elfring
2020-09-09 9:01 ` Julia Lawall
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2020-09-09 8:50 UTC (permalink / raw)
To: Sumera Priyadarsini, Coccinelle
Cc: Michal Marek, Gilles Muller, Nicolas Palix, kernel-janitors,
linux-kernel, Julia Lawall
> Modify coccicheck to use the shift command only when
> number of shell arguments is not zero.
I suggest to add the tag “Fixes” to the commit message.
> Changes in V2:
> - Fix spelling errors as suggested by Markus Elfring
Would you like to adjust the last word in the previous patch subject accordingly?
Regards,
Markus
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Cocci] [PATCH v2] scripts: coccicheck: Do not use shift command when rule is specified
2020-09-09 8:50 [Cocci] [PATCH v2] scripts: coccicheck: Do not use shift command when rule is specified Markus Elfring
@ 2020-09-09 9:01 ` Julia Lawall
0 siblings, 0 replies; 2+ messages in thread
From: Julia Lawall @ 2020-09-09 9:01 UTC (permalink / raw)
To: Markus Elfring
Cc: Michal Marek, Gilles Muller, kernel-janitors, Nicolas Palix,
linux-kernel, Coccinelle
[-- Attachment #1: Type: text/plain, Size: 764 bytes --]
On Wed, 9 Sep 2020, Markus Elfring wrote:
> > Modify coccicheck to use the shift command only when
> > number of shell arguments is not zero.
>
> I suggest to add the tag “Fixes” to the commit message.
I don't think there is any need for that. This is not a patch that should
be backported. The previous situation did not cause any problem with the
execution of make coccicheck, only a tiresome warning message.
julia
>
>
> > Changes in V2:
> > - Fix spelling errors as suggested by Markus Elfring
>
> Would you like to adjust the last word in the previous patch subject accordingly?
>
> Regards,
> Markus
> _______________________________________________
> Cocci mailing list
> Cocci@systeme.lip6.fr
> https://systeme.lip6.fr/mailman/listinfo/cocci
>
[-- Attachment #2: Type: text/plain, Size: 136 bytes --]
_______________________________________________
Cocci mailing list
Cocci@systeme.lip6.fr
https://systeme.lip6.fr/mailman/listinfo/cocci
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-09 9:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-09 8:50 [Cocci] [PATCH v2] scripts: coccicheck: Do not use shift command when rule is specified Markus Elfring
2020-09-09 9:01 ` Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).