RE: [PATCH] service: Fix default service update on ready state

["VAUTRIN Emmanuel (Canal Plus Prestataire)" <Emmanuel.VAUTRIN@cpexterne.org>]

> By moving default_changed() after
>        def_service = connman_service_get_default();
>        service_update_preferred_order(def_service, service, new_state);
>
> the result is the code doesn't make sense anymore. Why calling
> service_update_preferred_order *before* we change the default?
>
> This is the very reason I am pushing back against these changes. They
> look innocent and might even work for some cases, but anyone later
> looking at this code will scratch his head and will say "this doesn't
> make sense". Also The commit message saying "the default shall be
> re-evaluated" doesn't help either. You need to explain why you need to
> change the order and why service_update_preferred_order() should operate
> on the 'outdated' default route.
Daniel,

I shall admit this part is really complex, with separated updates of the 
default service and the service list, so maybe it is not the best choice.
I propose to run my full test campaign again and check for a better solution
(or at least to describe the issues I am facing), after the completion of the topic
"service: Ignore state information in service reordering".


Best Regards,

Emmanuel