From: "VAUTRIN Emmanuel (Canal Plus Prestataire)" <Emmanuel.VAUTRIN@cpexterne.org>
To: "connman@lists.linux.dev" <connman@lists.linux.dev>
Subject: [PATCH] service: Fix default service update on ready state
Date: Wed, 23 Jun 2021 12:18:13 +0000 [thread overview]
Message-ID: <PR1PR02MB47948663CF8C18C7FD1AAC6693089@PR1PR02MB4794.eurprd02.prod.outlook.com> (raw)
On a ready state transition, the default service shall be re-evaluated
after the preferred service reordering, before being processed.
---
src/service.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/service.c b/src/service.c
index eb74a85d6e32..cb0103fd7221 100644
--- a/src/service.c
+++ b/src/service.c
@@ -6051,12 +6051,12 @@ static int service_indicate_state(struct connman_service *service)
service->new_service = false;
- default_changed();
-
def_service = connman_service_get_default();
service_update_preferred_order(def_service, service, new_state);
+ default_changed();
+
__connman_service_set_favorite(service, true);
reply_pending(service, 0);
--
2.25.1
next reply other threads:[~2021-06-23 12:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 12:18 VAUTRIN Emmanuel (Canal Plus Prestataire) [this message]
2021-06-24 8:07 ` [PATCH] service: Fix default service update on ready state Daniel Wagner
2021-06-24 9:01 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-07-02 7:27 ` Daniel Wagner
2021-07-02 7:41 ` Daniel Wagner
2021-07-02 15:43 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-08-25 12:52 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-08-29 19:07 ` Daniel Wagner
2021-08-30 7:31 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-08-30 8:13 ` Daniel Wagner
2021-08-30 8:28 ` VAUTRIN Emmanuel (Canal Plus Prestataire)
2021-08-30 8:44 ` Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PR1PR02MB47948663CF8C18C7FD1AAC6693089@PR1PR02MB4794.eurprd02.prod.outlook.com \
--to=emmanuel.vautrin@cpexterne.org \
--cc=connman@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).